Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <6f69677c-18d9-abd9-93d7-cf1f29603ed6@roeck-us.net>
Date:   Mon, 2 May 2022 21:37:16 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Content-Language: en-US
To:     Tzung-Bi Shih <tzungbi@kernel.org>,
        =?UTF-8?Q?Pali_Roh=c3=a1r?= <pali@kernel.org>
Cc:     Wim Van Sebroeck <wim@linux-watchdog.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220429131349.21229-1-pali@kernel.org>
 <20220429131349.21229-2-pali@kernel.org> <YnCoQUGQsXIfbowQ@google.com>
From:   Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v2 2/2] watchdog: max63xx_wdt: Add support for specifying
 WDI logic via GPIO
In-Reply-To: <YnCoQUGQsXIfbowQ@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 5/2/22 20:57, Tzung-Bi Shih wrote:
> On Fri, Apr 29, 2022 at 03:13:49PM +0200, Pali Rohár wrote:
>> @@ -27,6 +27,7 @@
>>   #include <linux/io.h>
>>   #include <linux/slab.h>
>>   #include <linux/property.h>
>> +#include <linux/gpio/consumer.h>
> 
> It would be better to keep them alphabetically.  Anyway, they aren't sorted
> originally...
> 
>> +static void max63xx_gpio_ping(struct max63xx_wdt *wdt)
>> +{
>> +	spin_lock(&wdt->lock);
> 
> Does it really need to acquire the lock?  It looks like the lock is to prevent
> concurrent accesses to the mmap in max63xx_mmap_ping() and max63xx_mmap_set().
> 

Actually, that doesn't work at all. spin_lock() directly contradicts
with gpiod_set_value_cansleep().

>> +	gpiod_set_value_cansleep(wdt->gpio_wdi, 1);
>> +	udelay(1);
> 
> Doesn't it need to include <linux/delay.h> for udelay()?
> 
>> @@ -225,10 +240,19 @@ static int max63xx_wdt_probe(struct platform_device *pdev)
>>   		return -EINVAL;
>>   	}
>>   
>> +	wdt->gpio_wdi = devm_gpiod_get(dev, NULL, GPIOD_FLAGS_BIT_DIR_OUT);
>> +	if (IS_ERR(wdt->gpio_wdi) && PTR_ERR(wdt->gpio_wdi) != -ENOENT)
> 
> Use devm_gpiod_get_optional() to make the intent clear.  Also, it gets rid of
> the check for -ENOENT.
> 
>> +		return dev_err_probe(dev, PTR_ERR(wdt->gpio_wdi),
>> +				     "unable to request gpio: %ld\n",
>> +				     PTR_ERR(wdt->gpio_wdi));
> 
> It doesn't need to again print for PTR_ERR(wdt->gpio_wdi).  dev_err_probe()
> prints the error.
> 
>>   	err = max63xx_mmap_init(pdev, wdt);
>>   	if (err)
>>   		return err;
>>   
>> +	if (!IS_ERR(wdt->gpio_wdi))
>> +		wdt->ping = max63xx_gpio_ping;
> 
> Thus, the max63xx_gpio_ping() overrides max63xx_mmap_ping() if the GPIO was
> provided?  It would be better to mention the behavior in the commit message.
> 
> Also, could both the assignments of `wdt->gpio_wdi` and `wdt->ping` happen
> after max63xx_mmap_init()?