Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp388973iob; Mon, 2 May 2022 23:50:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwIZvXOHRB/je8gRkI8AwVAZ556vuR1yukCtCeL3/nLBE2YP1V6EXnKcuJc2euWy/VDy+E7 X-Received: by 2002:ac2:482f:0:b0:472:47d5:ef32 with SMTP id 15-20020ac2482f000000b0047247d5ef32mr10522850lft.344.1651560645408; Mon, 02 May 2022 23:50:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651560645; cv=none; d=google.com; s=arc-20160816; b=aTmsbUtgWwbVCqBt4b+kpiE237UBgMugWFkOanla77FQfU5O0q2wS2ti39z4y1Bh5n qCJTpeqrMrZvyS+xprLM9jOW6AxXxsSh+Uyc5cPN1TgHp3EJWa+FYle4cM6LFU41dr5C rjUvjDU69tssOnaFDcjlt1FRpQLNbf7RKWlR+0QTMl6yR4TNs1kB/poEduJVQ3Eprkd0 cZG7AZqyT2dfJCGgzJn5ijdccoAFDOmdWSzt+DF9/XewDHd26rqLDOZ63fEB1y4s9gGy cdMAgENv7vOIN4JFJuMDMMtznvbEilq62pC39JSjTfPUbqaPyJ7mpLjGC0Ts849qizCP /ZYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-signature; bh=/LPOPn3cUAhg8MFXCjzVL28Mjke6V4g5iBBHycWtpNw=; b=uW1bJpxkrE2GeLdnb5sq8a/RkHGpEgOdouwtscTDwckyN8oEcQjtvoZDcbT5GLIqq0 Er9LIKH1P/76cSmnxu9jUnGkonHsgtjj927u4QDyCpjjBwFOZNV1m3r1GDRZSnvkg+aF pnb0uUN9YobB2Jiw88zDlCNJGXv/KX0Q87Jno/iKb9Yx4JjSJ8b6sc+rgb27EOtZ7M9/ 70YtYcipVz0Yqqre1zZi7pbOVpJZWp3DMMSQQ/CiI29xxyffYuw6aJb/vrjF6uKAj1Cd JLY/nP9XqRI02CReWMutiuk9F3dpHtijxpbLdkbTbn9NkFqOCSQhtWTx04zX9eai62Hf V5eQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=CLC8WZ6e; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 26-20020a2e081a000000b0024dd580a110si15788258lji.372.2022.05.02.23.50.16; Mon, 02 May 2022 23:50:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=CLC8WZ6e; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229939AbiECGfE (ORCPT + 99 others); Tue, 3 May 2022 02:35:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229789AbiECGe7 (ORCPT ); Tue, 3 May 2022 02:34:59 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BC43381A6; Mon, 2 May 2022 23:31:27 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 21C2F1F747; Tue, 3 May 2022 06:31:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1651559486; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=/LPOPn3cUAhg8MFXCjzVL28Mjke6V4g5iBBHycWtpNw=; b=CLC8WZ6eVqlKqOVcLHyslXW6PY5PK263n3dsz9eRSe1X7lwGkEKToDy5+eMsGzspwyA16p bHgIY3uxjFapKyZOLm5Bzmq0liqCrR0iZVm2ixZ2HnpWCm0/WHqz0A/TcxGNTyBFlRIa8G xkwjgFHYAaZVYTxOMOxX0w/E+uSodgw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1651559486; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=/LPOPn3cUAhg8MFXCjzVL28Mjke6V4g5iBBHycWtpNw=; b=+LFNd/FGqbQWecAZLBPSuPiuYMu9SgmJVPmTilWo+M9EJoDeOqLNOfHStql4UUOZWcMSq4 cEul5ok/l4njIvBw== Received: from localhost.localdomain (unknown [10.100.208.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id E1E882C141; Tue, 3 May 2022 06:31:25 +0000 (UTC) From: Jiri Slaby To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Slaby Subject: [PATCH 00/11] serial: pic32: cleanup Date: Tue, 3 May 2022 08:31:11 +0200 Message-Id: <20220503063122.20957-1-jslaby@suse.cz> X-Mailer: git-send-email 2.36.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series: * ! re-enables disabled irqs in pic32_uart_startup() (*) * removes unused/unneeded stuff * merges a separate .h into .c * avoids potentially broken macros * performs other cleanups (*) I'm not sure how this driver could work until now. Maybe there is some coincidental enablement of irqs I don't see. A contact to people from microchip would be highly appreciated to check with them. Jiri Slaby (11): serial: pic32: remove unused items from the header serial: pic32: move header content to .c serial: pic32: remove constants from struct pic32_sport serial: pic32: simplify clk handling serial: pic32: simplify pic32_sport::enable_tx_irq handling serial: pic32: remove pic32_get_port() macro serial: pic32: convert to_pic32_sport() to an inline serial: pic32: don't assign pic32_sport::cts_gpio twice serial: pic32: don't zero members of kzalloc-ated structure serial: pic32: free up irq names correctly serial: pic32: restore disabled irqs in pic32_uart_startup() drivers/tty/serial/pic32_uart.c | 159 +++++++++++++++++++++++--------- drivers/tty/serial/pic32_uart.h | 125 ------------------------- 2 files changed, 116 insertions(+), 168 deletions(-) delete mode 100644 drivers/tty/serial/pic32_uart.h -- 2.36.0