Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp389625iob; Mon, 2 May 2022 23:52:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxud9UFUiQrCt83pNo4ecI2T96buqvGokv0FqC9R7m6hyqbqoQo7/JRM2bNyiDtP/fgSY8 X-Received: by 2002:a05:6512:2601:b0:464:f8ca:979a with SMTP id bt1-20020a056512260100b00464f8ca979amr11000351lfb.84.1651560746913; Mon, 02 May 2022 23:52:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651560746; cv=none; d=google.com; s=arc-20160816; b=deZFgxTPwaLKSi6NvkPXFPc+q9hRoZakMgFH9MxXPXjrKV+cON8LaYcLcaGdFmaQ5Y FRarB2uq3C1PwDMLIGXN4s0QRZl1+QVNnEjMOqhE7qaW8bEh2SdevBzNiCRmOB3Gyz6y WhVkDrX7RfT8dM122R+J3HvJ4UDdjAji7pRoL6FwgxnzC7xtOZ0VmCICZfnez/3I0py7 Iv83+T8/haGTpghg5hSYUfa1LPQEG5PWolWoZzAC87zFEir7q5OCZLwRq4pEyEBcBQh6 a5mvy5HR2LBnN1Z/UcA7nbuR/GqpWz+/vNCZ3i2T9MoqebJYFL5kXLwwBTM+8EKXkXIf C4bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=tSVRncgXdxhSPnVu1HuIPNNJumIspe/QnB20qz/St8A=; b=tPlDL3Mh40bylLn/BnkAIWKhxb7vbsNbwhcmfFsqzFKbltrDBxZKhjssSI37kZ9aFv TErFxyYddE3F5/EuqzUXARPGIcO3UclbX+POFGqAKhcSlAdl6igym3Rfjab57m1SASbz 3mM/yxN18iQ4sx20JvNYeIFfvOmUjM5uyjOhMrWYDBmG45B+hVZp2WkJiV6l3YtP1UQ+ aTXUCtJS48Uc1QBY52gxR+F2R2CrTBchhEsJzj5ovme9Vsk9iSrw9aji4/S60UpqFmr3 P49xTkyZlyC8xJeu2X+1fQxVyOjoQqTS2728Pg0c9SB0tjNZ8rCO5uw9rU0TX30lW3UF kgiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=livOX+eq; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w6-20020a056512098600b00471feb14fc0si13455111lft.362.2022.05.02.23.51.59; Mon, 02 May 2022 23:52:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=livOX+eq; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230087AbiECGfu (ORCPT + 99 others); Tue, 3 May 2022 02:35:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229921AbiECGfC (ORCPT ); Tue, 3 May 2022 02:35:02 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B83F381B2; Mon, 2 May 2022 23:31:29 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 562DB1F74C; Tue, 3 May 2022 06:31:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1651559488; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tSVRncgXdxhSPnVu1HuIPNNJumIspe/QnB20qz/St8A=; b=livOX+eqi0gqvVmRuIoSMusLlBiZsQJe79CErg/SCugI6OfWuMX39YzG98FzqW0zWQldFk MRrH57oXVUw7ZHCQHnL6nIAeOjHep/yuG65lsZvREaP5FGZnKzcirGpOXUV0kN0deqCewU xQC+oDAk211IIhDrB0RXRBxBxaHKwu0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1651559488; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tSVRncgXdxhSPnVu1HuIPNNJumIspe/QnB20qz/St8A=; b=iy/H9Iu8/5AC8ky2uJdj5hCRPtHFsk/ianeeCPqclSW6ijOcXHI/oERBEz2bRJzcfCWieY kunN/D42qT4fJaDw== Received: from localhost.localdomain (unknown [10.100.208.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 216502C141; Tue, 3 May 2022 06:31:28 +0000 (UTC) From: Jiri Slaby To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Slaby Subject: [PATCH 08/11] serial: pic32: don't assign pic32_sport::cts_gpio twice Date: Tue, 3 May 2022 08:31:19 +0200 Message-Id: <20220503063122.20957-9-jslaby@suse.cz> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220503063122.20957-1-jslaby@suse.cz> References: <20220503063122.20957-1-jslaby@suse.cz> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sport->cts_gpio is first assigned -EINVAL and few lines below using of_get_named_gpio(). Remove the first (useless) assignment. Signed-off-by: Jiri Slaby --- drivers/tty/serial/pic32_uart.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/tty/serial/pic32_uart.c b/drivers/tty/serial/pic32_uart.c index c3b4fd0b5b76..08e79d7f34f7 100644 --- a/drivers/tty/serial/pic32_uart.c +++ b/drivers/tty/serial/pic32_uart.c @@ -892,7 +892,6 @@ static int pic32_uart_probe(struct platform_device *pdev) sport->irq_rx = irq_of_parse_and_map(np, 1); sport->irq_tx = irq_of_parse_and_map(np, 2); sport->clk = devm_clk_get(&pdev->dev, NULL); - sport->cts_gpio = -EINVAL; sport->dev = &pdev->dev; /* Hardware flow control: gpios -- 2.36.0