Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp481135iob; Tue, 3 May 2022 02:59:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhluqdPh8q9e+Yd4Synfd1gipM18Bsw+rK7UGLvCi7idR9CUqE8piuBksSzhGGu6OTeK9f X-Received: by 2002:a17:90b:1d90:b0:1dc:2e4b:37c3 with SMTP id pf16-20020a17090b1d9000b001dc2e4b37c3mr3787955pjb.117.1651571948073; Tue, 03 May 2022 02:59:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651571948; cv=none; d=google.com; s=arc-20160816; b=DWeNBS/7Ep0clGEylA8JruwjN1IXqAz8KMicstosPlsQrQoD6V7T2eiGY2hyKf4ZNG GedMWr5Ehnu5WUXPTE9nhtl4X2crJHfu3BT9m7J/uQ7FobAxYxiD+qox8r4zuV77eKD7 oHLdwDssR/oyK5SGatrbRvpewXGgTRjz+crVQIzVWx+hlpzdz+u/d1kjUJq4sdut19+g 3s1rnXFHPiPlIQoFOorEYYITvNZljjmB8Xx4TqiXLR8a9ndNrD+30MzRcUCzBh/qai1E ws8BDWsJs0bJjxNTGtHD812MtPdy/83duuVm8+zYH5LNbK/QW7oBmqNnqYhqiZxZEgHt 9y9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TBjkZF+VASeBBFI1OAc29aFrXNteY0hfl/8xpsAGj6I=; b=xuORV5E4v8arP8QDdHeo3agh6YIpmpulgF/agZ7fitoPeuQVlPJSxUX0gEz3qt0ZT1 rr4QB5wXqJbE/VEhDZVgGU7A74pzCmiJZrTzYhsBO2slMthMuNlW5MG3u5c0xMBGfR/7 V3R25usWXoNNK53Aw5GIygorqcJtAPjlxOirWai9eJ7V3ORAE0AiYfEhUvmPsaG5Hwj8 e/a7AKX4peXKZ45jmaXagjDK5c+nKD6dBgxglgONLcy3XVw2PgvklglYHfM8Sss/ERt2 UFl/hNjgIjXqP6N0vpEBFrEZZgmw4NVVjLpvWMchowsMjYoc8mYsypWFvGA+Vb5/L4Ea Z4lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b=FCQjACGs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id li3-20020a17090b48c300b001d953c38941si1739607pjb.122.2022.05.03.02.58.52; Tue, 03 May 2022 02:59:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b=FCQjACGs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232905AbiECIsh (ORCPT + 99 others); Tue, 3 May 2022 04:48:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232873AbiECIsf (ORCPT ); Tue, 3 May 2022 04:48:35 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C980D3526C; Tue, 3 May 2022 01:45:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1651567502; x=1683103502; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ktAuPeikT5yIzQagKaEvWRybAOSvIjqqN73SIJDSJFk=; b=FCQjACGshnMl/hBAPhfRcId2HofyZX5ejMXGZ+FjPOwqc1PNImUp+zJm VNNe9pfBSLSxbMOV3uIFLdHPvOPv00prM5dKCo2E0TuqmLW26A/dxnPfz C95v4dg9t81e2ZOKvTG5jGUbxReJ4ROTN9jq2g1dxEKyGqVvakwHIH9Q7 TVsJm0Y5cFsT6qXd7BXQhWFueMgrXVp6mW/JVGyfKTgnnqD700OQG0o1f rVIOW3oZsy4xVveG7plJ5vH4wqeNedBrnsWopRqF+WWpOUpE3U8CMZA95 34DIfCpv0cNks0arb57+8VpCebtZOi7EIUuBRf6Ot7P/tl3Syt4DzI0K+ g==; X-IronPort-AV: E=Sophos;i="5.91,194,1647327600"; d="scan'208";a="94358168" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 03 May 2022 01:45:01 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Tue, 3 May 2022 01:45:00 -0700 Received: from ROB-ULT-M18282.microchip.com (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Tue, 3 May 2022 01:44:55 -0700 From: Eugen Hristev To: , CC: , , , , Eugen Hristev Subject: [PATCH v10 2/8] media: atmel: atmel-isc-base: replace is_streaming call in s_fmt_vid_cap Date: Tue, 3 May 2022 11:44:15 +0300 Message-ID: <20220503084421.40682-3-eugen.hristev@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220503084421.40682-1-eugen.hristev@microchip.com> References: <20220503084421.40682-1-eugen.hristev@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In s_fmt_vid_cap, we should check if vb2_is_busy and return EBUSY, not check if it's streaming to return the busy state. Suggested-by: Hans Verkuil Signed-off-by: Eugen Hristev Reviewed-by: Jacopo Mondi --- drivers/media/platform/atmel/atmel-isc-base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/atmel/atmel-isc-base.c b/drivers/media/platform/atmel/atmel-isc-base.c index d2cc6c99984f..67b4a2323fed 100644 --- a/drivers/media/platform/atmel/atmel-isc-base.c +++ b/drivers/media/platform/atmel/atmel-isc-base.c @@ -1029,7 +1029,7 @@ static int isc_s_fmt_vid_cap(struct file *file, void *priv, { struct isc_device *isc = video_drvdata(file); - if (vb2_is_streaming(&isc->vb2_vidq)) + if (vb2_is_busy(&isc->vb2_vidq)) return -EBUSY; return isc_set_fmt(isc, f); -- 2.25.1