Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <202205031017.4TwMan3l-lkp@intel.com> <YnCXTPrbLhvfRVDm@e3a974050dc4>
 <CAK8P3a1xMeLa72YKMufdej6KguDwiSXtZmMqRxOt5B05x_fx3A@mail.gmail.com> <YnDaINQbVtoJz1T3@atomide.com>
In-Reply-To: <YnDaINQbVtoJz1T3@atomide.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Tue, 3 May 2022 09:53:10 +0200
Message-ID: <CAK8P3a2NOfu52tADw30e6Bfik56_+PbUv6_+ADs=PUE-6NSrbQ@mail.gmail.com>
Subject: Re: [PATCH] ARM: dove: fix returnvar.cocci warnings
To:     Tony Lindgren <tony@atomide.com>
Cc:     Arnd Bergmann <arnd@arndb.de>, kernel test robot <lkp@intel.com>,
        kbuild-all@lists.01.org,
        Linux Memory Management List <linux-mm@kvack.org>,
        Russell King <linux@armlinux.org.uk>,
        linux-omap <linux-omap@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, May 3, 2022 at 9:30 AM Tony Lindgren <tony@atomide.com> wrote:
> * Arnd Bergmann <arnd@arndb.de> [220503 07:18]:
> > On Tue, May 3, 2022 at 4:45 AM kernel test robot <lkp@intel.com> wrote:
> > >
> > > From: kernel test robot <lkp@intel.com>
> > >
> > > arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161
> > >
> > >
> > >  Remove unneeded variable used to store return value.
> > >
> > > Generated by: scripts/coccinelle/misc/returnvar.cocci
> > >
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Signed-off-by: kernel test robot <lkp@intel.com>
> >
> > I checked the patch, and unfortunately it is wrong, the current code
> > needs to stay.
> > The problem is the SET_DMA_ERRATA() macro that accesses the
> > local 'errata' variable.
>
> Yeah this one keeps popping up. Maybe we can make SET_DMA_ERRATA
> into a function or have it at least change it to set the errata
> value.

I would just remove the macro and open-code the assignment, which
I think makes it more readable to both people and tools.

     Arnd