Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <tencent_8C37B90E1C06149CE1844A8CFF232048CC08@qq.com>
From:   <xkernel.wang@foxmail.com>
To:     <joe@perches.com>
Cc:     <Larry.Finger@lwfinger.net>, <phil@philpotter.co.uk>,
        <gregkh@linuxfoundation.org>, <linux-staging@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>
References: <tencent_A80380E4306BE7BA73E450F084232B4DFC0A@qq.com>        <tencent_702C3C4AA9F65F0EE48859211795E3800205@qq.com> <f6421e8f75a030222bf9cc7ef191648f7495a511.camel@perches.com>
In-Reply-To: <f6421e8f75a030222bf9cc7ef191648f7495a511.camel@perches.com>
Subject: Re: [PATCH 12/12] staging: r8188eu: check the return of kzalloc()
Date:   Tue, 3 May 2022 16:22:21 +0800
MIME-Version: 1.0
Content-Type: text/plain;
        charset="utf-8"
Content-Transfer-Encoding: 7bit
Thread-Index: AQIV0YZsN+y1sjhn79f1inyeXg2RTwLRgsQJAVYDQBuscJ1dsA==
Content-Language: zh-cn
Precedence: bulk

On Tuesday, May 3, 2022 3:09 PM +0800, joe@perches.com wrote:
> It'd be better to use the typical error returns

Hi Joe,

Thank you for your suggestion. The typical error returns will make these
codes unified with the code in other places.
But now we can not directly do that in this patch, otherwise, the original
functionality will be affected:

Apart from the returns of the error paths in _rtw_init_xmit_priv itself,
the functions on its call chain such as rtw_init_drv_sw() in
staging/r8188eu/os_dep/os_intfs.c are also sensitive to _SUCCESS or _FAIL.
If we want to unify all of them, there are a lot of changes need to do
which I think is at least beyond the purpose of this patch.

So I just keeps the form of error returns consistent with the original
logic.

Regards,
Xiaoke Wang