Received: by 2002:a19:651b:0:0:0:0:0 with SMTP id z27csp5666lfb; Tue, 3 May 2022 10:15:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5uuii7igm6hJFRow8i8iSlERG7470BepVxBRd/HyaUDLE9MK4AbaJkXyhi49uK47rDbsz X-Received: by 2002:a50:ed13:0:b0:426:4939:45a9 with SMTP id j19-20020a50ed13000000b00426493945a9mr19402930eds.303.1651598132809; Tue, 03 May 2022 10:15:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651598132; cv=none; d=google.com; s=arc-20160816; b=Nwaywh+n8NnYUzYcZvGXQmorBwUeq+R1CtlnKvpb7bdCKsT+u1XYCnKdzX6715czW/ 1sed8agyLNyxl+XYPg6CDh7PuKxkuLgLcFRBghUGUfINg6O5Sjvymn4JpdnyhF0DwBFs qUjd1rBnoU3XOMMh748vomphtASc2j2P3W7dzTz8v0etFHzEiSdy5ZahFLAlePRGk/ZP LxdSgf/G9SuoIHw5lbD3/9gUqQnsPS7i8yfZeTtqhE0EzCPQgMN0Ov8dgeENAntjEHAy Pve1wBCmL9CD7EUdEWjMFOGbgUle9DJJRcyaEm2Op+WO+HNU5Il0wJb22mO7WEcxyidv i00g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:message-id:in-reply-to :subject:cc:to:from:date:dkim-signature; bh=xowo0GqSwx4cbULKBnSGL0kxClw4vOOCqsGWHLcG5VM=; b=pELbYIdTZilMhglo3fOO5icTdJKQ0SgGSxGdvOCHpkTGK406MXPeo6mb/QYshs198d EQ7DGGDiCA/T3haWcrQulnH2WCQC+5NbE3Qey57KeTPKIWJkFRe2/Yoo9j2ngAfB7ucw Gt76+NHEdu1vd9Wjlxgqb1XMZDZhTZ5lapBNcC1MiTsEM3WHxi4q+Wx5Fg26T2b0PG5S +Y49Tgx/I2pYiWZWuCSCbSI3f3IP/0AyfrGl6+J+MXkFjY8LvcQQomj+4UvIkFbhnV86 +YzXklw12iEFsyYyCiwdRPS4j/wvvMDF10Vb68Rrp0HW3fl/Dc1kZ/Qo74Ir4Aov5EW2 SmqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=RI3YRcIA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c17-20020a05640227d100b00427da5fd281si3201479ede.580.2022.05.03.10.14.30; Tue, 03 May 2022 10:15:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=RI3YRcIA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235236AbiECM2G (ORCPT + 99 others); Tue, 3 May 2022 08:28:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235230AbiECM2E (ORCPT ); Tue, 3 May 2022 08:28:04 -0400 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C83A344EC; Tue, 3 May 2022 05:24:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651580672; x=1683116672; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=ezDP8VhxvFVapCaHLcnpQwxSE8jZ53x6V8Z6T9fWMdc=; b=RI3YRcIAE6o8G9PIPKa+pIAiZr3ZSl4L/IGdqL/ANr+RSgBL+h0wJZUD ZM4HkPOSSSrdqen3cjCFvI8W/c8Sv+QVTJdCm4PAj7OT7UATzmSl9BV4P P88PVdJqwW0W+RPcqIg//Rf3Ybb22picmjLR8RQdLFoWXypukeau34FuA GyfHqcfYeRenL0reR4/2VhfRG9A8+OhGeK9d+u7NZ/LcqBjmnAMgTg/kZ 9Jds+oMgajnvAnr2r2RafTORUU5ADMJtj7PoV0tFDQ0AbzV8tBny692ja nEXeJvIDmnrduo/ODoJNQ8l/9IYQp7awzzrMqkyNFcdSRl7Uwovy+uzYd Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10335"; a="328004739" X-IronPort-AV: E=Sophos;i="5.91,195,1647327600"; d="scan'208";a="328004739" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2022 05:24:32 -0700 X-IronPort-AV: E=Sophos;i="5.91,195,1647327600"; d="scan'208";a="584176810" Received: from oelagadx-mobl2.ger.corp.intel.com ([10.252.60.48]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2022 05:24:29 -0700 Date: Tue, 3 May 2022 15:24:23 +0300 (EEST) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Geert Uytterhoeven cc: Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko , Peter Hurley , Heikki Krogerus , Robert Jarzmik , linux-serial , LKML Subject: Re: [PATCH 1/2] serial: 8250: core: Remove unneeded In-Reply-To: <2545eaa7fc552013a5d04c4df027255204e64834.1651494971.git.geert+renesas@glider.be> Message-ID: References: <2545eaa7fc552013a5d04c4df027255204e64834.1651494971.git.geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 May 2022, Geert Uytterhoeven wrote: > The last calls into Runtime PM were moved to 8250_port.c a long time > ago. > > Fixes: b6830f6df8914faa ("serial: 8250: Split base port operations from universal driver") Does this really "fix" something or is it just a useful cleanup? To me it looks the latter. -- i. > Signed-off-by: Geert Uytterhoeven > --- > drivers/tty/serial/8250/8250_core.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c > index 01d30f6ed8fb5931..cfbd2de0ca6e4bcd 100644 > --- a/drivers/tty/serial/8250/8250_core.c > +++ b/drivers/tty/serial/8250/8250_core.c > @@ -32,7 +32,6 @@ > #include > #include > #include > -#include > #include > #ifdef CONFIG_SPARC > #include >