Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 3 May 2022 14:36:56 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Charlie Sands <sandsch@northvilleschools.net>
Cc:     gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
        phil@philpotter.co.uk, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, paskripkin@gmail.com,
        straube.linux@gmail.com, fmdefrancesco@gmail.com
Subject: Re: [PATCH V4] staging: r8188eu: Remove broken rtw_p2p_get function.
Message-ID: <20220503113656.GA4009@kadam>
References: <Ymy7C/A2q+VzfBhO@sckzor-linux.localdomain>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Ymy7C/A2q+VzfBhO@sckzor-linux.localdomain>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TLfyCgOkjC1QxMijY1/WJA9PnD0caEhsk2a9ZRp7MAg1pcyTDJFcsFMpiwWl?=
 =?us-ascii?Q?nhPIMOh/Po+DKyW0IAlpWvvaSOMAS28jXsJZa7D3wDWlQggXokDAKi22U4aY?=
 =?us-ascii?Q?d4cHqW3tw+UkRptrEO/V2yWEHWXxYYci0ZMg2nvI4Zuj+jUN3Sil2yLB2avw?=
 =?us-ascii?Q?aNVradQzw8zdF9hFkTTc0Pd7PlVrSigjkAZFpLL2M8qy4ytlXiOd74JUxLOg?=
 =?us-ascii?Q?Zx0tMjBwqSpYklw5mXLcHCWy3YhMCA/rvhTuHjOfLSqLEu5ZnDXJYWanfmeh?=
 =?us-ascii?Q?FzNaoNVkLvfMVxYdPN14GxSWvCt4FAfsXmi7iVmcEoUnOqV+0MJvb/mmaLB/?=
 =?us-ascii?Q?bKB5dt2HjZwU+5Nmyi9uvAA6nKQ06Al31sGKB6LHtzpI68r1ykonhR0To2TX?=
 =?us-ascii?Q?LpYj4rWtmClDwxJ7Gq8/b81jUJHiBVIp5zkMkDJ8ucbmCn01JHA92OSRRTms?=
 =?us-ascii?Q?2AI1uO9zrv1V9Ma4tIOEbgajKIef391mhEcFHn0mDhB2pIcEcmpmpGb4Ni1g?=
 =?us-ascii?Q?eYc9JlVD2cS8WBQGPUjaGYrcUtYFelzZjvDJr6llcjh4C5hTIE55VrrIUoju?=
 =?us-ascii?Q?36t7M8sIT1yk9T3MfN66iar3y2z7Ltz+DI81/8EYB4vTrO0uYsgtZKDigC/m?=
 =?us-ascii?Q?xAvyk5MW1wNr1D5WJqm+zSBFLjgXkkq9FOP1rs6WXUziUGdPjIvP0vEjSJLK?=
 =?us-ascii?Q?Ecdl0M0LPclQmImUkR2e8HGD/QVVB9JbTDL2B10o1i/2sFDxh56tSpGlBZRD?=
 =?us-ascii?Q?vNVxJJpYf4nF4m52evVLBnuC/2UeRl+QaVCETEnhLPyqAywtFgu6PrAsnnHJ?=
 =?us-ascii?Q?H4srIfVotHygtFudMJtoWf4g3hiDZJoi7kEbrrQihxF3xjuh6w2N3SoCmvky?=
 =?us-ascii?Q?escQrEzSD/E0KHB0wEyWVvlnhtcX4mmP23iH1Ezr4y70njsUrghmFJ7sPbfD?=
 =?us-ascii?Q?0L6y5v2dc8HRdC9OZVyR+Gh5NJ+SivppMrATOrwy4KAVTQ+9TQCFcx44D+pB?=
 =?us-ascii?Q?tNY3HU3XL+92cVWhkGC3U1oHTiOFNeuP3h1KVm86oCvMCc98XUICG8illOU5?=
 =?us-ascii?Q?XD+Rco7wveSn9Y/p/TZF5cDZPMjaD5fcPs/Sce8BbH8GIEvuVBdEr0kGobrC?=
 =?us-ascii?Q?/qHY0AKiD5vm735hid+GkvWJo114m7ohSyJ0snqc6gJCG2j676/b03gj66ot?=
 =?us-ascii?Q?MUvn5zrK8HAFvNHEALRr2fDFHnSrx/Cq5jfq7CzzCt6DZS+UWCn6M/3+4elH?=
 =?us-ascii?Q?8bYutcuCzC0YDDLXkxd+uSGjrYnZdOioEpDBsF5mrmo1oGsn2qmkFSAVKOGt?=
 =?us-ascii?Q?oHL21QuL1ktEZ9W7kVaJkeGKUHZ6gYso7eYWGUSBC/ckr1P0lhYrugKZ9oGX?=
 =?us-ascii?Q?t9YiH3PHR7HgJOM/MxISSmZAC5U6mzDLR7eazFETXYv3OVl48H3c+2gj72Kl?=
 =?us-ascii?Q?+RpRd6tyAf/u4mlY5heE6yYM25VtNOUQ0tU9ubB9URt/eWt4hIgrjlyAKPeL?=
 =?us-ascii?Q?hR5IVxdcT8RIi+nTyFedNx0VxhGesOUjtKpg/yryEezDU6HfObGPRI1nYVxv?=
 =?us-ascii?Q?KcX5/ZKIHYHz3h1APwOsMGYGX8aQ10oNZZbdV5aStVD679dMeFiKidhePDvH?=
 =?us-ascii?Q?+cc6SLFg8dqLAwsBS1MTmoOiT1FMvFlZAiVjK/OGaWQzaeAwt8k1w+aIB7dC?=
 =?us-ascii?Q?k8+GhOyL/bg+2ktPw72KYW/RKz26Vvw5r6sFprhcCYAHNERpCvWMig2sFAXR?=
 =?us-ascii?Q?2PLsKSpsxILLbWIgW2s3yaQgHaJca7o=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 125d00ad-361d-4d86-6b8b-08da2cf94125
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 11:37:08.1702
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7kSmQ5ez33CG8JjOg7jQQj0O0/3OI8z3jDABd0hOYkzMVKEzf+Nm63FutxViXMJtRxvM9tkHb1MflRQE/hMmFffiC/U17tAJJufUsdOToT0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5184
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-05-03_03:2022-05-02,2022-05-03 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 malwarescore=0
 spamscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2205030086
X-Proofpoint-GUID: inmLsHLhOf8do4Oo00ID4CQ6bXR0iKJs
X-Proofpoint-ORIG-GUID: inmLsHLhOf8do4Oo00ID4CQ6bXR0iKJs
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Apr 30, 2022 at 12:28:59AM -0400, Charlie Sands wrote:
> Removes broken and unsafe rtw_p2p_get function and all of the code
> associated with it from the r8188eu driver.
> 
> Signed-off-by: Charlie Sands <charlies256@protonmail.com>
> ---
> 
> Follow up to the patch called "staging: r8188eu: Fix unsafe memory access
> by memcmp." 
> 
> V2: Fixed checkpatch.pl warning and changed variable name as suggested
> by Greg K. H. and improved error checking on the "copy_from_user" function as
> suggested by Pavel Skripkin.
> 
> V3: Return -EFAULT from the function when there is a memory error while
> moving it from user space to kernel space and fix incorrect subject from V2
> 
> V4: Updated commit message and changes to reflect those sugested by Dan 
> Carpenter.
> 

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter