Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7091bd70-d7d1-8e88-d0d9-22ec944ff9df@theobroma-systems.com>
Date:   Tue, 3 May 2022 17:23:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 1/3] drm/panel: ltk050h3146w: add
 mipi_dsi_device.mode_flags to of_match_data
Content-Language: en-US
Cc:     thierry.reding@gmail.com, sam@ravnborg.org, airlied@linux.ie,
        daniel@ffwll.ch, robh+dt@kernel.org,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Quentin Schulz <foss+kernel@0leil.net>
References: <20220131164723.714836-1-quentin.schulz@theobroma-systems.com>
From:   Quentin Schulz <quentin.schulz@theobroma-systems.com>
In-Reply-To: <20220131164723.714836-1-quentin.schulz@theobroma-systems.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RnlBYVhTQndVSnplSDBEOWJwT3dtVGI4Mm9nQlhHWjNhbDRSNzFKT2JXMGpv?=
 =?utf-8?B?WkRtRmN0ekRMV0FYZGpjcUIrQTNIMVk5c2JGNXhtV3Znamk3OGJLelpOTUF1?=
 =?utf-8?B?cUQ2WkN6enMrYjBOU1d5TktlU2dNS1Ftamg3MmtkNXRjbmRDRk1sSEFGanh6?=
 =?utf-8?B?eHNiOFZFdWRTUHJoV0JXbzFtb3JyWTJKMVluRDZoc0ZqVldkNGZrNmhvclVm?=
 =?utf-8?B?TDNKYkRFTDJRSm1nSzJTdTRERjdvRzMyTTc3dXBCWWZybXQrL3FZcGw1KzNR?=
 =?utf-8?B?eDFqVnRubGc1U2J1amJlRzB2NWkrcTR5Wmgrdysxa25EQ0lBRlFIYmxXMHNE?=
 =?utf-8?B?cTlBWmtocTVpY0RyKzdwZkhjOFd3MVA0RFJlSlZJaDluamNLTlB4TWVwbUxk?=
 =?utf-8?B?OWhmb0hjU1ZsY3FkeW8vOHBHVU40cjhpSnc3QmgveXhROXlHcUJUWnVBYTlr?=
 =?utf-8?B?UHNVbHBaTXVrWUpJUFh0ZFlacjdLL3FaYXlHOW1IZCtkbnE4cllIM3d2WjVv?=
 =?utf-8?B?WXN2UG9XaHAwOE9SUHJSN1I1RDB6RWV2VmtPM1ZlaFlmaHdQQVVoaEY3aUp0?=
 =?utf-8?B?cjBvVlhKd1FmV3VRSDFkL0I4Z08ybnNJWUFOTUk1bkZIZWNIeXFSa0NncE1l?=
 =?utf-8?B?azJjOW9ZMkxPMTdETXc0MnJKV3lTYXRKVytrNEVsMG5VN2pFdE56eDNmZVVt?=
 =?utf-8?B?T3B6UksxOTYrYUR3MXhBTGpRL3NNYjJ6SEE1YjloOW1rdFpPRXZHMGhPb1JX?=
 =?utf-8?B?N29IUFNzWGhnTUpKYnMyT21FRVlIbGwvUzFqVTJFbUV5bDNwOVFkdjBPZFBr?=
 =?utf-8?B?U3BSdXRpM2JnSUVzVUUyQzV4VjhRQXM0SmZqSThvOWhFWWkvK2NXVUdxK1JJ?=
 =?utf-8?B?amRRU1BmcFVqMDRsZTlJUERjZXgzMkNteGpvMytjcHlhYUU2Z0ZITThqN1J0?=
 =?utf-8?B?Zkpma0ZlTGl5QjZqanJxR01ReHJvVk51WDhqZUIva3M3eVl0VDBSSTRVSE05?=
 =?utf-8?B?Q1BRZndkcnR6OVhST0lUT2xyZ01ON2ZOZG1GRVo3eU9OKzY3bHBwM2w4QVFS?=
 =?utf-8?B?VWlqVHlBU09nb01vT3JyTFUzcG90L1k0Tk92dW1DRnpQTFRhSzFQcGJwWW9z?=
 =?utf-8?B?ZjB6SkM2UFVjU1hSNnFVa0I1SDU3d1A3ZGVKNXhsUEJqdTVlbGI0OHFmTVZX?=
 =?utf-8?B?YzZSTUl4M2tBVWo2bnBHQUpSSmZxZ01pTm1UQ1RmeFhiaC9MSW01UXVSUzFk?=
 =?utf-8?B?Wkl6Q3J3dnluMzh5Y0FGaFlKa3NhTjBkMUY4bHA1bUFzYW90VzRMaTV3a0VC?=
 =?utf-8?B?M0QwVElNTDRFM1p1YW9KUjc3NWhYM3ZIWXE0MGRtVHFZU0NNTDVKMWsrbmVB?=
 =?utf-8?B?Z1U3bnpjZldGTkM2RnRBZndmcVppMUpKNmhpa21UelIvS3NKb0o2VzdDM3RZ?=
 =?utf-8?B?RkdyWFp1Z1ZNRE9yYmNJNUlzeEhWUjU5K3c1OHlZT3ozOGgwQUJZSFRzNGFn?=
 =?utf-8?B?TEUwdVgzd1pjV1E1MDRtWS9RQy9XcVhhRVF5Z2loVG1YbmhwcndXNXI4QS9S?=
 =?utf-8?B?U2RmQ0tBMFlPNm9LREtBczMrL1A4QmwycEw2M0dxZ0dkSmZlTUh4Yi9objhP?=
 =?utf-8?B?SUlKMG9Ebk9NRVpRMXpTcDZHd2FvQnlabDRzRG8wcDVwSFk4eU1pVkV1OUxs?=
 =?utf-8?B?QUlxTWxjS1NEZ3ZZRGhnQlcwbUplZHMra0RsNDg1TEdMTTlOeks3TzZnaFdV?=
 =?utf-8?B?dWNjVWpNb3pFdFNPcDg1L0EvVWZJUzlFSi9TV3dyMnVGbUxoUkI4aVZqOTA5?=
 =?utf-8?B?YW9MbW5ETWROWWJWQnBtZFozZWZhZDBqM2REN1RieXNqcmhmd2UyaU9Pbmho?=
 =?utf-8?B?MzNKbnc1TEVqVFo3VXJTbVdXTjBJdnRyMytUZW9tS1ZnMHREQnJ6c3gvUnpX?=
 =?utf-8?B?WXFhTThMeisvdDQzVTA3aVZ1THNSSTBpYUhPZUE1aEppWHo3TmY5bG1FSmdi?=
 =?utf-8?B?ZGx0ZEwvOGVoRW1GbkFKV0NmOTBGWGVNTUJyWEMwRmJFWFVDaE1Cdk9VWXAv?=
 =?utf-8?B?R1hHT1g4eFlhOWJDdkpyMXdhNmIrdnZuOE05YjRWeXVBYjBxRksyVHExaHBM?=
 =?utf-8?B?WXJmTjRQaUxjTm5DZW0rYnBDbmRnOVZDWnNQd3pDUHYyUDZLMHdLL0FoaG9C?=
 =?utf-8?B?WGhwRnk1V1NUbnJaQ0FXQStLaFpnTzNtVzZreUxOSVFrY0xZZzAzczd5ZUR0?=
 =?utf-8?B?dU43ZUZrUy9yMmFMaVNrWUQrdGQ1ZDhvNTdKZnd6YlZRTThUbXJXaFRJTGNS?=
 =?utf-8?B?dGhTT2xzNWRzcEN3WE50aWE2Q1BTT084RGx4a1ZlU01pU08xMDNQblBNS1Jw?=
 =?utf-8?Q?hLjVtjj7P0/Z5AgghJO3odN+D1B3PS0FjkdNV?=
X-OriginatorOrg: theobroma-systems.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 755a7280-1f5f-4287-3aaf-08da2d18dcce
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB9367.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 15:23:23.5501
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5e0e1b52-21b5-4e7b-83bb-514ec460677e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q+db7K6Uu8qGyaIVvGB1rTPjvRl5r+iJT1Fb7yjmtdzTfcWXc1kizdVHzCB0G7aZcnlWYQdrE5tA7j7iF9iatVQTLy3GmVdv2Ij38cmhlsLqPszHc0oZKrVtsExPScF6
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4006
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,MISSING_HEADERS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
To:     unlisted-recipients:; (no To-header on input)
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi all,

Seems I'm not the only one who forgot about this patch series, so, 
kindly pinging :)

Thanks!
Quentin

On 1/31/22 17:47, quentin.schulz@theobroma-systems.com wrote:
> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> 
> To prepare for a new display to be supported by this driver which has a
> slightly different set of DSI mode related flags, let's move the
> currently hardcoded mode flags to the .data field of of_device_id
> structure.
> 
> Cc: Quentin Schulz <foss+kernel@0leil.net>
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> ---
>   drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c
> index a5a414920430..67eb474e28c6 100644
> --- a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c
> +++ b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c
> @@ -25,6 +25,7 @@ struct ltk050h3146w_cmd {
>   
>   struct ltk050h3146w;
>   struct ltk050h3146w_desc {
> +	const unsigned long mode_flags;
>   	const struct drm_display_mode *mode;
>   	int (*init)(struct ltk050h3146w *ctx);
>   };
> @@ -339,6 +340,8 @@ static const struct drm_display_mode ltk050h3146w_mode = {
>   static const struct ltk050h3146w_desc ltk050h3146w_data = {
>   	.mode = &ltk050h3146w_mode,
>   	.init = ltk050h3146w_init_sequence,
> +	.mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
> +		MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET,
>   };
>   
>   static int ltk050h3146w_a2_select_page(struct ltk050h3146w *ctx, int page)
> @@ -433,6 +436,8 @@ static const struct drm_display_mode ltk050h3146w_a2_mode = {
>   static const struct ltk050h3146w_desc ltk050h3146w_a2_data = {
>   	.mode = &ltk050h3146w_a2_mode,
>   	.init = ltk050h3146w_a2_init_sequence,
> +	.mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
> +		MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET,
>   };
>   
>   static int ltk050h3146w_unprepare(struct drm_panel *panel)
> @@ -592,8 +597,7 @@ static int ltk050h3146w_probe(struct mipi_dsi_device *dsi)
>   
>   	dsi->lanes = 4;
>   	dsi->format = MIPI_DSI_FMT_RGB888;
> -	dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
> -			  MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET;
> +	dsi->mode_flags = ctx->panel_desc->mode_flags;
>   
>   	drm_panel_init(&ctx->panel, &dsi->dev, &ltk050h3146w_funcs,
>   		       DRM_MODE_CONNECTOR_DSI);