Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220502172908.3569799-1-robdclark@gmail.com> <86160889d7be260c5012044643b81d10098943fe.camel@pengutronix.de>
In-Reply-To: <86160889d7be260c5012044643b81d10098943fe.camel@pengutronix.de>
From:   Rob Clark <robdclark@gmail.com>
Date:   Tue, 3 May 2022 07:13:55 -0700
Message-ID: <CAF6AEGve4OYRYvSim6_7ihYZb-HuwQkBqm8D_=1MRxDHhhQFag@mail.gmail.com>
Subject: Re: [PATCH] drm/msm: Limit command submission when no IOMMU
To:     Lucas Stach <l.stach@pengutronix.de>
Cc:     dri-devel <dri-devel@lists.freedesktop.org>,
        Rob Clark <robdclark@chromium.org>,
        David Airlie <airlied@linux.ie>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        Abhinav Kumar <quic_abhinavk@quicinc.com>,
        open list <linux-kernel@vger.kernel.org>,
        Luca Weiss <luca@z3ntu.xyz>, Sean Paul <sean@poorly.run>,
        freedreno <freedreno@lists.freedesktop.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, May 3, 2022 at 5:12 AM Lucas Stach <l.stach@pengutronix.de> wrote:
>
> Am Montag, dem 02.05.2022 um 10:29 -0700 schrieb Rob Clark:
> > From: Rob Clark <robdclark@chromium.org>
> >
> > Running the GPU without an IOMMU is not really a supported (or sane)
> > configuration.  Yet it can be useful during SoC bringup (ie. if the
> > iommu driver doesn't work yet).
> >
> > Lets limit it to users who already have /dev/mem access, to avoid the
> > chance that a user accidentially configures kernel without IOMMU
> > support.
>
> I haven't followed MSM too closely, so ctx->aspace may also include the
> GPU MMU, but if this really only includes the IOMMU (as the commit
> message implies) then this breaks Freedreno on i.MX5.

it includes the gpu mmu, so a2xx should be fine.

BR,
-R

> Regards,
> Lucas
>
> >
> > Signed-off-by: Rob Clark <robdclark@chromium.org>
> > ---
> >  drivers/gpu/drm/msm/msm_gem_submit.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c
> > index 23b68bc945f6..9cd8c8708990 100644
> > --- a/drivers/gpu/drm/msm/msm_gem_submit.c
> > +++ b/drivers/gpu/drm/msm/msm_gem_submit.c
> > @@ -734,6 +734,11 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data,
> >       if (args->pad)
> >               return -EINVAL;
> >
> > +     if (unlikely(!ctx->aspace) && !capable(CAP_SYS_RAWIO)) {
> > +             DRM_ERROR_RATELIMITED("IOMMU support or CAP_SYS_RAWIO required!\n");
> > +             return -EPERM;
> > +     }
> > +
> >       /* for now, we just have 3d pipe.. eventually this would need to
> >        * be more clever to dispatch to appropriate gpu module:
> >        */
>
>