Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp190566iob; Tue, 3 May 2022 14:48:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzyZpkUyF/sZKYMECwRDcadPSKTbOp9jxozOmxZq0jjdIvw3HWqebRvfKFA78v+2Agdeev+ X-Received: by 2002:a17:907:7fa2:b0:6f4:408a:5216 with SMTP id qk34-20020a1709077fa200b006f4408a5216mr12291253ejc.564.1651614499031; Tue, 03 May 2022 14:48:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651614499; cv=none; d=google.com; s=arc-20160816; b=bVNGpwqS8uy4Xi6xZqQdLzc5FgSczVrkWwHKjtNyhBa7su3lzjg5KQb9hiMALQqUgM uq8dV26Z8tqJtvCsINUw36GO4UhuwAZQ/lqOSo6lxUg3gZT0ezQ0tO0zoZhHv5WAGLlt J9h97a/kbbCPcqNwYr11efU6jfQfp1FlSi0Jo8VywfXuAeWKT8WLTo7hIKJOgdKf60nD 8jecpVTzMVY+TiiQzwkcT08gv9i9h21ZQYCv+YcC0JqZK5LKBFi/tcKWkLEnCNNCwClj cj5HomSikqU3bal8gaIl0ZaZiCWqMp1p164UVIKq1xRhCxEh/vJEC1pFI2S+gc9+KlXh 3xkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=B6iYV5uPdXrRA/+rFiUJ0dX1+T8qkpqbtKApdzTC9jU=; b=KulwZpPxnYMaIqPQ+9vSO0T9amcdPR99k62t/r+ybZdWmIlEE6e+C50SD1KrV0zkDY 6YVKAjXzW3Fy+uYN3mVtnNNa+3enYZ9aQr+ELMSUM4STLHnfpweFwLHDjDC/nebXvgkM 3+3BRkdSFS+87piO2jgoWpltuPej7wSpblz0TU4TPOd/o4DEhjZN3XB1al8EV0rnDqU0 GPCrn7CmMUqgV3VaDwepYViWaZ4SsXHt6DICYqwLv0XZtdsUP+zPoJfm8nP9uWxuNKso qOrmp/YseQmE5SUQYDZdVI42HQNmUwHKFIXIfggKzRy5D4Ci7cnV2QcVOWhggDheCTHq ssew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=fN4aZ5Pk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z1-20020a05640240c100b00427cfac378fsi5159415edb.7.2022.05.03.14.47.55; Tue, 03 May 2022 14:48:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=fN4aZ5Pk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241640AbiECSwV (ORCPT + 99 others); Tue, 3 May 2022 14:52:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233688AbiECSwS (ORCPT ); Tue, 3 May 2022 14:52:18 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE53124F39 for ; Tue, 3 May 2022 11:48:44 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id l18so35094014ejc.7 for ; Tue, 03 May 2022 11:48:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=B6iYV5uPdXrRA/+rFiUJ0dX1+T8qkpqbtKApdzTC9jU=; b=fN4aZ5Pkz4/NffcBeusp6ZmX6xWXXm6KVaRLrLOhrVik3VekQpp5XYbUkUXDZmfcOb LpA1MJ5Nr0R9JmutYt0RNhaFmNIisNhoW22tepfDY8yYh2so5MF4Z6gt7hKsMCu9dTco Pmf2nJuaek4ZgeVVDgTitiwbL+s5efgc2qVZdxGifFlANxcwUZ06BgMX7pRPyJFqvnxi i9RYMHR4QIZOSegomOzd2xPQ4vpEsWRjqLyoLYF6rfI58pGIFSZzXTnwRXbCvuMjgrAV ISgU55gNYOKkyHV2XFMITxM3FQ5AHDGaToRNYItvQzy+1XQJSFQLdcxQJD/O/IvYZ/3O +5bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=B6iYV5uPdXrRA/+rFiUJ0dX1+T8qkpqbtKApdzTC9jU=; b=ToonJUNdobnW9ZM3mMPm2IhGb1eZWS39igAc4XQt4A//tRoIhz/uDbJworW3zNPQlD sUANZft5esKvyYRD8ADhUAZM8hkjzW8jRT4cqFEdjLobrJfjLBG0ryBWuaaC4Ykge5Vh UGHUI1O1ZVGXlGrfhVSYexmsZllmNAVLsq/5lwFPUHaRgodlxtzs/Ag0BKHuQ2KTj6Qt nHV0hx4DkIDc4GKKeJQrqmhZ5Z90V0RgBsNBWUPQsq/zVxOU3Zt9rq5GpAeTptBZNybo lLyyNPS+Px5ZBnC7JA2+hRCW0d8mMMTWcayk+rMbyHXa9S6a4k+gQmKzim5D4mGZNxQq TAEA== X-Gm-Message-State: AOAM530WDEPvi0LzbNb3VTlA18GqFrelQELCLFaTbRjlMkeX6Rafgc2r JTXw5ZuCLMduXocNd+HiADKJ+Skljuls4OTc2kSHbQ== X-Received: by 2002:a17:907:72ce:b0:6f4:5a57:320c with SMTP id du14-20020a17090772ce00b006f45a57320cmr9404297ejc.75.1651603723165; Tue, 03 May 2022 11:48:43 -0700 (PDT) MIME-Version: 1.0 References: <20220430045639.839186-1-davidgow@google.com> In-Reply-To: From: Daniel Latypov Date: Tue, 3 May 2022 13:48:31 -0500 Message-ID: Subject: Re: [PATCH] kunit: tool: Add list of all valid test configs on UML To: David Gow Cc: Brendan Higgins , Shuah Khan , kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 3, 2022 at 1:37 AM David Gow wrote: > > On Tue, May 3, 2022 at 6:37 AM Daniel Latypov wrote: > > > > On Fri, Apr 29, 2022 at 11:56 PM David Gow wrote: > > > > > > It's often desirable (particularly in test automation) to run as many > > > tests as possible. This config enables all the tests which work as > > > builtins under UML at present, increasing the total tests run from 156 > > > to 342 (not counting 36 'skipped' tests). > > > > Just to clear up potential confusion for others, I'll note that these > > aren't counting test cases. > > This is from kunit.py's output, so it counts each parameter from > > parameterized tests as "subtests." > > > > Copying my command from > > https://kunit-review.googlesource.com/c/linux/+/5249, one can use this > > to count the # of test cases. > > $ ./tools/testing/kunit/kunit.py run --kunitconfig=... > > --raw_output=kunit --kernel_args=kunit.action=list | egrep > > '^[a-z0-9_-]+\.[a-z0-9_-]+' > > > > I see this enabling a total of 260 test _cases_ (including skipped). > > > > The default (basically just CONFIG_KUNIT_ALL_TESTS=y) gives 192 > > (including skipped). > > > > Yup, that's definitely the case. I guess I still was thinking in KTAP > terms, where all subtests are effectively tests. > > That being said, I do think the total (sub)test (including parameters, > etc) number is the one that's more visible: not only does kunit_tool > print it, but it's also what we've been using as our go to "number of > tests" generally. Yes, I agree it's the number to use here. If there's a v2 of this patch, we could also reword the commit message a bit to make it more explicit. If not, this seems fine as-is. The only issue I saw was a minor typo. Re goto for "number of tests." Reminder, we've also been using this to count "# tests" :P $ git grep 'KUNIT_CASE' | grep -Ev '^Documentation/|get_metrics.sh|include/kunit/test.h' | wc -l This avoids us having to figure out how to build all the tests, sidesteps the problem that subtests can be dynamically generated via parameterized testing, etc. > > > > > > > They can be run with: > > > ./tools/testing/kunit/kunit.py run > > > --kunitconfig=./tools/testing/kunit/configs/all_tests_uml.config > > > > > > This acts as an in-between point between the KUNIT_ALL_TESTS config > > > (which enables only tests whose dependencies are already enabled), and > > > the kunit_tool --alltests option, which tries to use allyesconfig, > > > taking a very long time to build and breaking very often. > > > > > > Signed-off-by: David Gow > > > > Tested-by: Daniel Latypov > > > > Looks good to me, some small comments below. > > > > > --- > > > .../kunit/configs/all_tests_uml.config | 37 +++++++++++++++++++ > > > 1 file changed, 37 insertions(+) > > > create mode 100644 tools/testing/kunit/configs/all_tests_uml.config > > > > > > diff --git a/tools/testing/kunit/configs/all_tests_uml.config b/tools/testing/kunit/configs/all_tests_uml.config > > > new file mode 100644 > > > index 000000000000..bdee36bef4a3 > > > --- /dev/null > > > +++ b/tools/testing/kunit/configs/all_tests_uml.config > > > @@ -0,0 +1,37 @@ > > > +# This config enables as many tests as possible under UML. > > > +# It is intended for use in continuous integration systems and similar for > > > +# automated testing of as much as possible. > > > +# The config is manually maintained, though it uses KUNIT_ALL_TESTS=y to enable > > > +# any tests whose dependencies are already satisfied. Please feel free to add > > > +# more options if they any new tests. > > > > missing: "enable"? > > "if they enable any new tests" > > > Whoops, I was switching from "there are any" to "if they enable any" > and clearly got distracted halfway through. :-) > > > Hmm, should we state a preference for how heavy (time or > > resource-wise) tests should be? > > Because the comment says it's meant for automation, but I can imagine > > humans wanting to run it. > > (I'm completely fine with us not stating one, just throwing the idea > > out there for discussion) > > I think we're probably okay with being a little bit lenient on test > times. The time_test_cases.time64_to_tm_test_date_range and similar > tests take quite a long time in some situations already (older hw, > running under some emulators), but is generally pretty close to > instant under most UML setups. Particularly given that not building > with allyesconfig already saves us many, many minutes of time. Agreed on all points. I personally think it's reasonable to leave things as-is. We don't have any problematic tests that work on UML yet.