Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220502134850.28372-1-cgzones@googlemail.com>
In-Reply-To: <20220502134850.28372-1-cgzones@googlemail.com>
From:   Paul Moore <paul@paul-moore.com>
Date:   Tue, 3 May 2022 14:01:37 -0400
Message-ID: <CAHC9VhRkDsCR2gyVamYktvx_8LoPKox__YOv+-F4cYZjitCbdw@mail.gmail.com>
Subject: Re: [PATCH] selinux: resolve checkpatch errors
To:     =?UTF-8?Q?Christian_G=C3=B6ttsche?= <cgzones@googlemail.com>
Cc:     selinux@vger.kernel.org,
        Stephen Smalley <stephen.smalley.work@gmail.com>,
        Eric Paris <eparis@parisplace.org>,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Xiu Jianfeng <xiujianfeng@huawei.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, May 2, 2022 at 9:49 AM Christian G=C3=B6ttsche
<cgzones@googlemail.com> wrote:
>
> Reported by checkpatch:
>
>     security/selinux/nlmsgtab.c
>     ---------------------------
>     ERROR: that open brace { should be on the previous line
>     #29: FILE: security/selinux/nlmsgtab.c:29:
>     +static const struct nlmsg_perm nlmsg_route_perms[] =3D
>     +{
>
>     ERROR: that open brace { should be on the previous line
>     #97: FILE: security/selinux/nlmsgtab.c:97:
>     +static const struct nlmsg_perm nlmsg_tcpdiag_perms[] =3D
>     +{
>
>     ERROR: that open brace { should be on the previous line
>     #105: FILE: security/selinux/nlmsgtab.c:105:
>     +static const struct nlmsg_perm nlmsg_xfrm_perms[] =3D
>     +{
>
>     ERROR: that open brace { should be on the previous line
>     #134: FILE: security/selinux/nlmsgtab.c:134:
>     +static const struct nlmsg_perm nlmsg_audit_perms[] =3D
>     +{
>
>     security/selinux/ss/policydb.c
>     ------------------------------
>     ERROR: that open brace { should be on the previous line
>     #318: FILE: security/selinux/ss/policydb.c:318:
>     +static int (*destroy_f[SYM_NUM]) (void *key, void *datum, void *data=
p) =3D
>     +{
>
>     ERROR: that open brace { should be on the previous line
>     #674: FILE: security/selinux/ss/policydb.c:674:
>     +static int (*index_f[SYM_NUM]) (void *key, void *datum, void *datap)=
 =3D
>     +{
>
>     ERROR: that open brace { should be on the previous line
>     #1643: FILE: security/selinux/ss/policydb.c:1643:
>     +static int (*read_f[SYM_NUM]) (struct policydb *p, struct symtab *s,=
 void *fp) =3D
>     +{
>
>     ERROR: that open brace { should be on the previous line
>     #3246: FILE: security/selinux/ss/policydb.c:3246:
>     +                               void *datap) =3D
>     +{
>
> Signed-off-by: Christian G=C3=B6ttsche <cgzones@googlemail.com>
> ---
>  security/selinux/include/initial_sid_to_string.h |  3 +--
>  security/selinux/nlmsgtab.c                      | 12 ++++--------
>  security/selinux/ss/policydb.c                   | 12 ++++--------
>  3 files changed, 9 insertions(+), 18 deletions(-)

I generally dislike checkpatch-only patches, but you've been fixing a
lot of other things so I'll go ahead and merge this into selinux/next.

--=20
paul-moore.com