Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 4 May 2022 09:44:36 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Cristian Marussi <cristian.marussi@arm.com>
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        sudeep.holla@arm.com, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] firmware: arm_scmi: Fix late checks on pointer
 dereference
Message-ID: <20220504064436.GJ4031@kadam>
References: <20220503121047.3590340-1-cristian.marussi@arm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220503121047.3590340-1-cristian.marussi@arm.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HdXUzNbBbSwAByXLAeYdyRAJKzfEZUuE6YY5QZkQfqBfzeyKEcgTkm+oRuuE?=
 =?us-ascii?Q?aHN/hhXaqPA8RFDIiM1iHwNkadNJCRavcb1ga0go0veHABgcde9GWrro8KdL?=
 =?us-ascii?Q?kMbfuT7Sl5kAzURYeGSnp6Yg9/MmHXnWt90ALWuHCWsUPLKYOuqEud/KukdE?=
 =?us-ascii?Q?dbPJhD5BkTyoivJPhKZarGMFAVhAjr6mlbLdHhBsEhR9SWhCyjZqgZoqCZNm?=
 =?us-ascii?Q?HMPs1oZ/LYNJSWzHuQVsvwzOtL5EGc7fLzE5n3LIDONqV7+UPJcHgSw5Lxaz?=
 =?us-ascii?Q?9qUTjjIfTW5uYNTmUTONOqrDgiWA7DNrDr3GRSd6gN8VcFVXEiLi/1iv9roS?=
 =?us-ascii?Q?OHSzEDFJiQmKkv1Sg4vPfP/LnF3WG21kHtnVfPUPQfsVpDURHf9DcNmZU4rc?=
 =?us-ascii?Q?wR1oZvNbOvWwXYh3ZZwtqv10GMXmbysKhYvV4gyVEFDi1vrwTn4fD0Twhfcx?=
 =?us-ascii?Q?WOOWJMD1wzA0GaIfODpbPl3l4v9oX39IC9sf7vKGWgBGnd4WRd6uS+bFCohC?=
 =?us-ascii?Q?2fjhxIPsXkMg3mCE+vueMyG01awe/GVBc6ThumMDyva7qL+nYV86/ohIbHc9?=
 =?us-ascii?Q?0M0uGpnB/y+Zs0t/DKYo2HBfYEcLlUvO75IXBjPUqpzylbtw2ZNcXwGOP6H0?=
 =?us-ascii?Q?XS3OMhAuy5S8g1eJIgYSt3b0ii/wyQC9BsL3geqLMd/ZHnZdBKisQ2y94hrM?=
 =?us-ascii?Q?TUOiaFKN5CwJANYEOmiRv055x0UsQmWrfZ6C5VKiyjRfulGHQg4Xg1srK7dA?=
 =?us-ascii?Q?6+H2tiMzVNQF126FnbHo5/ISoEKpAiApEk3V7rOLL8leoOV5LK9O5Tix1wez?=
 =?us-ascii?Q?CRtGB9GK4H1+3BmoSpcqXwO257Fkmrz9uCDmvVD518+7HXngRCNP+N0JeJKU?=
 =?us-ascii?Q?n8McMht9Rj165iH5DIFOt8fvCgP/e+4gifyCQLymfGWareNA518ldHf7bozq?=
 =?us-ascii?Q?WYSAdEiNV7jtpCPXCr2s+B6vA0mPKkkF9zvzxBNLX3exJhsiFRLhI/tKClEr?=
 =?us-ascii?Q?rZkHPUiVM/nWJ30glq9TwJFYA0wSRtO/r4pkfQZq6ZpRT9NbrLodlVk0ZD/V?=
 =?us-ascii?Q?Q57hxakT62Ekc/SXLlpDz2hpHivKsgy2p/PDnq8SXuWBHzzaDi3u/RT8yWiR?=
 =?us-ascii?Q?YFAkqSNK+F61Im8nuxRQWFW/GwzsWamcmCBbX0ypujLWAlSD4RpHZotqqrmL?=
 =?us-ascii?Q?ih9E5mBNUaLva175H47uOCsge5zIDgPxhni11y1SQhpcfe9Nd3NZ4hbPx1Vk?=
 =?us-ascii?Q?vDNmB/ljwaKMYNkOebIuwW4JYCC1lx7VWnnLVOQTCEz4MYHOm0MfY4q3+AlL?=
 =?us-ascii?Q?wRkrcjhJoR2rbheKs/8dsC9Yhe8Qqv2/w/YcbormvyL3IC8USzCbwtKJIE+F?=
 =?us-ascii?Q?dHvgtG3V4XqUXNEhMWYrrSSyMfzG65Pl0kpP/ZnFtaySmNJI7y2xpObEOe2y?=
 =?us-ascii?Q?iR0CLkqr30Wb/EHe8arORsU1LSflTkSDCmxhgwRHXrm4RkcbvYnzC/DYWHHO?=
 =?us-ascii?Q?esYYVNHUGZIDAy+J619SDPMGgZQnKl5b4dNQ0pz0o5E4GcwwpcovCVj1eu7k?=
 =?us-ascii?Q?PBDkxJHUzGB6Su0A1WpM05RDQgs8LVzP22rzTnMEhvQPnlR0lOdWeoJsegEQ?=
 =?us-ascii?Q?DON5IQ01iH6W41jGSfxslc5NiNoBQttPM9OSyhi8PPXPcIxLc2R02q7UBrzu?=
 =?us-ascii?Q?gnjdV7L/Mc5bxNHC3rI1S08a9eH02Rl2aqhE0sdMDTUigGlmfzWZtPDSrdtE?=
 =?us-ascii?Q?PjSBDM0r70MffgYi3nPHMlwZlyl1cII=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ae47f5da-c2f2-4aa6-9cb1-08da2d999958
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 06:44:55.4501
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Cz72N0TT6Q6JEMpxLD7s5F/E8JreEBckyLSwVCt14t2YfCEcyvt7li2V4tgbP4T1bFfTvBidNCEuOTugfF2xQKaitCY0QBSJMhHs/6fQ/yU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1265
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-05-04_02:2022-05-02,2022-05-04 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 adultscore=0
 bulkscore=0 suspectscore=0 mlxlogscore=774 malwarescore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2205040044
X-Proofpoint-GUID: 7TD0vztVmLQh38xSxdWYYyzqZMOdzWGM
X-Proofpoint-ORIG-GUID: 7TD0vztVmLQh38xSxdWYYyzqZMOdzWGM
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 03, 2022 at 01:10:47PM +0100, Cristian Marussi wrote:
> A few dereferences could happen before the iterator pointer argument was
> checked for NULL, causing the following smatch warnings:
> 
> drivers/firmware/arm_scmi/driver.c:1214 scmi_iterator_run() warn: variable
> dereferenced before check 'i' (see line 1210)
> 
> Fix by moving the checks early and dropping some unneeded local references.
> 
> No functional change.

If there is no chance these can be NULL then a different option is to
just delete the NULL checks.

regards,
dan carpenter