Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp518050iob; Wed, 4 May 2022 01:53:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwY2wZgzCgDmAQ/CS+Rl/E3wQmoA+HligXm8RnHqIAvTEG6OQlzCO4Tqp34p4hs+HpCXOyz X-Received: by 2002:a17:90b:124a:b0:1d9:de12:520f with SMTP id gx10-20020a17090b124a00b001d9de12520fmr9198044pjb.28.1651654383012; Wed, 04 May 2022 01:53:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651654383; cv=none; d=google.com; s=arc-20160816; b=B8QrsjFouQ+8flVacugzh8+7H+WZSHnZsjNMb9mOGFUyRBDOS8swDLhDgk5jkGNVhZ 2vRj0T2dEh2uEnBk41pXwdYEjSLFKoLzV/fkSk24UBcNCDnN07g4Wbi5pJOvnVknPsmJ cYyF2BF002tIOCFvZMKqhYZ6soCEplKh4mF2A7LQ8yP9l/Mg75DKyoWSr3h4ZLRo3c3u xw3iOZZ766kDC1qMmXcpaDXHNTIfhniF4eQRxthyNkNpaOh/YfuTjWftD99Rhid2BKRw fHe8fvnsl0pLbYDUOijNCNzNsHZ44crrpx//r42KT8PeDzQFrbJ+vW4OJjoEoAf+4y7t I5Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=6y73UrLkuBeZbqQWQxE1t7/fvOkdPG7FrQgvW5TbCZk=; b=jmNA53Z4fpyFqafL9FNMnbSQnZ3frdD0nlDBxrb8uakIK3yKGPRUFNEpvwXpOnzbxq s8cee6Spqcc1CQVmsffaoWpTeYZid5fUnUWAbGHliK6cGHJR0ktKS3izP64PnS9O2KMZ YPJl1op2EdcXqD71ztStNWUN4YalK9yuuwXaprxebYgifr20S+SSSnuHQ+U3fgueV94S jpaLbl4b2GZRCbNW3q+IPCoSKYHquB51gPVWP/qzBYgQtV5RI3vC3dAAeEjJ1U/v1pBX /F8xDLluiizrohjGifilwvmkyFJ8BB2oLf4Bzo+1YnbsbvQjiv0h3YlHWCfaiy7Pjp01 BpdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=uV47lbaY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i2-20020a170902eb4200b001584ee3ba07si17601602pli.439.2022.05.04.01.52.48; Wed, 04 May 2022 01:53:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=uV47lbaY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237470AbiECUJQ (ORCPT + 99 others); Tue, 3 May 2022 16:09:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237119AbiECUI5 (ORCPT ); Tue, 3 May 2022 16:08:57 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73CD72DFA; Tue, 3 May 2022 13:05:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6y73UrLkuBeZbqQWQxE1t7/fvOkdPG7FrQgvW5TbCZk=; b=uV47lbaYCI77SzKFgjANFlLdPi L02iSgJfX9+DktwQKv2+gW04aiFG88sPWwCOpfbWVfsKcu5mcv6/fSFU+nTtYhp4/nG6vb6sK6vO1 VuOYw0zbi0N5oB1BXqerDMF7l1psgHzPI174q4fF7eoDfL7w+JUkH5bAerAOHbru+Yd3kpigqC8Qv qaW65HJ2rsoeJpsMNjSwiawKJyE5v7ztmXTNDLnq1z+n3rPjhh/MtEwPoeXxzP0/w7t/fjkR8jMOD yUESiFI99BpsJg2J6h3EUzozTZNBVnIfNljmTXGlRhcUON7mxblWtRdlKKftawmCl9vCGYK6Z3Mag IuaQzkHg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlylv-007UQd-7t; Tue, 03 May 2022 20:05:23 +0000 Date: Tue, 3 May 2022 13:05:23 -0700 From: Luis Chamberlain To: Bagas Sanjaya Cc: linux-doc@vger.kernel.org, Stephen Rothwell , Russ Weight , Greg Kroah-Hartman , "Rafael J. Wysocki" , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: [PATCH] firmware_loader: describe 'module' parameter of firmware_upload_register() Message-ID: References: <20220502051456.30741-1-bagasdotme@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220502051456.30741-1-bagasdotme@gmail.com> Sender: Luis Chamberlain X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 02, 2022 at 12:14:56PM +0700, Bagas Sanjaya wrote: > Stephen Rothwell reported kernel-doc warning: > > drivers/base/firmware_loader/sysfs_upload.c:285: warning: Function parameter or member 'module' not described in 'firmware_upload_register' > > Fix the warning by describing the 'module' parameter. > > Fixes: 97730bbb242cde ("firmware_loader: Add firmware-upload support") > Link: https://lore.kernel.org/linux-next/20220502083658.266d55f8@canb.auug.org.au/ > Cc: Stephen Rothwell > Cc: Russ Weight > Cc: Luis Chamberlain > Cc: Greg Kroah-Hartman > Cc: "Rafael J. Wysocki" > Cc: Linux Kernel Mailing List > Cc: Linux Next Mailing List > Signed-off-by: Bagas Sanjaya Acked-by: Luis Chamberlain Luis