Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp634574iob; Wed, 4 May 2022 05:02:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZUghm8WG5bxTgz1YhLlSSXF0M+JxgAlkwRWtvNzKbyHkEBNv2BylVOu4LOlUzvNPpuLGf X-Received: by 2002:a02:2120:0:b0:32b:3ea2:56ab with SMTP id e32-20020a022120000000b0032b3ea256abmr8266545jaa.262.1651665728528; Wed, 04 May 2022 05:02:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651665728; cv=none; d=google.com; s=arc-20160816; b=RiUIz0ef8hNxUnkGHQ+nUsa5es8ZspRleUUaJSw2xI/m5b13tG0wZLmfsX3Ab9kSN/ NVr/9phkreHERPFRr5QTgmNgoVLGcQD2NPEF4ozhLdQkjIQtU/6e8X05SYhoTC+8GeEQ gv7HLbl0accYoZ9C2XMQBRSMF93tczupDKJ+2ahvFWq7smWFdfa260Alnr4cI1EL6byn dZbFJnjQqXvz92d992jWcz2NSIRFKyzhmLqMXIA7cdlcSewwtt/krTUNgtQ1eyIX0oj+ Ds6X03Y/9gLlv7iuH313FKYnEy8czosj0vy3foub2H1e8WfwuqAG3Gq2XB6ZYr60yMyT vxXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zepmySBnv63WSkAXdeQNdsshIcZAMk3EbNb3138mR5I=; b=hRmo9/qZLSqiZ40rQo/WUDYgVwvLRupX04TKOx7qDNemN/i0w5v54t6oQzRY8D7G9r weq0pk0Sm1R99jMvQe36xGokrD3CViYmH+99/ZJFuIwzLnHJMpK9BRcn/st4FRaAmotX iB8g5INW/gRaFAoPtDK7K4/enRn8NF9iWBoRuBoqF1c2efRyuon1UuKUJdLY54ipA7kx ZONtf5QNYUigQp4wbe+M1CWs2odbVx+o/gw4qPmZKOpxWl+4bQ9cT2YaFLAmf7yi6k0C Jk7u6Y00ZeYHyQzYNn38FeSL4F/ZOtNOkLljCXvbaqldGB3D1pK3x7PbM3Bz9RlzdJ33 +w6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=bPTLq9Hf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s17-20020a056e0210d100b002cdf7351c52si5955607ilj.17.2022.05.04.05.01.51; Wed, 04 May 2022 05:02:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=bPTLq9Hf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241633AbiECSvu (ORCPT + 99 others); Tue, 3 May 2022 14:51:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233688AbiECSvs (ORCPT ); Tue, 3 May 2022 14:51:48 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F4263F888 for ; Tue, 3 May 2022 11:48:13 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id qe3-20020a17090b4f8300b001dc24e4da73so2191894pjb.1 for ; Tue, 03 May 2022 11:48:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zepmySBnv63WSkAXdeQNdsshIcZAMk3EbNb3138mR5I=; b=bPTLq9HfixcNLyVJaD/IrjOzYpPYh6ISpk4y9g70RAzYOYURAhNFSKi9A8tlEgtCuJ iHj76bj+ybFYWsdpewyIJ3JKcaRbYMR7FX+0Q/hYkNlr8qX9BEK1lv4F9wffhLucBx3q SylUmT+RO9ZZ/BVTL5k64FhSzsgHlNaUBFLmE/U4/LP9YcLC2OZCh7DaHU0TaxBPJ2Dx 2NbnofXzs6vgcN9+tV/SLoEc+zEYD3D5rICX0xAIdUFNtq7wKMpc5IglomUTKK4yxDaY ShhRYAJ/B66lGc7uGfFrMJbYDfmbVro4tMSlHoufl/pWmplvDYL/1g+YQftWwZAso+8+ 8HlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zepmySBnv63WSkAXdeQNdsshIcZAMk3EbNb3138mR5I=; b=Npzq9f4GgdqxVk6Im99OOnSnmZkkHPolWUKSoUjI3fjY4orn8YTh6/KR44n1yq4dyh 8ueeOhbJZhdR9dWhlBc5kmZXCQxPaTcC4H0HwOVs0lxzzqgnyF1WI4MwzpkEr6lFCy0Z JVxQ2hGX4BeP/6ghhtSpcI5uZWgap7Uz5AOaeKgo1qpt0I5VmZ35eDJjM9YmBY9iFbuM GV33F9VdHoPrBFv2x56qxehdsshWFwSL9oLrBOEAaB19WC7juU3kYp9JRfNS9ILh1arq igLqqG8oAYqspu1E6w3YuiN1XCmDIBoz/8jc5dpbOWKX3J2g8FL7f7m/jVXbsMmSdpEm rm8A== X-Gm-Message-State: AOAM531XGDX8I/caQt/PRSokzhYYYkYJ2avDC1JivhFEl+Q3GAouBGme pvE/jA9Sx7LR6lttaJe/965hMQ== X-Received: by 2002:a17:903:246:b0:153:857c:a1f6 with SMTP id j6-20020a170903024600b00153857ca1f6mr17679441plh.153.1651603692636; Tue, 03 May 2022 11:48:12 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id 30-20020a63125e000000b003c291b46f7esm824358pgs.18.2022.05.03.11.48.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 11:48:12 -0700 (PDT) Date: Tue, 3 May 2022 18:48:08 +0000 From: Sean Christopherson To: "Maciej S. Szmigiero" Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Maxim Levitsky , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 00/12] KVM: SVM: Fix soft int/ex re-injection Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 02, 2022, Maciej S. Szmigiero wrote: > From: "Maciej S. Szmigiero" > > This series is an updated version of Sean's SVM soft interrupt/exception > re-injection fixes patch set, which in turn extended and generalized my > nSVM L1 -> L2 event injection fixes series. > > Detailed list of changes in this version: > * "Downgraded" the commit affecting !nrips CPUs to just drop nested SVM > support for such parts instead of SVM support in general, > > * Removed the BUG_ON() from svm_inject_irq() completely, instead of > replacing it with WARN() - Maxim has pointed out it can still be triggered > by userspace via KVM_SET_VCPU_EVENTS, > > * Updated the new KVM self-test to switch to an alternate IDT before attempting > a second L1 -> L2 injection to cause intervening NPF again, > > * Added a fix for L1/L2 NMI state confusion during L1 -> L2 NMI re-injection, > > * Updated the new KVM self-test to also check for the NMI injection > scenario being fixed (that was found causing issues with a real guest), > > * Changed "kvm_inj_virq" trace event "reinjected" field type to bool, > > * Integrated the fix from patch 5 for nested_vmcb02_prepare_control() call > argument in svm_set_nested_state() to patch 1, > > * Collected Maxim's "Reviewed-by:" for tracepoint patches. > > Previous versions: > Sean's v2: > https://lore.kernel.org/kvm/20220423021411.784383-1-seanjc@google.com > > Sean's v1: > https://lore.kernel.org/kvm/20220402010903.727604-1-seanjc@google.com > > My original series: > https://lore.kernel.org/kvm/cover.1646944472.git.maciej.szmigiero@oracle.com > > Maciej S. Szmigiero (4): > KVM: nSVM: Sync next_rip field from vmcb12 to vmcb02 > KVM: SVM: Don't BUG if userspace injects an interrupt with GIF=0 LOL, this should win some kind of award for most ridiculous multi-author patch :-) Series looks good, thanks!