Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220503065147.51728-1-krzysztof.kozlowski@linaro.org> <20220503065147.51728-4-krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220503065147.51728-4-krzysztof.kozlowski@linaro.org>
From:   Baolin Wang <baolin.wang7@gmail.com>
Date:   Wed, 4 May 2022 10:29:20 +0800
Message-ID: <CADBw62oQbc4a9HxFFmO0E-bDvVvPnUo=raVOaSXZpLkKsNo-tQ@mail.gmail.com>
Subject: Re: [PATCH v2 3/3] arm64: dts: sprd: use new 'dma-channels' property
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Orson Zhai <orsonzhai@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        dmaengine@vger.kernel.org,
        Devicetree List <devicetree@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, May 3, 2022 at 2:51 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> The '#dma-channels' property was deprecated in favor of one defined by
> generic dma-common DT bindings.  Add new property while keeping old one
> for backwards compatibility.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks.
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>

> ---
>  arch/arm64/boot/dts/sprd/whale2.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/sprd/whale2.dtsi b/arch/arm64/boot/dts/sprd/whale2.dtsi
> index 79b9591c37aa..89d91abbd5d1 100644
> --- a/arch/arm64/boot/dts/sprd/whale2.dtsi
> +++ b/arch/arm64/boot/dts/sprd/whale2.dtsi
> @@ -126,7 +126,9 @@ ap_dma: dma-controller@20100000 {
>                                 reg = <0 0x20100000 0 0x4000>;
>                                 interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>;
>                                 #dma-cells = <1>;
> +                               /* For backwards compatibility: */
>                                 #dma-channels = <32>;
> +                               dma-channels = <32>;
>                                 clock-names = "enable";
>                                 clocks = <&apahb_gate CLK_DMA_EB>;
>                         };
> @@ -272,7 +274,9 @@ agcp_dma: dma-controller@41580000 {
>                                 compatible = "sprd,sc9860-dma";
>                                 reg = <0 0x41580000 0 0x4000>;
>                                 #dma-cells = <1>;
> +                               /* For backwards compatibility: */
>                                 #dma-channels = <32>;
> +                               dma-channels = <32>;
>                                 clock-names = "enable", "ashb_eb";
>                                 clocks = <&agcp_gate CLK_AGCP_DMAAP_EB>,
>                                        <&agcp_gate CLK_AGCP_AP_ASHB_EB>;
> --
> 2.32.0
>


-- 
Baolin Wang