Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <YmrnMQwIR9wOeoKE@ripper>
References: <20220422230013.1332993-1-bjorn.andersson@linaro.org> <20220423014824.912ACC385A0@smtp.kernel.org> <YmNsYSxLtwLpw98t@ripper> <20220423031350.01299C385A0@smtp.kernel.org> <YmN11qt/PqogYruQ@ripper> <20220425223426.BE973C385A4@smtp.kernel.org> <3fb043e6-2748-24f8-0115-b5372c747a12@linaro.org> <Ymq6UOjrYgFlzl/W@ripper> <CAA8EJpqBMzTNjTSWN1UMXM61-DmW22RKQJyWoMw3Rds=xEVQaQ@mail.gmail.com> <YmrnMQwIR9wOeoKE@ripper>
Subject: Re: [PATCH v2 1/2] dt-bindings: clock: Add Qualcomm SC8280XP GCC bindings
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        quic_tdas@quicinc.com
To:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Date:   Tue, 03 May 2022 12:19:01 -0700
User-Agent: alot/0.10
Message-Id: <20220503191903.CEBE0C385A9@smtp.kernel.org>
Precedence: bulk

Quoting Bjorn Andersson (2022-04-28 12:12:49)
> On Thu 28 Apr 09:24 PDT 2022, Dmitry Baryshkov wrote:
>=20
> > > >
> > > > And actually might I suggest an alternative approach to manually us=
ing
> > > > indices everywhere? What about spending the time once during the bo=
ot to
> > > > convert .fw_name and clock_names to parent indices during clock reg=
istration
> > > > and then using them for all the further operations?
> > > >
> > >
> > > I'm pretty sure that's what clk_core_fill_parent_index() already does.
> >=20
> > In this case I think we should go for clock-name in the DT and
> > auto-flled indices inside. Stephen, WDYT? Would that fix your concern
> > for comparing strings each and every time?
> >=20
>=20
> You mean, just continue doing what we've been doing lately with fw_name
> etc?
>=20
> That lookup is the one that Stephen wants to avoid.
>=20

Right. Translating .fw_name to indices isn't a solution because I want to=20

 1. Reduce the number of string comparisons

 2. Shrink the kernel's data section by removing strings

and having there still be strings works against both points.