Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp720158iob; Wed, 4 May 2022 06:44:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0lbcINJju/HVr1aXv8S8vRE5qZGt4yY4SmYiIcNNu37QhCnn3w93I9shAtQ64xNdljprX X-Received: by 2002:a17:907:a41f:b0:6f3:e75c:5a77 with SMTP id sg31-20020a170907a41f00b006f3e75c5a77mr19179332ejc.70.1651671872438; Wed, 04 May 2022 06:44:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651671872; cv=none; d=google.com; s=arc-20160816; b=yuWvSqZH/UYd6FN+DMDSic54+J6dqL/NzqcaH2AGlrb37S4OsOiOVW9R+Ha8jnHC/R e9G3Ks+nbgY2UNc8UV2VbL5A/GnuSFTajgc+OQKFaTNq+bQTp3TqulofT2V+5EdMqNiK nhRrj8uAD7smXAVV5ivRN4TUXWf8k6P+CdR6jEcLj/Z6ATk6yjR+gfsuublsyJ7b21Pa 8JR7HePKQblyIuPTcz2bBYg03VQuB686vpNxxzneqT0lrtTmK4qagUbpKWSwy3G/KA72 2n7j2ZS8cdHxCK2s4ULQ4C9FV4PV3qE8it6TolB/71WZy5/Yhi7P82ZqTE8/grg9U3UI pvvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=aJ6LSQS2hZp/i3Er1PZcJDTlIm5WitovxDQeaGU9cAY=; b=Va5HB/F3ch6b6CjU5g3fiwh28oOpwzUggS55HueBI4O47nkTzJd1oOO2EYv8OVNIIR N9aPyd1CckiWxl7li6eFEikjlZWXfpAU8SwwlhQ/URcYSeK4st/wP8Ftag2Oe39aXr7l b0e4Ng67d4fFcWNzgdOLewbnUgFx8DdHKb2h/mTbO2I3SEevvExvKDMAM8pUaJzMgRcI osNDNgiMKnrHbnP2TabKS71h47vT/HsTng9Xw364MpPVLPOz7QYGhNXRJg2/6SjhWZLb rPdCt3ShKoitRZJoDItKgqmgINSFNr2MxFJ5V6PQVXoYboRn6qxT6tBPUrx1LLvBsqcP OPcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=WTLzW2HJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v7-20020a17090606c700b006f47903d559si4725337ejb.953.2022.05.04.06.44.07; Wed, 04 May 2022 06:44:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=WTLzW2HJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243756AbiECWp3 (ORCPT + 99 others); Tue, 3 May 2022 18:45:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230263AbiECWp1 (ORCPT ); Tue, 3 May 2022 18:45:27 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AA982DA89 for ; Tue, 3 May 2022 15:41:54 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id p10so32645735lfa.12 for ; Tue, 03 May 2022 15:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aJ6LSQS2hZp/i3Er1PZcJDTlIm5WitovxDQeaGU9cAY=; b=WTLzW2HJFi/Z1y+N4gAHgVKK1VuC87VXq9k0nNYsUTnMvX9bd+jxioIwGpNC9V+CSI KELuVjTwGzBhxLqNqagoquMhsrEJefNChCLonIzL0jpLz3Yq97uKmCn83uHtsaxrcB19 tgu7+VGYMG4ZeZ5/Ml6eBX4/cTUM1LBycamnI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aJ6LSQS2hZp/i3Er1PZcJDTlIm5WitovxDQeaGU9cAY=; b=sfrLbh/dF9XnsSBT+djeOAmtY0k92IBeWlC0jhtm5Cbcw7xFK8f3A+pQmIdpfVkCXz hGm9Lruf1abmUZ/6OBnNkKYeAfinx/ubZZccmuag+t8w2OJJ8SgNCwjGJFKCm2sHaD0b iqTXzLUuIh87QJ0DMAQQvuUEAej1Ch5hp6Bv2TIhZeuPfSofycX8m77Mf6uFFZR/BJd4 mVo4E9hlFPOYJP53isTGzC549Gz4sNGDb1PRcsNZLgjVOn/tekIaCl5uulY5xhAwNrbu LirpMNMvEin3WdwsAIl2FyA86uO6OmJ7zTQdLBhdzD1KGdAx1LwQEBtGC+vxGIyoG/Qm +T+g== X-Gm-Message-State: AOAM531/cWefpqnll0mSDue1N69+JQ/REkKZ0XmZdqL2sf6t7D5eWNJ/ 0CHX69AlY8zKCvENPmej5kTPr1aan0DTyBpM X-Received: by 2002:a05:6512:1398:b0:445:bcef:e4fd with SMTP id p24-20020a056512139800b00445bcefe4fdmr12350269lfa.398.1651617711757; Tue, 03 May 2022 15:41:51 -0700 (PDT) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com. [209.85.167.42]) by smtp.gmail.com with ESMTPSA id p10-20020a05651238ca00b0047255d21138sm1049306lft.103.2022.05.03.15.41.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 May 2022 15:41:50 -0700 (PDT) Received: by mail-lf1-f42.google.com with SMTP id i10so4651863lfg.13 for ; Tue, 03 May 2022 15:41:49 -0700 (PDT) X-Received: by 2002:a05:6512:a8f:b0:473:a826:bfd0 with SMTP id m15-20020a0565120a8f00b00473a826bfd0mr3724913lfu.435.1651617709017; Tue, 03 May 2022 15:41:49 -0700 (PDT) MIME-Version: 1.0 References: <20220426145445.2282274-1-agruenba@redhat.com> <20220503213524.3273690-1-agruenba@redhat.com> In-Reply-To: <20220503213524.3273690-1-agruenba@redhat.com> From: Linus Torvalds Date: Tue, 3 May 2022 15:41:32 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] gfs2 fix To: Andreas Gruenbacher Cc: Christoph Hellwig , "Darrick J. Wong" , Dave Chinner , cluster-devel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 3, 2022 at 2:35 PM Andreas Gruenbacher wrote: > > More testing still ongoing, but the following patch seems to fix the > data corruption. Fingers crossed. > + truncate_pagecache_range(inode, hstart, hend - 1); > + if (hstart < hend) > + punch_hole(ip, hstart, hend - hstart); Why doesn't that "hstart < hend" condition cover both the truncate and the hole punch? Linus