Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 4 May 2022 17:19:51 +0200
From:   Henning Schild <henning.schild@siemens.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Mark Gross <markgross@kernel.org>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Guenter Roeck <linux@roeck-us.net>,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
        platform-driver-x86@vger.kernel.org,
        linux-watchdog@vger.kernel.org, Enrico Weigelt <lkml@metux.net>,
        Gerd Haeussler <gerd.haeussler.ext@siemens.com>
Subject: Re: [PATCH 0/2] simatic-ipc additions to p2sb apl lake gpio
Message-ID: <20220504171951.0d569632@md1za8fc.ad001.siemens.net>
In-Reply-To: <YnJ2tYjCpJi7yc4j@smile.fi.intel.com>
References: <20220131151346.45792-1-andriy.shevchenko@linux.intel.com>
        <20220308193522.26696-1-henning.schild@siemens.com>
        <YnJ2tYjCpJi7yc4j@smile.fi.intel.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1jtFtJOq8gwCukzE5+8PXTR2Zgw7spWFOJQLgxdPpkm077x7U+X9ziDsIZLL?=
 =?us-ascii?Q?99ginLO0fW2LGphwJOT5kEpPVgl+0n9xyeYrdIaK8tUNNHeJ1mga7e3lvMYb?=
 =?us-ascii?Q?K1AId6v6UAVozMNaTNtOyVFhk7YC3IeD0JuaAxEGU+rIRq5JLeaqZjD4lOPc?=
 =?us-ascii?Q?EV1kUJj0XrHuxpOFq9iB+AyVNQV86QkumhmOBp6YSQrw+a4dUklufBXp11Ic?=
 =?us-ascii?Q?t4eQFG9li8IpgiG9rqGVaDhBJe9MGcEz2rC6UgJTkd4dr6kBGi6dbqrWlPbp?=
 =?us-ascii?Q?b19dFnt6KzWp4t1P8h2VFxBVwcbbT+5p1ZUptlATOmgXf1tUMyNMHb+tF2Zn?=
 =?us-ascii?Q?cmFBT2se1b9b1oJmmdPl0YN+2XiVtlh/jQ8DuSRBULxuM3jytru3b0SpQ506?=
 =?us-ascii?Q?uzwlhOUy32BuUZF5cIaZpTAJAOQRLv4gIeSZLvyf8qnKeSe1An08aPoV/pz5?=
 =?us-ascii?Q?u1h9Kbf5/42zmzyiEIfBAInfiJD30+Z4x7g91bsFwWCm+TrLMnEhjJUs+few?=
 =?us-ascii?Q?MkhwVJGkXWt36SVKmJCmZanfG9CNL9r+ldgvVwszQqFyhVeeptxAE8EaoS51?=
 =?us-ascii?Q?IHBZfFgTxAdPaN/YNLwsd0eC5cgYt2FSAftEGEIqDCNGtSDq8vvSH0JCqrEW?=
 =?us-ascii?Q?q3a0QR605o1et1U8IK3r7SnIWELsqek7VlGSqKqS2xy+p+bYMOfhQ4trlNMy?=
 =?us-ascii?Q?CCRenfThJZ4a6G+Tv1GtosksIUciK6+20q1vL/CQaz1qCj65YpQdGaYXCnfY?=
 =?us-ascii?Q?df7aosfsTF3OfmbKeKVgyh3S+4UABMXLGV1SEUM5rGlchdk/D4QKoz0vMIht?=
 =?us-ascii?Q?IeQ0JURG4mbq4NpwtgAjXVnwnLdpgtXJls3p7GjJ+xuqv5XdOePsIfFzGvK9?=
 =?us-ascii?Q?v1ECLfYlsGOpbGS2r6s1gPoW4RPkGmNZaZ7mckq0C0SdcfZzxKwAk6nJAu9F?=
 =?us-ascii?Q?6dJ44TaK5GfhuRClkXbZ71uA2WLpMTmeJv44Fsjxa+J2504fMHS8Euyul0ZH?=
 =?us-ascii?Q?uyxZ3hgG0z82kUGa/32BsmFu6nA8hugUchiS/FQGWicRaGwkY6vg2Wy4LXJQ?=
 =?us-ascii?Q?t4TmOa+Yw0wECaKyJVh6dJ+U0mqGydAanNrYrdg8vf89jJO4Ymh94zd+q6/H?=
 =?us-ascii?Q?nmKfkku/dsOpcNHceIQ9PG+YPRnWgAkAzIn6l+/aqvMUpqTCKg5kCruhTTws?=
 =?us-ascii?Q?mBJYYbEEugT8QqEpB5mGo/7OG2R8diIdzqNOjzXJW5Q0Md0IN4CoQdq1Q9xZ?=
 =?us-ascii?Q?y5b/E+WmS+xemnxxRHlu13xl57XWgiW7plKeoTB+Rw9N/8RsDUfRIFRaRBFo?=
 =?us-ascii?Q?DVItAMb2IONFkatZhnjyzySTKgdeuICv1tV8I6twdl85/twq8C5Ysfirwfc8?=
 =?us-ascii?Q?TGbTX/6Umk4NDNuwdu1lci/aYnpnEEf+2tmxv1BfB/rO3AWrbpY8y7RLzvoz?=
 =?us-ascii?Q?j121kwLscaNvhvGEO+CYAW4N2lweLiBAYWcPhnRbQJCbu3uIuWvwfOiThaeV?=
 =?us-ascii?Q?qhTQdqZmsKsmzAtYpsflZe6DM3C4Obk7fj0oamTbIfMep0WHDYTkAeLgM67v?=
 =?us-ascii?Q?0o0UgzKbmzROdX9bJz1a/E+wOO9RLQQHHj+QouJX9j2z9vNxlsAIIAEvMTux?=
 =?us-ascii?Q?DXewtH75qKtPKuE9exmPAgSaQhKkWR0aCSVb6k3rJYhDJGlf38DeyUpkjzb9?=
 =?us-ascii?Q?WhZGmU8xnVtX76Vjk/f0rfWAiBzNKRT4lg9+2PMz3n0Y7NuUUNqQa1jGrIlK?=
 =?us-ascii?Q?H3aZUOGz88GfJTH8cN1c0PFuUWfaSjZV8H7FJih15XP5h2QPVkjO?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 03033f90-8828-4890-aad7-08da2de18a4b
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 15:19:53.8715
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z3PxVk+c7PnWVp6I1xwWE9eou2rhBOfL9watHm0NEclrcGMxvhKn9QUjG2xeN1WzErtf5HnfJSlC64Vcjd6blV4MJfIVt9WDedjazKV+MBE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR10MB5830
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Wed, 4 May 2022 15:51:01 +0300
schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:

> On Tue, Mar 08, 2022 at 08:35:20PM +0100, Henning Schild wrote:
> > This switches the simatic-ipc modules to using the p2sb interface
> > introduced by Andy with "platform/x86: introduce p2sb_bar() helper".
> > 
> > It also switches to one apollo lake device to using gpio leds.
> > 
> > I am kind of hoping Andy will take this on top and propose it in his
> > series.  
> 
> First of all, they are not applicable to my current version [1] of
> the series (it maybe something changed in the Simatic drivers
> upstream, because I have got conflicts there. For the record, I'm
> using Linux Next as a base.

That is possible, some sparse findings have been fixed lately.

> Second question is could it be possible to split first patch into
> three, or it has to be in one?

I assume one for leds one for wdt and finally drop stuff from platform,
and i will go with that assumption for a next round based on your tree
directly.
Can you explain why that will be useful? While it is kind of a
separation of concerns and subsystems ... it also kind of all belongs
together and needs to be merged in a rather strict order.

regards,
Henning

> [1]: https://gitlab.com/andy-shev/next/-/tree/topic/p2sb-next
> It would be nice if you can perform another round of testing.
> 
> > Henning Schild (2):
> >   simatic-ipc: convert to use common P2SB accessor
> >   leds: simatic-ipc-leds-gpio: add GPIO version of Siemens driver
> > 
> >  drivers/leds/simple/Kconfig                   |  11 ++
> >  drivers/leds/simple/Makefile                  |   3 +-
> >  drivers/leds/simple/simatic-ipc-leds-gpio.c   | 108
> > ++++++++++++++++++ drivers/leds/simple/simatic-ipc-leds.c        |
> > 77 +------------ drivers/platform/x86/simatic-ipc.c            |
> > 43 +------ drivers/watchdog/Kconfig                      |   1 +
> >  drivers/watchdog/simatic-ipc-wdt.c            |  15 +--
> >  .../platform_data/x86/simatic-ipc-base.h      |   2 -
> >  8 files changed, 139 insertions(+), 121 deletions(-)
> >  create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio.c
> > 
> > -- 
> > 2.34.1
> >   
>