Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 04 May 2022 09:44:29 +0200
User-Agent: K-9 Mail for Android
In-Reply-To: <95aea078-3e85-79c3-79c0-430bd7c0fbae@linaro.org>
References: <20220502153238.85090-1-linux@fw-web.de> <d29637f8-87ff-b5f0-9604-89b51a2ba7c1@linaro.org> <trinity-cda3b94f-8556-4b83-bc34-d2c215f93bcd-1651587032669@3c-app-gmx-bap25> <10770ff5-c9b1-7364-4276-05fa0c393d3b@linaro.org> <trinity-213ab6b1-ccff-4429-b76c-623c529f6f73-1651590197578@3c-app-gmx-bap25> <95aea078-3e85-79c3-79c0-430bd7c0fbae@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: Aw: Re: Re: [RFC v1] dt-bindings: net: dsa: convert binding for mediatek switches
Reply-to: frank-w@public-files.de
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
CC:     Greg Ungerer <gerg@kernel.org>,
        =?ISO-8859-1?Q?Ren=E9_van_Dorst?= <opensource@vdorst.com>,
        Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
        Frank Wunderlich <linux@fw-web.de>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Sean Wang <sean.wang@mediatek.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
From:   Frank Wunderlich <frank-w@public-files.de>
Message-ID: <69290DD3-0179-49C2-8E7D-9F8DBDEBC96F@public-files.de>
Precedence: bulk

m 4=2E Mai 2022 08:51:41 MESZ schrieb Krzysztof Kozlowski <krzysztof=2Ekozl=
owski@linaro=2Eorg>:
>On 03/05/2022 17:03, Frank Wunderlich wrote:
>>=20
>> have not posted this version as it was failing in dtbs_check, this
>was how i tried:
>>=20
>>
>https://github=2Ecom/frank-w/BPI-R2-4=2E14/blob/8f2033eb6fcae273580263c3f=
0b31f0d48821740/Documentation/devicetree/bindings/net/dsa/mediatek=2Eyaml#L=
177
>
>You have mixed up indentation of the second if (and missing -)=2E

The "compatible if" should be a child of the "if" above,because phy-mode p=
roperty only exists for cpu-port=2E I can try with additional "-" (but i gu=
ess this is only needed for allOf)

Rob told me that i cannot check compatible in subnode and this check will =
be always true=2E=2E=2Ejust like my experience=2E
I can only make the compatible check at top-level and then need to define =
substructure based on this (so define structure twice)=2E He suggested me a=
dding this to description for now=2E

Imho this can be added later if really needed=2E=2E=2Edid not found any ex=
ample checking for compatible in a subnode=2E All were in top level=2E Afai=
r these properties are handled by dsa-core/phylink and driver only compares=
 constants set there=2E

>(=2E=2E=2E)
>
>>>>
>>>> basicly this "ports"-property should be required too, right?
>>>
>>> Previous binding did not enforce it, I think, but it is reasonable
>to
>>> require ports=2E
>>=20
>> basicly it is required in dsa=2Eyaml, so it will be redundant here
>>=20
>>
>https://elixir=2Ebootlin=2Ecom/linux/v5=2E18-rc5/source/Documentation/dev=
icetree/bindings/net/dsa/dsa=2Eyaml#L55
>>=20
>> this defines it as pattern "^(ethernet-)?ports$" and should be
>processed by dsa-core=2E so maybe changing it to same pattern instead of
>moving up as normal property?
>
>Just keep what is already used in existing DTS=2E

Currently only "ports" is used=2E=2E=2Eso i will change it to "normal" pro=
perty=2E

>>>> for 33 there seem no constant=2E=2Eall other references to pio node a=
re
>with numbers too and there seem no binding
>>>> header defining the gpio pins (only functions in
>include/dt-bindings/pinctrl/mt7623-pinfunc=2Eh)
>>>
>>> ok, then my comment
>>=20
>> you mean adding a comment to the example that GPIO-flags/constants
>should be used instead of magic numbers?
>
>I think something was cut from my reply=2E I wanted to say:
>"ok, then my comment can be skipped"

Ok

>But I think your check was not correct=2E I looked at bpi-r2 DTS
>(mt7623n)
>and pio controller uses GPIO flags=2E

I see only same as in the example

https://elixir=2Ebootlin=2Ecom/linux/latest/source/arch/arm/boot/dts/mt762=
3n-bananapi-bpi-r2=2Edts#L196

>Best regards,
>Krzysztof
regards Frank