Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp891230iob; Wed, 4 May 2022 10:03:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCwhmXPwih2fEi/IeRo6EWiw9+53vrH8jbCv1rWbdkzpmAVkFKDZTSSFqXvD3gRgqC78UY X-Received: by 2002:a17:902:cf0c:b0:15b:63a4:9f47 with SMTP id i12-20020a170902cf0c00b0015b63a49f47mr22545041plg.1.1651683788901; Wed, 04 May 2022 10:03:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651683788; cv=none; d=google.com; s=arc-20160816; b=a2snTAP91dPUap7qkj6iCHhYfMm6mdrChJXie6UeUrgNvPL7nOSdyoBz94EX8CY/T4 /wJ2Srfc00RFKYBR17zcomzVA1+bo2rSWoSeBZZmru7DrQluAQr5v8N+/Vqr3M8BFo4l v65T7h4lDdReT5FlRubQR24WImT7OQlr6KGizCXxckbqil69lTYSAHZa6ipYCYkV7SAr x4h9EBocdOBfIkppxBsj8Hml/Z3pgXIbX+z+vftT3mXBGVtcdK6L8/zdqh+R22veEcRn R6T3ZDXlJrbI6Uv0QMfpjjY31xoCAltU3ddEtqUm7xvp1hCPEs4WUdyPjHD+27jDmjcq wh3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=/WlqRNIp+N8Wco2tOPG38E5mCka34X8S9j7nFe4jQ0c=; b=y4qDNA/GuKldXEsXLBQu4+qt9NFekQntkMUZUbwFZ4XHrWLOl+VouGUkrmDH1y3OLI g4tm72LCpVaF2gjG7bnxsxV38tEBoht+auLlr3XJ6knEs+WelJ5+RGYwSSHNjO2mnaOF aPxib9Ycib7EYLUmWn5x5phepruARS2W4KiG0FPD3rLazPBBDfsUA7MCC6Gy/XBKz0Sp /icbStsDLVvrRoE1yVahtuMTV63PL6kp0Qxh6MADHgZAUStMUG0Tfrhb5kwWXQDkbBmo usRF91h21XfV5AVmHewrAQ9Zz7P2Xz4evy6OMOjDVsrA0aeJs7XZ/VXJbARqMoZ+vVgT Ry+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i63-20020a638742000000b00382a7c2cad7si18674232pge.206.2022.05.04.10.02.50; Wed, 04 May 2022 10:03:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349235AbiEDMOO (ORCPT + 99 others); Wed, 4 May 2022 08:14:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349196AbiEDMOM (ORCPT ); Wed, 4 May 2022 08:14:12 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CA571707B for ; Wed, 4 May 2022 05:10:37 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmDpx-0008Bl-5z; Wed, 04 May 2022 14:10:33 +0200 Received: from mfe by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nmDpt-000527-Jl; Wed, 04 May 2022 14:10:29 +0200 Date: Wed, 4 May 2022 14:10:29 +0200 From: Marco Felsch To: Gireesh.Hiremath@in.bosch.com Cc: linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, bcousson@baylibre.com, tony@atomide.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, dmitry.torokhov@gmail.com, mkorpershoek@baylibre.com, davidgow@google.com, swboyd@chromium.org, fengping.yu@mediatek.com, y.oudjana@protonmail.com, rdunlap@infradead.org, colin.king@intel.com, sjoerd.simons@collabora.co.uk, VinayKumar.Shettar@in.bosch.com, Govindaraji.Sivanantham@in.bosch.com, anaclaudia.dias@de.bosch.com Subject: Re: [PATCH 2/4] Input: mt-matrix-keypad: Add Bosch mt matrix keypad driver Message-ID: <20220504121029.h6z2vtbapllkfsad@pengutronix.de> References: <20220504105254.1576-1-Gireesh.Hiremath@in.bosch.com> <20220504105254.1576-2-Gireesh.Hiremath@in.bosch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220504105254.1576-2-Gireesh.Hiremath@in.bosch.com> User-Agent: NeoMutt/20180716 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gireesh, On 22-05-04, Gireesh.Hiremath@in.bosch.com wrote: > From: Gireesh Hiremath > > add support for keypad driver running on Bosch Guardian > Dtect board using TI-am335x cpu. Driver implementation > is based on matrix_keypad.c pls can you tell me the main difference between the already existing matrix_keypad.c driver and your driver. If there are only minor differences I would rather add those to the existing driver. Regards, Marco