Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9d8b436a-5d8d-2a53-a2a1-5fbab987e41b@gmail.com>
Date:   Wed, 4 May 2022 11:28:51 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH net-next] net/core: Remove comment quote for
 __dev_queue_xmit()
Content-Language: en-US
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     linux-doc@vger.kernel.org, Stephen Rothwell <sfr@canb.auug.org.au>,
        Dave Jones <davej@redhat.com>,
        Randy Dunlap <randy.dunlap@oracle.com>,
        "David S . Miller" <davem@davemloft.net>,
        Pavel Begunkov <asml.silence@gmail.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220503072949.27336-1-bagasdotme@gmail.com>
 <20220503180341.36dcbb07@kernel.org>
From:   Bagas Sanjaya <bagasdotme@gmail.com>
In-Reply-To: <20220503180341.36dcbb07@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/4/22 08:03, Jakub Kicinski wrote:
> On Tue,  3 May 2022 14:29:49 +0700 Bagas Sanjaya wrote:
>> - * -----------------------------------------------------------------------------------
>> - *      I notice this method can also return errors from the queue disciplines,
>> - *      including NET_XMIT_DROP, which is a positive value.  So, errors can also
>> - *      be positive.
>> - *
>> - *      Regardless of the return value, the skb is consumed, so it is currently
>> - *      difficult to retry a send to this method.  (You can bump the ref count
>> - *      before sending to hold a reference for retry if you are careful.)
>> - *
>> - *      When calling this method, interrupts MUST be enabled.  This is because
>> - *      the BH enable code must have IRQs enabled so that it will not deadlock.
>> - *          --BLG
>> + *	This method can also return positive errno code from the queue
>> + *	disciplines (including NET_XMIT_DROP).
>> + *
>> + *	Note that regardless of the return value, the skb is consumed
>> + *	anyway, so it is currently difficult to retry sending to this
>> + *	method.
> 
> Why drop almost half of the comment if the problem is just the ----
> banner?

I can't think of preserving delineation between actual documentation
and the quote without messing up kernel-doc.

Actually the "--BLG" signature is the culprit.

-- 
An old man doll... just what I always wanted! - Clara