Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e9f5cbd0-fef4-ae82-b543-536eccdeed5f@quicinc.com>
Date:   Wed, 4 May 2022 16:22:08 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] soc: qcom: socinfo: Add another ID for sc7180
Content-Language: en-US
To:     Doug Anderson <dianders@chromium.org>
CC:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        <matvore@chromium.org>, Stephen Boyd <swboyd@chromium.org>,
        Andy Gross <agross@kernel.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
References: <20220502173338.1.I26eca1856f99e6160d30de6d50ecab60e6226354@changeid>
 <13819b2d-26f0-14f4-9cb9-affb6b18f13d@quicinc.com>
 <CAD=FV=VBqbhB03uPtnzYdRHhU-4TnX6RgDpHK27RUXY84esebw@mail.gmail.com>
From:   Sai Prakash Ranjan <quic_saipraka@quicinc.com>
In-Reply-To: <CAD=FV=VBqbhB03uPtnzYdRHhU-4TnX6RgDpHK27RUXY84esebw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 5/4/2022 9:00 AM, Doug Anderson wrote:
> Hi,
>
> On Tue, May 3, 2022 at 7:14 PM Sai Prakash Ranjan
> <quic_saipraka@quicinc.com> wrote:
>> Hi,
>>
>> On 5/3/2022 6:03 AM, Douglas Anderson wrote:
>>> It appears the some sc7180 devices, like the one in my
>>> sc7180-trogdor-homestar, report an ID of 407 instead of 425. Add
>>> another ID into the list.
>>>
>>> Signed-off-by: Douglas Anderson <dianders@chromium.org>
>>> ---
>>>
>>>    drivers/soc/qcom/socinfo.c | 1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
>>> index cee579a267a6..2ef1dc2a1dd3 100644
>>> --- a/drivers/soc/qcom/socinfo.c
>>> +++ b/drivers/soc/qcom/socinfo.c
>>> @@ -318,6 +318,7 @@ static const struct soc_id soc_id[] = {
>>>        { 396, "IPQ8071A" },
>>>        { 402, "IPQ6018" },
>>>        { 403, "IPQ6028" },
>>> +     { 407, "SC7180" },
>>>        { 421, "IPQ6000" },
>>>        { 422, "IPQ6010" },
>>>        { 425, "SC7180" },
>> Hmm, this ID maps to SM6250 which is a mobile variant. Not sure we should
>> use it for SC7180 which already has 425 ID assigned, perks of marketing :)
> That's super weird. Any idea why my strongbad reports 407 then? Is it
> a firmware bug, or someone misprogrammed something? What can we do to
> make the CPU recognized in strongbad?

Let me check with coretech folks as to why the ID is reused.

> ...and just for extra info, I believe strongbad actually has the
> slightly faster version of sc7180. It has a higher GPU/CPU speed. In
> some places I've heard it called sc7185, but in other places I've
> heard it called just sc7180 with a faster clock speed...

The only other variant of SC7180 I see in the document is SC7180P
which has 495 soc_id and is an APQ variant.

Thanks,
Sai