Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 4 May 2022 09:11:08 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Robin Murphy <robin.murphy@arm.com>
Cc:     Jan Stancek <jstancek@redhat.com>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        Christoph Hellwig <hch@infradead.org>,
        Ben Skeggs <bskeggs@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Alex Williamson <alex.williamson@redhat.com>,
        Eric Auger <eric.auger@redhat.com>,
        Liu Yi L <yi.l.liu@intel.com>,
        Jacob jun Pan <jacob.jun.pan@intel.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
        Christoph Hellwig <hch@lst.de>, bgoncalv@redhat.com
Subject: Re: [bug] NULL pointer deref after 3f6634d997db ("iommu: Use right
 way to retrieve iommu_ops")
Message-ID: <20220504121108.GB49344@nvidia.com>
References: <20220216025249.3459465-1-baolu.lu@linux.intel.com>
 <20220216025249.3459465-8-baolu.lu@linux.intel.com>
 <20220504075356.GA2361844@janakin.usersys.redhat.com>
 <8d6c30e0-dcf7-56f8-c44b-2d8bdb1dc04c@arm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8d6c30e0-dcf7-56f8-c44b-2d8bdb1dc04c@arm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HwD9STXaYtuwJtqyCYO2HBjDhLyNAIrGftpb3osmprCsRebhvbuFGCFl+mU0?=
 =?us-ascii?Q?WI9IHsERM65ggF9iqduy9mszRhF41TmE0BXoD+4hEYiqI827EvF8SuNVlCYX?=
 =?us-ascii?Q?O/x8fEF/EqJ2+0RKHW3oaX4kDEBtGtgCLkfvRpZoB1r0cR05lP80CNn3hL9F?=
 =?us-ascii?Q?9MgbICTapp6IBBWKHCoq/f8blUv9YjFtKLkeQtjiUZTvx8lZulQWciH4YwIz?=
 =?us-ascii?Q?lDd6SBT4cGGm0P4sQkivy3HI14a41JG54KGsQ7DeUhWs9WVlfjaQE6ntm3cw?=
 =?us-ascii?Q?cw1RBDnQgIV8Jr1sVT5Mpy8fbCo7uaw5//qjC1hHPLmcgsIehCA/4/L+eeVN?=
 =?us-ascii?Q?tFFBhc4ihFtuJqXeKacO0YvAeOp0pm/Nc+NToTcJLcTfjjJGud57NrZm6T0R?=
 =?us-ascii?Q?/ifoAM/SVPWuAAGaTv5kdylJfIFJ9HfdLqVWF2P3EjrKzAfu+FDhln7LTAtb?=
 =?us-ascii?Q?6VOYS8ZbQVVKMfFo46OtIacUC8aXSYtq7WdZoDXUxc6hjfNM4YyYj93j0tiL?=
 =?us-ascii?Q?J7aJM2Ra8AZEgk8A+eK3924Tj7q0EuObnyIhBU3m6rLiHw0HfoTg8wxK3Wla?=
 =?us-ascii?Q?s9R13xJpcBRfta3Ks7aVMoz2b6G/QSL59tIDnfdrffMAV15NyVowLzlzpzqA?=
 =?us-ascii?Q?YH2li+wAUQ1ooSOz2/GAE9hM5jdmdFfIcAj/6gyC7Hu2IXMSr8f8p9yHN1bX?=
 =?us-ascii?Q?ZfVlH41PgyKrd24JGodoAQQ/XLUu78M/+vdXGnexJKLxyKlBoXxzLCkSlJJO?=
 =?us-ascii?Q?OMDBVW0jCKnyqGNVkdxy3qYXZg/tepif0rfBCR5vFz2rdzdpCyYU/lLdo7Et?=
 =?us-ascii?Q?1sn9TYHhDG7cjf3YJrotygh0F8GTih3FXgbRvKeuWIFRHhiseQcNWLQymcf9?=
 =?us-ascii?Q?2Vtkokgc3b7h67iSYIt1EsS0C+iWfD/rkmyB7sC7WNHo+Fg6bIi4dsmlBh80?=
 =?us-ascii?Q?unfQ0qbptaZL40tsLn+QElOYTArxwi888omlJtyad6zCtae8JicDjCv7MC9K?=
 =?us-ascii?Q?0//v+0PX5YopzyiNoS5XaA51HhVy6Uzvl2XImQbXzNZlKxZdNquW20ME+tRM?=
 =?us-ascii?Q?OukDD7XTsZYRnmijP3NbdyF3Ygr9IXSYuWTssycPuLMQvvbbum3aOzRctd1i?=
 =?us-ascii?Q?GML4wf4tztKJOeR+1ZqZYo2ZAUxQCt2ZaxlTUX2U2kN8dToaxQ5rjuBraI7w?=
 =?us-ascii?Q?6g8OL72LioabLMvzM9KOVeBPvAVZZKF4V5/ne5NcH8mNPoO47WMX+cmK8sJw?=
 =?us-ascii?Q?W0k32sLGMAckjCqtIeAMlJ8jQKatzhuF51i3Xip76z94iRAvl2y79wOogk+E?=
 =?us-ascii?Q?7j/e0GmjC37sXZfkZXN5d6Vk82M45uI3I2wlx+yYqoAJdJNX2MFVUMhSZj9B?=
 =?us-ascii?Q?cE/Zl3TQ/mwGJNYn7K49wp+C3s6L8TW+VxVG2Vkx8gawbgL+s9ZLZ+yDh/ca?=
 =?us-ascii?Q?uumRm2VA23R+G56e6pBI95n+XLxny73DBhHGOiOL6v1TgAxnp26U6ILww91a?=
 =?us-ascii?Q?4rq2dXba+3FtUOua30BlWGvNsMOKjC4lL0y0hn/TcCznZfpjmoPdCk9Lecvh?=
 =?us-ascii?Q?ZJbEo2cNp/Qz6cYxxH07CFbwE6K2UXRySa9DNvZERs0lqS3GG+BQUrOFwloF?=
 =?us-ascii?Q?fvJkk9COqZWtcjfACaTcHofv+7hSzJThirrFuZCM/5qImo4BBX0/DZGF7o6c?=
 =?us-ascii?Q?AbPIBjzm8jPSAbYFeNWDFBPXEU90VNA+AOkyYU4C4oA1wl3Ns8xYZqzFy8Ov?=
 =?us-ascii?Q?vl9JvspwDA=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89a707f6-a0d8-47e9-c23b-08da2dc72cc8
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 12:11:10.1786
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zMLQ+vKP9cmxh8GUyK3aqZjieCohe86ZVJtRZpbNyc9RFNPMzA5zWpjkK4++wePT
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1874
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 04, 2022 at 12:14:07PM +0100, Robin Murphy wrote:
> On 2022-05-04 08:53, Jan Stancek wrote:
> [...]
> > Hi,
> > 
> > I'm getting panics after hunk above was applied in this patch
> > on ppc64le KVM guest, dev->iommu is NULL.
> 
> Oof, this can probably be hit with vfio-noiommu too, and by the look of
> things, `echo auto > /sys/kernel/iommu_groups/0/type` would likely blow
> up as well. Does the patch below work for you?
> 
> Thanks,
> Robin.
> 
> ----->8-----
> From abf0a38563bb2922a849e235d33d342170b5bc90 Mon Sep 17 00:00:00 2001
> Message-Id: <abf0a38563bb2922a849e235d33d342170b5bc90.1651662442.git.robin.murphy@arm.com>
> From: Robin Murphy <robin.murphy@arm.com>
> Date: Wed, 4 May 2022 11:53:20 +0100
> Subject: [PATCH] iommu: Make sysfs robust for non-API groups
> 
> Groups created by VFIO backends outside the core IOMMU API should never
> be passed directly into the API itself, however they still expose their
> standard sysfs attributes, so we can still stumble across them that way.
> Take care to consider those cases before jumping into our normal
> assumptions of a fully-initialised core API group.
> 
> Fixes: 3f6634d997db ("iommu: Use right way to retrieve iommu_ops")
> Reported-by: Jan Stancek <jstancek@redhat.com>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
>  drivers/iommu/iommu.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason