Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 4 May 2022 08:51:35 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Joerg Roedel <joro@8bytes.org>
Cc:     Qian Cai <quic_qiancai@quicinc.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Liu Yi L <yi.l.liu@intel.com>,
        iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v8 00/11] Fix BUG_ON in vfio_iommu_group_notifier()
Message-ID: <20220504115135.GA49344@nvidia.com>
References: <20220418005000.897664-1-baolu.lu@linux.intel.com>
 <20220502161204.GA22@qian>
 <YnI8Xy54M3XQpS0T@8bytes.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YnI8Xy54M3XQpS0T@8bytes.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gkei3kZ8qN2IDM37OJsmotG3ccUta23fbQr8brA50SQuMRvmziDFYq+ugsl/?=
 =?us-ascii?Q?jTr5yOOb7VvAQ+5Vmw8nZTL+TuR2u+zALkE2RmDROvG0O1X6CUIwwXF5rWNt?=
 =?us-ascii?Q?LIym10B/q12eT1vi6RqHgBBNy30tYhrvajmE68BYGlXVUfqQYgNOnjLE1lP/?=
 =?us-ascii?Q?eHjkB90kDcha5Ye/N0HNr/P8aK6FVvUqni3avpF9A9gNuoVPI0fjs8IjThQa?=
 =?us-ascii?Q?Ro1ON8yeE4aqcphT5MiRK3OmeVTW2PZ4klbjbpf3jboMTCyYWtSeOzcu4Fj4?=
 =?us-ascii?Q?XuHWOS1/R0raf+0LKhvrteICMtIeh7jyrk1FnSoRX/aieXLYqvkS4gzl2J6Z?=
 =?us-ascii?Q?iYgzwa2kAvf1TRzVtf1lfYbYCN/kSc7stJtUAAUsYPaSqdVM7/vbJHRFxXej?=
 =?us-ascii?Q?Xa6AvPguELTN2RH5CDOUW9j9G1u0cDP09WQn84yXzBfZJWtSE2m3OuFUSkMn?=
 =?us-ascii?Q?/aI8f51Zd2DYzp2S5Bp9ICMd0o0+uTB8z3MugJRKPfBCHQ8Nf0XHtZxzpLsE?=
 =?us-ascii?Q?QconyfguOlmSy+rGR3+LwQlPACQHriIbelmxgd9oR0IPBylbSMosbT0sZ0FX?=
 =?us-ascii?Q?Pipw7V4pW86ZOiVU0hO/T7MO2zj2K8zo5vCIXzsS07D4K8H0CDgPgCM7C0k5?=
 =?us-ascii?Q?US88tAIZj+3hh40ReeM+l9ocMB1JTbUTl6ie7zYmhF7aNynUZVVqZMTp269l?=
 =?us-ascii?Q?ECkM+JSfQYWu+eXvCcD6++3JiozTrpVAryFJt11+VClvcQomglOalMsMrYc9?=
 =?us-ascii?Q?6zbvRxFJsAdHqnycIqL6pYntbGMgLiYesa4NzrG4fJD+8ZF8COdxZD79zSxD?=
 =?us-ascii?Q?UhxHAlWxzNksktyHdtIv2DLSYgEIgud/OfSRhoRoWZ9jdMyLFGQEs20Ekg1t?=
 =?us-ascii?Q?JfjJyExTORoUBdO6qsKmVAommexiLpVJhGm62yh/T3gJAi2R1RWtuFmcyM0f?=
 =?us-ascii?Q?qLvLUsXb1SaHSIyanrMRas8wSo4SUcWx0f7/kfCQ6Y/YUcbpi4aNp9NVvEqn?=
 =?us-ascii?Q?yA7sl6dJQYHMSK/pLFiOfEjIVdPZYajmugJ+lgWmf+InJ7Gg1X9u/jJsduqH?=
 =?us-ascii?Q?c4aQBVV+nBlBUWR0SOzVdP0ZbnI2ujnci7LZhm55dLV8sHGGZE9xGLug0QJp?=
 =?us-ascii?Q?VO7RAXnh8SRGFr1YKlPgbXrhgQMinQBR017WMO9cS236tlZ+ylYsgYr9Qmy3?=
 =?us-ascii?Q?V+kJnVR3D22kEezw1OeDyPk9EIWfpwszYVbPgSNFf39wgg6+XFoHOVoYZbDJ?=
 =?us-ascii?Q?lSee/jSeCq0W5zlseyp5lw+byH2GrRmi22CyZofUphrkKFAV+nD0b1CJxZy/?=
 =?us-ascii?Q?fr4oJvWwNGvYnTVIPcFW4DVpQtJU/s511Yy6hSUyHzC7fjTYmKVf1c3om10i?=
 =?us-ascii?Q?Ded8cOR0HYJaxdXbeJVVg29YpH5W7gv2GQ3xc5tupdRIZlJ5gJvnNdCt0JjS?=
 =?us-ascii?Q?PiYmpoZYaQ4Fxf1MxO/uBrCvq6n3+Ne97ngasZIq5/dFZh1DujrKVcUu3Z6u?=
 =?us-ascii?Q?hfEP0hvN1qhLq1fLmEJxi5kCM89pkyz8CH26QNaKdG9iDC2vYnMzl42OLX7L?=
 =?us-ascii?Q?QiNEwpigF3Mpqh39kY4+g/Ad19iyZZW6Tm+s/1VOxER9wmvyIDjIoBh7OQ0z?=
 =?us-ascii?Q?1rU2RNY72Equez86jpnxPaJn2tpR9kGVEh3EbeiexqwrfV4k4ywfnbY6iW6D?=
 =?us-ascii?Q?xCtRQ6GKHwbzqo4fgetovEal0oiVn2gxiKhHNJE7r5A6axSNrh7dUebKt9RG?=
 =?us-ascii?Q?a8jnZ78DHg=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9372ac6b-60b3-4b32-86a5-08da2dc4711b
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 11:51:36.8783
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5dqofnBuEb0037Wja4QUboUy1/F2LCg560pI5DtzjvnFG0K7QMw3kTmPRxMD4IO0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6429
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 04, 2022 at 10:42:07AM +0200, Joerg Roedel wrote:
> On Mon, May 02, 2022 at 12:12:04PM -0400, Qian Cai wrote:
> > Reverting this series fixed an user-after-free while doing SR-IOV.
> > 
> >  BUG: KASAN: use-after-free in __lock_acquire
>
> Hrm, okay. I am going exclude this series from my next branch for now
> until this has been sorted out.

This is going to blow up everything going on in vfio right now, let's
not do something so drastic please.

There is already a patch to fix it, lets wait for it to get sorted
out.

Nicolin and Eric have been testing with this series on ARM for a long
time now, it is not like it is completely broken.

Thanks,
Jason