Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp989394iob; Wed, 4 May 2022 12:08:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdI699LUjnHNpL3dWTRXMEU/Lk+r/OysY/NhZJXV3ThzFDYuxr+VoYwwFL9rgKNpm5ujKH X-Received: by 2002:a05:6402:350a:b0:423:e41e:75cb with SMTP id b10-20020a056402350a00b00423e41e75cbmr24823589edd.178.1651691296983; Wed, 04 May 2022 12:08:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651691296; cv=none; d=google.com; s=arc-20160816; b=o0BxYbSqfLryVLTRS98E3RZYPT3KW3iWE76NHELM2PhMNfGjCROIoRgFPmRBxTKUQN g82ebNJ3mLh0NF+CLHYlU8XIf8H1wxFlBORzh941GPc9s5dclUvzMxyL+jyHPp4HCm77 mX08ab9ilknbmke84KXlIgcnmNX8jzSafFeFOYbjw71fkyz8f/I4fWXPDtxWmm/YaLwy ekbduyR8Wqn06rMMIhe2qoqnPQGU3D3vW6RJ0mu7tUYkmlYAPdShKHJ8zhktbmspEbm2 d0cleA0lVbFUBzZQttJ+x46VE9ZwRBtq4l5qo9bccNCqDii6EBCO8SdiyusXu88DAkI8 5Sag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DyX7wjUPDMhbAq2AZNXveTl4oi5yb+hEwgewLeuy2qU=; b=qwhtKrsRenjUFIE5ns+5mqF5ry9Kg6+Y1D4//JPPkTrGWLcGumi5ZQCB7nJbn+8GRR As8VosTknHWERWBtC3vGbZlfn4JBnsoHyomfQm2nMeKDCGphmsbp5IRF3VRtJ8TMHWB/ W4ElwSW/7TButY4nZo8TDuF7RtTRqg83+JwapqyETVPCli9fFivPgJQx16p7JAbiyydt WBv0rzeo2t8935dlYAWTbsXNYqQOYY9i/xesHk/uq2F/X9ATMx4s6br//KkigTRHd5Se xoizFDEi7mtWqfUHRbecA9fkdVIuZBKJIi7gZ8fMxgEjPiCje5hwGTtdtdMLmiwSeakB Bh8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GXFBAVhc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wc7-20020a170907124700b006e8bf5ed3e9si15512049ejb.928.2022.05.04.12.07.52; Wed, 04 May 2022 12:08:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GXFBAVhc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358907AbiEDRjM (ORCPT + 99 others); Wed, 4 May 2022 13:39:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357350AbiEDRKJ (ORCPT ); Wed, 4 May 2022 13:10:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A23B94AE0C; Wed, 4 May 2022 09:57:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 666E7618E5; Wed, 4 May 2022 16:57:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF895C385A5; Wed, 4 May 2022 16:57:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651683437; bh=QaSWXVTa1jFCnz66oF5QYBpqSJ/mOHkh5HeNfDbiWT4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GXFBAVhcuIxXdUwntsO8ACEFV65W4a9mHsIJsPjMcGI+qkIJrga/FCtOwAbRZZGjd mbUyktb2YGN8D+3NmSqGBhwl37QvaQsbf5LiCkMb6xTf1NPDK4rWdhh6n2UFg5AOpq MX2r+/VJX5Bhj9tY/prsxymgQCLpiU0PVYW1Grcs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jian Shen , Guangbin Huang , "David S. Miller" , Sasha Levin Subject: [PATCH 5.17 117/225] net: hns3: add validity check for message data length Date: Wed, 4 May 2022 18:45:55 +0200 Message-Id: <20220504153120.969847666@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220504153110.096069935@linuxfoundation.org> References: <20220504153110.096069935@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jian Shen [ Upstream commit 7d413735cb18ff73aaba3457b16b08332e8d3cc4 ] Add validity check for message data length in function hclge_send_mbx_msg(), avoid unexpected overflow. Fixes: dde1a86e93ca ("net: hns3: Add mailbox support to PF driver") Signed-off-by: Jian Shen Signed-off-by: Guangbin Huang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c index 36cbafc5f944..53f939923c28 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c @@ -94,6 +94,13 @@ static int hclge_send_mbx_msg(struct hclge_vport *vport, u8 *msg, u16 msg_len, enum hclge_comm_cmd_status status; struct hclge_desc desc; + if (msg_len > HCLGE_MBX_MAX_MSG_SIZE) { + dev_err(&hdev->pdev->dev, + "msg data length(=%u) exceeds maximum(=%u)\n", + msg_len, HCLGE_MBX_MAX_MSG_SIZE); + return -EMSGSIZE; + } + resp_pf_to_vf = (struct hclge_mbx_pf_to_vf_cmd *)desc.data; hclge_cmd_setup_basic_desc(&desc, HCLGEVF_OPC_MBX_PF_TO_VF, false); -- 2.35.1