Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1034754iob; Wed, 4 May 2022 13:11:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJySNzLNdeRlnzCbJjrxc6EvlKknxcwFHSRgEIRt6nvmlNZhx1CHPghpa31mkW3HIJdsJZsZ X-Received: by 2002:a17:902:b682:b0:15d:29:9820 with SMTP id c2-20020a170902b68200b0015d00299820mr23062053pls.134.1651695090370; Wed, 04 May 2022 13:11:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651695090; cv=none; d=google.com; s=arc-20160816; b=KMRnUsNIH2uiul2LrZGZ6Ba38maPowmK8ehHJ1nCT7S4HvPwHS9dBpyBGn6GqXXTUM f3aEHTmCC4uUDgQOqBHDdj8nyCUu7Nn1S/g3mrgsVBmFQtyjHngryPB3Niu1wM4Bs25u Sy6CXaLcr3VGfgJlZrT+SfnLaXcHa5xIA96oa5M8JfWqRLLHFsL4IFc8TOoBGj30AEeY 1FrV1H6Siz32apTyD++tpK44WxJ5qdcg8+5w/hjPKsnAeEcgcJINmkXC7QiJMKqI9UwY D+rBIh696Ur9bJ70Y7tK7lNq6A1NXr1bHTaL4Q4jKKABDMfOdLb2y5jH+ywGlts1iF/1 efVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=uSCjkMj4dYFheq+/FSKGiwDai6D+f5d7WfzOKA5SOcI=; b=vdOvVVXnCjQHJUvQZDH0NoAhFDRWyGFrXoqt1Vmnjigbsz1KzE5hQhYo2LbFgHLAFB NWZGXPRzL4nfK01d8wXC600G+0D2aTMq6xQXWOHj8CfeoWoNp8bqPXyQzcqNJOTPKbd5 BWjlP2KUVR0x3T/SUSyiadUpcxz15BhI58ZziDJ64bYK5h2vA3HSQsSBuvdPs24H41hR r6JBXiTFzybcdm9ABHRq8hPTOpaHRZRUoP79SK4iPY/SeLlb0tk4OmJCFyKpnq19CNYr PXugHlIERXL36eea7XBR/KX9mRS9dMjqq689T5P4Pq38LJ6RyyUvbd3q6N/Tm6oPBmbX Nprg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baikalelectronics.ru header.s=mail header.b=RnMux7JW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u8-20020a170902bf4800b0015eb08a71a7si6309975pls.327.2022.05.04.13.11.15; Wed, 04 May 2022 13:11:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baikalelectronics.ru header.s=mail header.b=RnMux7JW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242443AbiECUO5 (ORCPT + 99 others); Tue, 3 May 2022 16:14:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242346AbiECUN7 (ORCPT ); Tue, 3 May 2022 16:13:59 -0400 Received: from mail.baikalelectronics.ru (mail.baikalelectronics.com [87.245.175.226]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2C40E1031; Tue, 3 May 2022 13:10:16 -0700 (PDT) Received: from mail.baikalelectronics.ru (unknown [192.168.51.25]) by mail.baikalelectronics.ru (Postfix) with ESMTP id DE794BC4; Tue, 3 May 2022 23:10:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.baikalelectronics.ru DE794BC4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baikalelectronics.ru; s=mail; t=1651608649; bh=uSCjkMj4dYFheq+/FSKGiwDai6D+f5d7WfzOKA5SOcI=; h=From:To:CC:Subject:Date:In-Reply-To:References:From; b=RnMux7JW7Wut0lQXqcFdmwDPAUAUhSLlms5pL4hm/jK2VaoYPx/ymSeiDM3td05LY s7CO1RMWnIdGTZA14lRL/+ynORBxkWWLU2CRxxA8C4ItVsHmGx9Di5xawr+XtevCLv Fvl47otQAj4vrp/cLrG2qw7KamBUZI5VKxb1vlEQ= Received: from localhost (192.168.53.207) by mail (192.168.51.25) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 3 May 2022 23:10:15 +0300 From: Serge Semin To: Damien Le Moal , Hans de Goede , Jens Axboe CC: Serge Semin , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Rob Herring , , , Subject: [PATCH v2 16/23] ata: ahci: Convert __ahci_port_base to accepting hpriv as arguments Date: Tue, 3 May 2022 23:09:31 +0300 Message-ID: <20220503200938.18027-17-Sergey.Semin@baikalelectronics.ru> In-Reply-To: <20220503200938.18027-1-Sergey.Semin@baikalelectronics.ru> References: <20220503200938.18027-1-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It may get required to retrieve the port-base address even before the ata_host instance is initialized and activated, for instance in the ahci_save_initial_config() method which we about to update (consider this modification as a preparation for that one). Seeing the __ahci_port_base() function isn't used much it's the best candidate to provide the required functionality. So let's convert it to accepting the ahci_host_priv structure pointer. Signed-off-by: Serge Semin --- drivers/ata/ahci.c | 2 +- drivers/ata/ahci.h | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 9bc8fa77e92f..d14d74649e0e 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -689,7 +689,7 @@ static void ahci_pci_init_controller(struct ata_host *host) mv = 2; else mv = 4; - port_mmio = __ahci_port_base(host, mv); + port_mmio = __ahci_port_base(hpriv, mv); writel(0, port_mmio + PORT_IRQ_MASK); diff --git a/drivers/ata/ahci.h b/drivers/ata/ahci.h index 0e66446a5883..8b9826533ae5 100644 --- a/drivers/ata/ahci.h +++ b/drivers/ata/ahci.h @@ -431,10 +431,9 @@ int ahci_host_activate(struct ata_host *host, struct scsi_host_template *sht); void ahci_error_handler(struct ata_port *ap); u32 ahci_handle_port_intr(struct ata_host *host, u32 irq_masked); -static inline void __iomem *__ahci_port_base(struct ata_host *host, +static inline void __iomem *__ahci_port_base(struct ahci_host_priv *hpriv, unsigned int port_no) { - struct ahci_host_priv *hpriv = host->private_data; void __iomem *mmio = hpriv->mmio; return mmio + 0x100 + (port_no * 0x80); @@ -442,7 +441,9 @@ static inline void __iomem *__ahci_port_base(struct ata_host *host, static inline void __iomem *ahci_port_base(struct ata_port *ap) { - return __ahci_port_base(ap->host, ap->port_no); + struct ahci_host_priv *hpriv = ap->host->private_data; + + return __ahci_port_base(hpriv, ap->port_no); } static inline int ahci_nr_ports(u32 cap) -- 2.35.1