Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1083352iob; Wed, 4 May 2022 14:19:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzRI9RLdExf+4A6HO2UW/K8AERFLRigQyARKq1fVCbzFHUQLSZzhWi322IU3XkuobZtjFRZ X-Received: by 2002:a17:90b:4c88:b0:1dc:60c2:25b2 with SMTP id my8-20020a17090b4c8800b001dc60c225b2mr1765064pjb.133.1651699169152; Wed, 04 May 2022 14:19:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651699169; cv=none; d=google.com; s=arc-20160816; b=lCTlnULsiTao4zwWRJqhnC9apeshOxqgisfONslYg6s/U9XL6YXar/jM8dohKGAGXm qyHkWKbmRyRpMVSd1iAxza4Sy5Ge7zP5MR4n2+64uVvjh/TNDRcMhoM6MX1U9J/LX0Rg e/c6P1apYSnFvC36550Ecv/UPbMiNTEFiiR2Yi3pabFp1GKDX0uXhBdfqt8bxQfryfwL 5LQcRmwEOjRZLpkyrUZXcXhh/yW8NtoOsrtFIdQ9lmTspy0TxOerk1JVSLRQ0zE+hdiV 8DljL63cN+oDUzphpC1PQEEUNzSrk+xYkfKpQnwEixT7CXN7gSOFd8g0+1U1Hv+Sjtdz WyLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Xl/pKIUZuR+JiscXe+pokb1a3QJoLYKiFmIdj/hqZps=; b=NMinkbUHnBPmNay7u1qMX05Iv0HiPPzMPDeyKFfOJLnn8434iHUw0U+LxUcFcqa6f9 ImjNzo6Qs/EUEVdsgDXMtfvUd9L4kBABzh/o+lCxAMy7YeaWxVIwTu3g9I7uTAiLT09C 9xentpJJTQTxnq7wUPRJLp0895EhlilGql8pIt/Rnf5uwQ6WGEYJJ0xPI77InpRhE50o W/bEc9jk0kc+9N3zq3OpLafrkMiFs772EtGtSR1A02CUY/EuZ9u5Pob7pqeh4l1Y1VUT pURrliSTXb2fKO3AUEMmROoGvUjHeqVI86g78hAL7WgtAoRrEgoxdXr5Ls/e4t3i0xIp Scpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Fdf3jKj5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z16-20020a62d110000000b0050a4154760fsi19222567pfg.99.2022.05.04.14.19.13; Wed, 04 May 2022 14:19:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Fdf3jKj5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351043AbiEDTEv (ORCPT + 99 others); Wed, 4 May 2022 15:04:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343627AbiEDTEu (ORCPT ); Wed, 4 May 2022 15:04:50 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FAF02DD66 for ; Wed, 4 May 2022 12:01:13 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id cq17-20020a17090af99100b001dc0386cd8fso2017715pjb.5 for ; Wed, 04 May 2022 12:01:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Xl/pKIUZuR+JiscXe+pokb1a3QJoLYKiFmIdj/hqZps=; b=Fdf3jKj5u00OGGeg7avF7vYubAJKBvoqvMqq/zRNDR9WlcdyLkzOp1nDU9WN6gkgjy jIyHnFJ5Kr1NXA89d1Z387Tey1dgGMGaFWw2Fb9X5g1pT7Pry+RHu1JhmTxqyiibm313 87sB2sajTTycX2U8j10tK5Cu7zgIg5I5SZWKg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Xl/pKIUZuR+JiscXe+pokb1a3QJoLYKiFmIdj/hqZps=; b=T71ozTNqdnnnQ4ZdOhNljv7OIzngLXYrwCApfSGa/x6IaD1L+e+HowPHNBLJ1qbLOt q/2c1TbonWAYeYvkykrMSnGDzX/qh/62CY7Yz4KEWNHdo58sKKkDi3vZe/0o7HffTAkI Onelz6jut8HBXA5q0r9HBdG5aNUJHRAoi0qM8TcN1q+u9UHnQxoGbPcSCGsvI18srZ7+ ZhF+XuhE2QxSUpZuolUEX233T1zRLQa4p98ckIpmZMKR63o2Qqy8WM3UWSPjbgaWsJV8 OKnwJ0w07KG66HRzKon5fUV1X+rdBnWSNS2VwPq/ckvlARh7SvErnRiCOSgzn+/XRzDa pDSw== X-Gm-Message-State: AOAM533u9CUoT0EEgHGRjd1/2LsMxpjNTidg8rKnbHSOhvY9qTVhnIzm WU+Z1G/R4hgD5ug/u3no0zvu5g== X-Received: by 2002:a17:903:31d1:b0:159:804:e852 with SMTP id v17-20020a17090331d100b001590804e852mr22992694ple.19.1651690872777; Wed, 04 May 2022 12:01:12 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id ij21-20020a17090af81500b001cd4989feecsm3625006pjb.56.2022.05.04.12.01.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 May 2022 12:01:12 -0700 (PDT) Date: Wed, 4 May 2022 12:01:11 -0700 From: Kees Cook To: Catalin Marinas Cc: Mark Rutland , linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, alex.popov@linux.com, linux-kernel@vger.kernel.org, luto@kernel.org, will@kernel.org Subject: Re: [PATCH v2 01/13] arm64: stackleak: fix current_top_of_stack() Message-ID: <202205041200.147A737@keescook> References: <20220427173128.2603085-1-mark.rutland@arm.com> <20220427173128.2603085-2-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 04, 2022 at 05:41:32PM +0100, Catalin Marinas wrote: > On Wed, Apr 27, 2022 at 06:31:16PM +0100, Mark Rutland wrote: > > [...] > > Fixes: 0b3e336601b82c6a ("arm64: Add support for STACKLEAK gcc plugin") > > Signed-off-by: Mark Rutland > > Cc: Alexander Popov > > Cc: Andrew Morton > > Cc: Andy Lutomirski > > Cc: Catalin Marinas > > Cc: Kees Cook > > Cc: Will Deacon > > I thought this was queued already but I couldn't find it in -next. So: > > Acked-by: Catalin Marinas Should this patch go via the arm64 tree for -rc6, or should I just carry it as part of the overall stackleak series? -- Kees Cook