Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760230AbXEJI6K (ORCPT ); Thu, 10 May 2007 04:58:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756672AbXEJI55 (ORCPT ); Thu, 10 May 2007 04:57:57 -0400 Received: from opal.biophys.uni-duesseldorf.de ([134.99.176.7]:51261 "EHLO opal.biophys.uni-duesseldorf.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756017AbXEJI55 (ORCPT ); Thu, 10 May 2007 04:57:57 -0400 Date: Thu, 10 May 2007 10:57:35 +0200 (CEST) From: Michael Schmitz To: Russell King cc: Linux Kernel List , Timur Tabi , Michael Schmitz Subject: Re: select is evil: another reason In-Reply-To: <20070509091358.GA29994@flint.arm.linux.org.uk> Message-ID: References: <20070509091358.GA29994@flint.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1106 Lines: 27 On Wed, 9 May 2007, Russell King wrote: > drivers/net/Kconfig:2279:warning: 'select' used by config symbol 'UCC_GETH' refers to undefined symbol 'UCC_FAST' > drivers/input/keyboard/Kconfig:170:warning: 'select' used by config symbol 'KEYBOARD_ATARI' refers to undefined symbol 'ATARI_KBD_CORE' > drivers/input/mouse/Kconfig:161:warning: 'select' used by config symbol 'MOUSE_ATARI' refers to undefined symbol 'ATARI_KBD_CORE' > > The select statements are in generic Kconfig files. The symbols they > are selecting are in arch-private Kconfig files. Don't do that - > those symbols are undefined for other architectures. > > If you must do that then do: > > config ATARI_KBD_CORE > bool > + default y if KEYBOARD_ATARI || MOUSE_ATARI > > in our m68k Kconfig file, and in arch/powerpc/sysdev/qe_lib/Kconfig: Will fix. Thanks for reporting this. Michael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/