Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1138259iob; Wed, 4 May 2022 15:43:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/yj4TH0TwsnXwKvmkoOnxM+bsD1evRaqeE4P0tlgWuR/OepDlyAOJ/K8Acl0qUNSX5PbZ X-Received: by 2002:a17:907:72ce:b0:6f4:5a57:320c with SMTP id du14-20020a17090772ce00b006f45a57320cmr15190574ejc.75.1651704207767; Wed, 04 May 2022 15:43:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651704207; cv=none; d=google.com; s=arc-20160816; b=j2qeuQQsd6x4UD101Ibozx90uVMe6KqqODbiteTOF66+7HPtr8VbYZca7brj170dF0 AGz/sLHFURrmC/gQxLnLq8AKdMmzbwWVYQERhcjtUycAcMIMg1j9oHjpRWKEhwJsLRoZ 1g6Nrz6w4/+fKBp4zITt9gIo7nU7kVIDgyNVOalncJVHywFlqOEVeA3joYTHskXBfNtk KwRVH3xO5CbSVRxvUUT0wz5/GW+fp3NDxkYVAlPWQaMNer+pB1Ew3H+du8F1Hd63LH6D GKSjOvBVgLLiwl6HUVbQuX916n5JdcyA8qxpwby6ZmspukilVXEerY/lSAN1Bz7y7rWW 7oFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Ao8ZEGPKjg9PeGeUFWYsTNiylR+nJfO4rQyxpnkUZQg=; b=wKIH5dtr94UM35LL3C1PmND1pvK/Bz3f3118lzoW9hPbOYJ4gl7gwUWxUXWjWr8naC 3zeUli26nvvxBXLuv2Jpf1ohV4tCzrE9Rh8XuI6YInEacU4CfJnx1DuGS+QxSIlvvU/0 8+Wa9ltIQh72YdJJLYNkEZj0OpNlDB2SDj3oreZ/dEG5mNjwc0fglBtWqGc1NL0ItG8t naxewe2G/yrucvuY+YaceyDyrCTslNr+TeQcGMMtl2gu2TfCdK+gmUv3nippx0k6Yaw9 Cs/Zu87NQBv7VL2sSQ8Q3GAynFYulNHMvJWfafAGV46uBGeXLhpihzxjTNRsQH147X7T zb5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=YBPic7mb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fy12-20020a1709069f0c00b006e8c13b56e5si83036ejc.804.2022.05.04.15.43.04; Wed, 04 May 2022 15:43:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=YBPic7mb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359307AbiEDRjy (ORCPT + 99 others); Wed, 4 May 2022 13:39:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356801AbiEDRJo (ORCPT ); Wed, 4 May 2022 13:09:44 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1F271E3C5; Wed, 4 May 2022 09:55:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8B4A4B82552; Wed, 4 May 2022 16:55:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BCF1C385A4; Wed, 4 May 2022 16:55:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651683339; bh=c8j9sThsQt1nXao1ztdPXjEAbh1QS7CoMekdvJqvNuM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YBPic7mbUopE2qH2aI3oC/Fa5aNCHif9yfD7huv78xA80U77JYWf/g6WJLcgG3wbd dMXyngAMFYsjoOdimkamZTwZez6EepfTx4d9XBaPkzCPPgj076uBxxrzzveQZPd27X Qzm5iLpOQ4yOBFUIZ7BMiDnkC7ICtYm/eAafmopw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tom Rix , Stable@vger.kernel.org, Jonathan Cameron Subject: [PATCH 5.17 014/225] iio: scd4x: check return of scd4x_write_and_fetch Date: Wed, 4 May 2022 18:44:12 +0200 Message-Id: <20220504153111.533116882@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220504153110.096069935@linuxfoundation.org> References: <20220504153110.096069935@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tom Rix commit f50232193e61cf89a73130b5e843fef30763c428 upstream. Clang static analysis reports this problem scd4x.c:474:10: warning: The left operand of '==' is a garbage value if (val == 0xff) { ~~~ ^ val is only set from a successful call to scd4x_write_and_fetch() So check it's return. Fixes: 49d22b695cbb ("drivers: iio: chemical: Add support for Sensirion SCD4x CO2 sensor") Signed-off-by: Tom Rix Link: https://lore.kernel.org/r/20220301025223.223223-1-trix@redhat.com Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/chemical/scd4x.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/iio/chemical/scd4x.c b/drivers/iio/chemical/scd4x.c index 20d4e7584e92..37143b5526ee 100644 --- a/drivers/iio/chemical/scd4x.c +++ b/drivers/iio/chemical/scd4x.c @@ -471,12 +471,15 @@ static ssize_t calibration_forced_value_store(struct device *dev, ret = scd4x_write_and_fetch(state, CMD_FRC, arg, &val, sizeof(val)); mutex_unlock(&state->lock); + if (ret) + return ret; + if (val == 0xff) { dev_err(dev, "forced calibration has failed"); return -EINVAL; } - return ret ?: len; + return len; } static IIO_DEVICE_ATTR_RW(calibration_auto_enable, 0); -- 2.36.0