Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1147237iob; Wed, 4 May 2022 15:56:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJzX/G/uwaJ3sgw7ZrUdUE9GxHQE4W5iuac2FJ+i6KUHzCGjxUXZclV+lYTQ+zqGZvyXLJ X-Received: by 2002:a17:907:6d07:b0:6f3:d077:813a with SMTP id sa7-20020a1709076d0700b006f3d077813amr23278994ejc.138.1651705012598; Wed, 04 May 2022 15:56:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651705012; cv=none; d=google.com; s=arc-20160816; b=osvZXi4DiB5tXNuCzOsoeCvOsPk9gvHMVvNGw3y7Max3Y8qERj1l4fpMp82ZvSUHx0 dnIPNvGZKs/z2VPuGlGmY/41kZ8772PJZ1Q2WT6X/5xJ1UrHyFU2YrgDcw2yQAZhnJzU DkEfilGvC5T5vyJwOuYMZlOWHDnrm5Ru+wqOwhAvCceG1l7IaGZJr7lNQJVm8Ze8t+fK oQDkU49xsktshfAbX1bzp+pBtv9TXCoKSIe8PDsqnKSKt/6raVW3GitZLdfL4QY4c0IJ kRjs1ZRvxcVP+KtNNND7ucdqlgOhP2LNsBEfg661Qz5iev7/gO3wBu5iv0xiU+/9Pz7F BrFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Qh8XP9Pde76xGtO5T98+RqU8nr8ippfI79ZUWHPHS0c=; b=zmyzvlfQy7KaIzlwzSJPa6gGNTQve/fgl0zROIyTiv5GBnq01qIkBOIaMUr5QfRrIa 4Tz4KsVHJTfMX4WVysHpSgSS/bsDiYn6YrMUtiW/Cvv3fE4blTBKk3hUni3Dt+zKJhhy krZois5ZEBpHhM7jYtYsSwX2WkmnlzEfnrxEZIH94IkuU6iH/YeFKTCYqcJqvS2670oJ jx3wW/t1UjhA7tuRsakv/nMjgmyzJx/NRUe+kqbeqrVHL9LtjMMNp11iyJT4eBNCDzEn 2aytjT6NIQsqx5yXzTiLCwZw8L9IbW7h9EjJjtdOZQRH7Pe6pLCJZZPx8n2DYhO63h2I LP8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qRLt3g2p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v18-20020a1709064e9200b006efe2472cb1si150037eju.767.2022.05.04.15.56.29; Wed, 04 May 2022 15:56:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qRLt3g2p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357880AbiEDRg6 (ORCPT + 99 others); Wed, 4 May 2022 13:36:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356944AbiEDRJu (ORCPT ); Wed, 4 May 2022 13:09:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A5EF4739E; Wed, 4 May 2022 09:56:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E9676616B8; Wed, 4 May 2022 16:56:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45116C385A5; Wed, 4 May 2022 16:56:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651683396; bh=psSx/hJhNkKZta6oyg74GJXmr7g/fVmHB0hUjFTOrEs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qRLt3g2pYlLuFxs2/LxC/W0ZWOaBUAQT6AqslWEcRcHDJwiBTzqU4JzXynLAwTP8e m2G77Z90y45lOeku3EgTRz4hs7Cc0XjqJNhxHfxEyngfzhHeU/IAUCinkCKxfoWmrU p5P7uSSi3cOYFU0QyFvro1orpOwOmOqVNXILwb5k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Vinod Koul , Sasha Levin Subject: [PATCH 5.17 081/225] phy: ti: omap-usb2: Fix error handling in omap_usb2_enable_clocks Date: Wed, 4 May 2022 18:45:19 +0200 Message-Id: <20220504153118.397717447@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220504153110.096069935@linuxfoundation.org> References: <20220504153110.096069935@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit 3588060befff75ff39fab7122b94c6fb3148fcda ] The corresponding API for clk_prepare_enable is clk_disable_unprepare. Make sure that the clock is unprepared on exit by changing clk_disable to clk_disable_unprepare. Fixes: ed31ee7cf1fe ("phy: ti: usb2: Fix logic on -EPROBE_DEFER") Signed-off-by: Miaoqian Lin Link: https://lore.kernel.org/r/20220318105748.19532-1-linmq006@gmail.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/phy/ti/phy-omap-usb2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/ti/phy-omap-usb2.c b/drivers/phy/ti/phy-omap-usb2.c index 3a505fe5715a..31a775877f6e 100644 --- a/drivers/phy/ti/phy-omap-usb2.c +++ b/drivers/phy/ti/phy-omap-usb2.c @@ -215,7 +215,7 @@ static int omap_usb2_enable_clocks(struct omap_usb *phy) return 0; err1: - clk_disable(phy->wkupclk); + clk_disable_unprepare(phy->wkupclk); err0: return ret; -- 2.35.1