Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220504153814.11108-1-markuss.broks@gmail.com> <20220504153814.11108-3-markuss.broks@gmail.com>
In-Reply-To: <20220504153814.11108-3-markuss.broks@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 4 May 2022 17:51:05 +0200
Message-ID: <CAHp75VdfaP4ypVHdMZ=TgMVmd1ioak-0AUA9k+Z6wNAr458+ag@mail.gmail.com>
Subject: Re: [PATCH RESEND v6 (corrected v2) 2/2] leds: ktd2692: Make
 aux-gpios optional
To:     Markuss Broks <markuss.broks@gmail.com>
Cc:     Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Linux LED Subsystem <linux-leds@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, May 4, 2022 at 5:38 PM Markuss Broks <markuss.broks@gmail.com> wrote:
>
> Make the AUX pin optional, since it isn't a core part of functionality,
> and the device is designed to be operational with only one CTRL pin.
>
> Also pick up maintenance for the LED driver and the yaml bindings.


The MAINTAINERS update seems like it deserves a separate patch.
But most importantly, you need to add a patch that converts the error
reporting to use dev_err_probe(). Currently code has that issue, i.e.
it will print the error message as many times as probe was deferred
due to unreadiness of GPIO.

Something like this

>                 dev_err(dev, "cannot get aux-gpios %d\n", ret);
>                 return ret;

===>

  return dev_err_probe(dev, ret, "cannot get aux-gpios\n");

with a Fixes tag added.

-- 
With Best Regards,
Andy Shevchenko