Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1157327iob; Wed, 4 May 2022 16:10:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYS2guog0cJnZifHWkrnjfQ8o/nLC8A0Jpyvqao/FgnZoI+k6D2aH396fJinwVNZkxEGi/ X-Received: by 2002:a17:906:d555:b0:6db:148e:5cc with SMTP id cr21-20020a170906d55500b006db148e05ccmr22501729ejc.63.1651705821704; Wed, 04 May 2022 16:10:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651705821; cv=none; d=google.com; s=arc-20160816; b=ZtGUoF3vwLeBmHbusig6lZWNwhxk6GHPgw9fevDKLMggXJzwpJYcsXbynQzQIHL2rb jVkvzOS24vJkaN/DgOX9cDRzmYznN8VfgMxLTmVJJBpyoM177eo2QHrJZ6uItUB0g+Ae VzhMFKkuGqux6lGsaIS81aY6vZKOrp/ZxeifGdDcLx8WU0a7e5UfXGfs4QmkTIVV++v9 //Jm/mpV1lH1TwE91gGgH8y6GYEtFGOA9/sAB1e9k1WA9Yryjo8nenFOt7L7DmuBsoAm yzUQx/ksq9tTnjhpMySkhmFyfGvJsNSbQiW4mfIR0R1WqCHNHc+g06nzwsYmaHANcbUj rYlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=cyxYNe2rEdILQPW27fVW7F3j1ETdOJiIGayNnmBOErc=; b=aw7E0DiWnREFL8zw4bxx7eS+7GbmJQJJAoYO0UzMCfBMHK04J7ppzbSj/PcFJZ1aae SnnfEfS5XCkEN7HnTC/5Ph44A3vVEai+wQiAJp2XAk3KMsZvxUbzpBTK1ZIe92jv1ghv j8FDpOID3hE62sS05eR7P0+EbQZLQFvCx8tpOT1t5+Ebrpv39O6eFyNQCgdTTj/jT2TF syo6qmWEl0B1Dt8rXhnsP8MerKIAVL/24SizJEt+YMFie+wgC239W9d6VqMwpnms6nIw CbEwkhgb0qZgoPCJTPABIMBHixjqt8Khy5EMKQmhatcFJfQvFdH/SWSbocMP7cbbraQj 2atA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XdMgJMHX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id du7-20020a17090772c700b006f3b3d81aa8si370435ejc.216.2022.05.04.16.09.59; Wed, 04 May 2022 16:10:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XdMgJMHX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358911AbiEDRm7 (ORCPT + 99 others); Wed, 4 May 2022 13:42:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356201AbiEDRL1 (ORCPT ); Wed, 4 May 2022 13:11:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B636B4B416; Wed, 4 May 2022 09:57:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5C538617A6; Wed, 4 May 2022 16:57:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A75BEC385A4; Wed, 4 May 2022 16:57:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651683449; bh=+UBJ4i3Fl2GsTUI0Gp8N2JfuB7Nvbo2PZZ9YAnUaWY8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XdMgJMHXFbBT7995HONq4X8n0Q3lLvLqdyALIC13eg7x6LbypQIGhBRQaVP5aw0yi biCKoPXADkonAD4A+JANbVesBGQta4jXo61pwmv7HusC5lClP26P3PWh16icpVdRDA WawlpFBuSGIqMETaRDA9BpPqBwA+OwlqTdMdisMA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Zeal Robot , Lv Ruyi , Linus Walleij , Sasha Levin Subject: [PATCH 5.17 112/225] pinctrl: pistachio: fix use of irq_of_parse_and_map() Date: Wed, 4 May 2022 18:45:50 +0200 Message-Id: <20220504153120.578548247@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220504153110.096069935@linuxfoundation.org> References: <20220504153110.096069935@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lv Ruyi [ Upstream commit 0c9843a74a85224a89daa81fa66891dae2f930e1 ] The irq_of_parse_and_map() function returns 0 on failure, and does not return an negative value. Fixes: cefc03e5995e ("pinctrl: Add Pistachio SoC pin control driver") Reported-by: Zeal Robot Signed-off-by: Lv Ruyi Link: https://lore.kernel.org/r/20220424031430.3170759-1-lv.ruyi@zte.com.cn Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/pinctrl-pistachio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl-pistachio.c b/drivers/pinctrl/pinctrl-pistachio.c index 8d271c6b0ca4..5de691c630b4 100644 --- a/drivers/pinctrl/pinctrl-pistachio.c +++ b/drivers/pinctrl/pinctrl-pistachio.c @@ -1374,10 +1374,10 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl) } irq = irq_of_parse_and_map(child, 0); - if (irq < 0) { - dev_err(pctl->dev, "No IRQ for bank %u: %d\n", i, irq); + if (!irq) { + dev_err(pctl->dev, "No IRQ for bank %u\n", i); of_node_put(child); - ret = irq; + ret = -EINVAL; goto err; } -- 2.35.1