Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1158607iob; Wed, 4 May 2022 16:12:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyqgQT0CduaU/x7QmtxAiLwKfnKedcVXz+hJlDrS+KzjNuW2fdZMNOLl+Y4XfTR5Gb/xpYo X-Received: by 2002:a05:6402:288a:b0:425:c5b2:59d9 with SMTP id eg10-20020a056402288a00b00425c5b259d9mr26128462edb.412.1651705941485; Wed, 04 May 2022 16:12:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651705941; cv=none; d=google.com; s=arc-20160816; b=khImuTo+Vu3+rlzjpNDR8vNkd1F3E1NQnTeo+yKTg+pg4PkxCJLhxjThc4dc3bJUSi sTqpq1lg9+U2un8gQrd1xRqXSk7X5Z2tEWJZ1uHqzJJAEbdCUKz6ExiRFQHnsF9IZ2Lp yTxyYhws4u90Avlb6FzuCAlm8nSLbkMxWofCrychwXXTwrlDQlIiK6rHLWe+A/JZx4rZ l+iv0TLCRsu2XYAHWIwPF6sqeUJ0wYPebTTxUIFHsWpfSduE4ZpMnsaZ+Id+M8bApxma KFdr4Dd6Ej3pH/Zq5vKUxA5cGt14DQA5BNSE/1avdzxlidutSVI53LQqOU2ZGP100GDb wlwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=RVZXRmkuVlvY7YQ56J4Nl0jSbsjfYSHNH3LTA15p/+Y=; b=YzXGuylbzY2DNVnosEQW/K4A08P1FSEaOdaGLmdDwaXWQ8fQy5gxPP0POgwfbRjXQ7 g9NBY+cW7VNrdlv7t+yLi/it/CtWj8zwxymfFYoG6l1lkAiTS4dqKvkSHPX9k1+5Y5fD Il8txfxRnnWXkP7dnes/sE1pub6MMyMmWWVHNKSL/HgfFhWuDDQvegqxuz4VT8D2Fv84 DdUd4Nmi7IvsY9+1eYkaqY2bdqrF5I5UlbtfLndTdAHAOBOozaIrdEz/HrOaiflnLCsW nXO8yY9pMwlLMKsmcJpN6nuFp3zkzrazSc9nRThN46B8fDoQoJvrh81/5Fpzc/38e3Fe yneQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Cl2QCCzS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a12-20020a50858c000000b00425bb1f4712si39806edh.103.2022.05.04.16.11.50; Wed, 04 May 2022 16:12:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Cl2QCCzS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359544AbiEDRkJ (ORCPT + 99 others); Wed, 4 May 2022 13:40:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356798AbiEDRJo (ORCPT ); Wed, 4 May 2022 13:09:44 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B34EE1DA55; Wed, 4 May 2022 09:55:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7025DB82795; Wed, 4 May 2022 16:55:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26B4AC385A5; Wed, 4 May 2022 16:55:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651683338; bh=9vZ4s2S3OkqcFoWeX3a+FHD4PzlE9/XUKS4qPEXLkgI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Cl2QCCzS6jUx6/lQTTv66BwoUXn7Cjgw2O6U/t6s07YOLnMaZa7PKftsf1KJVotOW MiCWpv24V2IWa4RvCuSyqUley+JREU0lNk/Zf+jk+GG04MM1vOclLTcvNNHc2rvPRu m6eXoVmGv7tbhF9mKI9eUwzH2Qm33ngy/2wKq8Ys= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Zizhuang Deng , Stable@vger.kernel.org, Jonathan Cameron Subject: [PATCH 5.17 013/225] iio: dac: ad5592r: Fix the missing return value. Date: Wed, 4 May 2022 18:44:11 +0200 Message-Id: <20220504153111.439649738@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220504153110.096069935@linuxfoundation.org> References: <20220504153110.096069935@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zizhuang Deng commit b55b38f7cc12da3b9ef36e7a3b7f8f96737df4d5 upstream. The third call to `fwnode_property_read_u32` did not record the return value, resulting in `channel_offstate` possibly being assigned the wrong value. Fixes: 56ca9db862bf ("iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs") Signed-off-by: Zizhuang Deng Link: https://lore.kernel.org/r/20220310125450.4164164-1-sunsetdzz@gmail.com Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/dac/ad5592r-base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/iio/dac/ad5592r-base.c +++ b/drivers/iio/dac/ad5592r-base.c @@ -523,7 +523,7 @@ static int ad5592r_alloc_channels(struct if (!ret) st->channel_modes[reg] = tmp; - fwnode_property_read_u32(child, "adi,off-state", &tmp); + ret = fwnode_property_read_u32(child, "adi,off-state", &tmp); if (!ret) st->channel_offstate[reg] = tmp; }