Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1183002iob; Wed, 4 May 2022 16:50:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzSPzJJoQ9DiG/CONsCk922CsAW5q9MVsgRTIFQK4WSDF+EVtPJXwGedbqnkux2yDWg+31o X-Received: by 2002:a17:906:32d5:b0:6f3:be75:8485 with SMTP id k21-20020a17090632d500b006f3be758485mr23401600ejk.685.1651708232014; Wed, 04 May 2022 16:50:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651708232; cv=none; d=google.com; s=arc-20160816; b=bVNuVififoxD4ZWR83+0FUdm5+Zk9wuC7etPPpz0Tq6wrvgFJdupb9Vw36KqwxZAh7 nA3mEKNSUGiyKmFtTXAWo5KfDTJRrjUU9jVVZmM/oZCtBqvZwsk+cAlk1kUT8JH+M1KK Q6WqFPkdwahRB8sRde/l4sVZJtBwDqQ/QiQMuv1gAQZ4PVnkr6MRUzqwBIEoVHN257zt HMZkS9xdnYw8Kk0ODRHk9yRO1tG/as1FhrCvFScMl76+KYOnHyb3rsuYGOebGFByoGhV Cd5se0mS9w5vcV1ye7W/4ZhNA1K2yLbkVtcYzyMDwymtpH1Qhv21tmVC7EjE2bjixZEh F72w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=qAi2CdbD3AI+tXu3fN9tYFQZgiNbO4net5JrEEBf2nw=; b=J/4MY1yfGeAi82dG+cIBTR34Gl8gE8so4rq+iTkRcS2gLE1/ihpHGTxcNkSuIPUZhL pbBef1DyWlYZMI1aWFrr7EvpDq2KGAaudQdmxqC791Z2IUSy+XO80uVWMfYYu8LZKTAQ pkTgVfTQgtmwLzhZgJQ9NrToNlxfE6GsYe4KqSNRPXIuq3F6fEt2CV5L16LGy5eAaqRy Xt7B8SYN4F5dSV23dpkCaAf/ho/RiMhjE2lgHr/z25BfObFNpxEH0fNCcAKtSSOt1ofE ijMhL+TuMdvq+2u/m9M8Fm3D3K6RS/8Ca+QcnFLPIJ2Yw8skyl+R4si0LmzD6aaeZjgl zAZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=haV1Jk79; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ne39-20020a1709077ba700b006f3b74c80eesi589503ejc.149.2022.05.04.16.50.08; Wed, 04 May 2022 16:50:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=haV1Jk79; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359097AbiEDRjc (ORCPT + 99 others); Wed, 4 May 2022 13:39:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356833AbiEDRJp (ORCPT ); Wed, 4 May 2022 13:09:45 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67D3037A0B; Wed, 4 May 2022 09:55:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9C1D0B8279C; Wed, 4 May 2022 16:55:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AE57C385A5; Wed, 4 May 2022 16:55:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651683352; bh=vCTo9Jkj2+vEH1jeTBDcv+8ZSfGliF6JI9iUdcwawNI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=haV1Jk79yJU6XnaOrX+nloVJVpaDSuFHUTI/Z6Eyuw4sbjGVNroGgJGbMyFT4+tKf CU5iJpdPgCavsMqaB2ZbETGAMSjX19G0TehRMDFg1Jud2+ON0C1tFvwXXdtSIYVFKJ uSpVBNOq2YNAGc9gHygCKLDvdbzNtka5hazJR7Cs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Thinh Nguyen Subject: [PATCH 5.17 025/225] usb: dwc3: core: Fix tx/rx threshold settings Date: Wed, 4 May 2022 18:44:23 +0200 Message-Id: <20220504153112.572217806@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220504153110.096069935@linuxfoundation.org> References: <20220504153110.096069935@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thinh Nguyen commit f28ad9069363dec7deb88032b70612755eed9ee6 upstream. The current driver logic checks against 0 to determine whether the periodic tx/rx threshold settings are set, but we may get bogus values from uninitialized variables if no device property is set. Properly default these variables to 0. Fixes: 938a5ad1d305 ("usb: dwc3: Check for ESS TX/RX threshold config") Cc: Signed-off-by: Thinh Nguyen Link: https://lore.kernel.org/r/cccfce990b11b730b0dae42f9d217dc6fb988c90.1649727139.git.Thinh.Nguyen@synopsys.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc3/core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -1295,10 +1295,10 @@ static void dwc3_get_properties(struct d u8 lpm_nyet_threshold; u8 tx_de_emphasis; u8 hird_threshold; - u8 rx_thr_num_pkt_prd; - u8 rx_max_burst_prd; - u8 tx_thr_num_pkt_prd; - u8 tx_max_burst_prd; + u8 rx_thr_num_pkt_prd = 0; + u8 rx_max_burst_prd = 0; + u8 tx_thr_num_pkt_prd = 0; + u8 tx_max_burst_prd = 0; u8 tx_fifo_resize_max_num; const char *usb_psy_name; int ret;