Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1183012iob; Wed, 4 May 2022 16:50:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAwD9MEnSmoHrSqMIzixADd8GchtJ7Mhw7J6t808lGzLzTAvDQC0RblEV4GUA3mfHRHFj2 X-Received: by 2002:a17:907:7f8e:b0:6f4:2c01:5565 with SMTP id qk14-20020a1709077f8e00b006f42c015565mr19790166ejc.234.1651708232417; Wed, 04 May 2022 16:50:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651708232; cv=none; d=google.com; s=arc-20160816; b=LUB9E6wI0lca70eYhe5yWRT0heFNlblrLihKwD0t5/3yU4GfWqeV2bO+t5FDxq/oGI vT7BGQKO1ouSjJZ21doVSN4lrEbQwdwFkDlQlERowAdvg3U8G7Ds5Z2Kt7vqQfu3JN8L xNPtWFXFprOX/YgV3Zf8/kCQSByB2KxPJKMroAoMFiNIOMzCmjnGJd/Leg+loM2dazie v0TIb0FHPhaav76XK6wuHP/J6qfUdztJOwLsLAR6/8ezpl27Zdft2k9r8T6gGZhc+ydE meYNeW+4cBkRM6Eo0dlKjxFfFtsyJGWu9CuIfI6aa6N3WzgP/nqI+6K51iylaRRUBNR9 H4DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+SApBaLPhm+CKYOw4W+J9ASQRsInxNgaZe1nUoOXJng=; b=AHVSTu6sdewcqNh66vgYFZdIfo+BPfrzefQG3BHXdYf/tUEfwJh25IG4S1bBVVFcVh k4wsBYMRixt0WJis9iIn4l4TfgXl0arJ5GWg5H8ImKcd352W0A8Ib8bdYaahn7HbFRg4 /zB8T6ry1gYRzaNBm7rVJ4W2CwbqX/QpGRGlNKewsmw6okZu61UPbyv6y4G1luhOsQ22 L4/Nvr3k9JdBdu8SLwHpAZThq2vmXF9j5Y7oPhRt5FBbRScIpIjM0ajvqWqk3Inis5QH 2l0W5TPLAHTygZoNMbWz49SgrLnBh/z1vfKBx0b3Y3MaSRGGaBMrxJP3kJihtD5J8FYb Xm2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RfbiYnWH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nc23-20020a1709071c1700b006f395d509d0si472789ejc.498.2022.05.04.16.50.09; Wed, 04 May 2022 16:50:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RfbiYnWH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241958AbiEDRcT (ORCPT + 99 others); Wed, 4 May 2022 13:32:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356936AbiEDRJu (ORCPT ); Wed, 4 May 2022 13:09:50 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF33F47396; Wed, 4 May 2022 09:56:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8B3B4B8279C; Wed, 4 May 2022 16:56:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29397C385A5; Wed, 4 May 2022 16:56:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651683390; bh=2xcGUSWGTwbyBOA5NeTWHBkCsgH79GDnE6WyvaDrGyM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RfbiYnWHoFZMtg6J9ah1JyPSncN+jYXvBJhM16n6cojNojd41+oNx/7xZ8SqORuOK VwoVhjfAS2s0BKK+SBF2iIpcRlKeimCYrtUoMYADejvNiKlw7sbUDDkzocBC4k4VTw mffo71s/ra3S/g7oS2TK9JD9yfpysQT3Toq2FOh4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Jonathan Cameron , Sasha Levin Subject: [PATCH 5.17 062/225] iio: dac: ad3552r: fix signedness bug in ad3552r_reset() Date: Wed, 4 May 2022 18:45:00 +0200 Message-Id: <20220504153115.705133387@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220504153110.096069935@linuxfoundation.org> References: <20220504153110.096069935@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit 460bfa65b0de72f4d8a808bc7cfb1cb591a95b18 ] The "val" variable is used to store either negative error codes from ad3552r_read_reg_wrapper() or positive u16 values on success. It needs to be signed for the error handling to work correctly. Fixes: 8f2b54824b28 ("drivers:iio:dac: Add AD3552R driver support") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/20220316122354.GA16825@kili Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/dac/ad3552r.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/dac/ad3552r.c b/drivers/iio/dac/ad3552r.c index 97f13c0b9631..e0a93b27e0e8 100644 --- a/drivers/iio/dac/ad3552r.c +++ b/drivers/iio/dac/ad3552r.c @@ -656,7 +656,7 @@ static int ad3552r_reset(struct ad3552r_desc *dac) { struct reg_addr_pool addr; int ret; - u16 val; + int val; dac->gpio_reset = devm_gpiod_get_optional(&dac->spi->dev, "reset", GPIOD_OUT_LOW); -- 2.35.1