Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1227549iob; Wed, 4 May 2022 18:04:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDDih9Cli3VXmdqKTCs1lJZobnflfPF8TcE/CEt0hQWp3vBuQ8KpA/s98piN46PY30X+Hy X-Received: by 2002:a63:ed56:0:b0:3c5:fff8:a69e with SMTP id m22-20020a63ed56000000b003c5fff8a69emr2887844pgk.331.1651712653792; Wed, 04 May 2022 18:04:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651712653; cv=none; d=google.com; s=arc-20160816; b=eAJg3Y6oo99iT31R4J04ACKliv6+yOrG7XlTaeLmKS29unLD9/yvEMIGRh5HuohJr3 4xQ/3gAIiplvU45E/ej3j2aWjVEjn9qn1rO44n2z1WwYJS8MXLTCtwDuHjdCatQ7lAuj phmnwpYBlWNChBWngVWpwVBO9wxgpfEpz3k0lIOtaWWx1YdKzipByiiHEp6kSapaFGAb xRqFYIYkFshhxgsLlFC0BcOGY7shqusFQKuw8LfV29Lr+q0fjr0C75C7oAFWZuVtt0II 9BcjIHpn4YtPpZttHq2FgZ6OqiJljLFATin/0u2Tx1gxYPdEOVA7Mp1Lg6SnlcJW5SHV CGZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=eAJRntPWIBLn0ku7TFtFccQmrtl7Pk6DFATPQGCzPGA=; b=EJflCFfU91Kr/qTQRTnhy1u5GcTeNxENdqmOOCEi9E4P5CFfZf+7Hcx4+G8Zza1oIs vbti6ZIXQbYMywy+O6YCf5Gf8SPwrM9Fb6ikk/z8ok7uTKygXtj4uOx6XO+KTFhQK7YJ p9tZEfZZsvkuo4MMXF/Ano+kP5QF9WBn0dXHMWYR5imrxMbDnPf3HKWrAzyUiMcj8XUU DkGRTBKyE++W9NG+oTwxtx51kviUGZzeOn1k+Ruyhd/1ZuBpMkHAcVBmoEnJLsEfN2De eHXQTYZ1D4slXavZEEUcgCsqNhAUmYAhZHAfWDwfMHgsFXi3gG1kGNEKhJbIBQQYB32s hX5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QeNqCzQE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 140-20020a621992000000b004fa3a8dff62si102488pfz.25.2022.05.04.18.03.57; Wed, 04 May 2022 18:04:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QeNqCzQE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358923AbiEDRf1 (ORCPT + 99 others); Wed, 4 May 2022 13:35:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357038AbiEDRJx (ORCPT ); Wed, 4 May 2022 13:09:53 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 466EF4889D; Wed, 4 May 2022 09:56:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0BDDAB827C2; Wed, 4 May 2022 16:56:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF0EAC385B0; Wed, 4 May 2022 16:56:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651683416; bh=SRazH2uyyXomn+ZtPfi6A/TGv9uvTaddlbbFfB3+IhA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QeNqCzQEBnJzlIzPtDTbuMOgY9enyXH5M2WQ35anVRvnktn4Yj9cX0WtzFdqaThLk qYPu1J3T+1i2pkKKJknMjAkD8gMzX99HQ3mjRRwS/uPyMkZyucba9H3E5Dp/gQsgYs paQdFckxfibP/EM0ybqb+i4rdBI3UXNqloR6gaQM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , "David S. Miller" , Sasha Levin Subject: [PATCH 5.17 101/225] net: dsa: Add missing of_node_put() in dsa_port_link_register_of Date: Wed, 4 May 2022 18:45:39 +0200 Message-Id: <20220504153119.734641238@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220504153110.096069935@linuxfoundation.org> References: <20220504153110.096069935@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit fc06b2867f4cea543505acfb194c2be4ebf0c7d3 ] The device_node pointer is returned by of_parse_phandle() with refcount incremented. We should use of_node_put() on it when done. of_node_put() will check for NULL value. Fixes: a20f997010c4 ("net: dsa: Don't instantiate phylink for CPU/DSA ports unless needed") Signed-off-by: Miaoqian Lin Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/dsa/port.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/dsa/port.c b/net/dsa/port.c index 1a40c52f5a42..4368fd32c4a5 100644 --- a/net/dsa/port.c +++ b/net/dsa/port.c @@ -1240,8 +1240,10 @@ int dsa_port_link_register_of(struct dsa_port *dp) if (ds->ops->phylink_mac_link_down) ds->ops->phylink_mac_link_down(ds, port, MLO_AN_FIXED, PHY_INTERFACE_MODE_NA); + of_node_put(phy_np); return dsa_port_phylink_register(dp); } + of_node_put(phy_np); return 0; } -- 2.35.1