Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1424696iob; Thu, 5 May 2022 00:26:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjcrOqrwzBmd6cp6a53BPb1X6CbjZm0Zjt8r4z0jH8igcrrrLcOvEptiOSN83Lui6daRmn X-Received: by 2002:a63:894a:0:b0:3ab:23c7:33ff with SMTP id v71-20020a63894a000000b003ab23c733ffmr21143550pgd.245.1651735606922; Thu, 05 May 2022 00:26:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651735606; cv=none; d=google.com; s=arc-20160816; b=rYR1AEf4Brt24Tq42eWHM396U3gWp/M4tvjuoBbItiCFuL3DPEvMwi40W70g9irwfM sbADNhV5ZxV/U8Qj1jjxqPgXXVpuyfG/5dahqAeN8M7OnaPFaEeOQk+ChcgQqDAlHYOB uYVeo3Vh2Q8UE2tVl9QTViFMWP5+jaaArOFFtExSIPBTalUgTYvt/kmHLi4IUq4tpFQl dB21DKYXvuc3RgMujMp77+VLy8ZxbXamqWCMCl1HzqTeoNG5MloNDOq1CzNhtd2ctlhR PdQ8HqTy56GhMJuvOwPsC/di+Rk7w2lpovouYM46Y+zL3aYHBJAKlZiPpr0x31P+tbeL mJAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Hncz9+nBwI6SW3bRln7SBb91mfW0Ffq3S4/K62rdajc=; b=o6Le2nEwZ+YuzoFCElCHoiPuVergn82XO+Eto0cD1eRb9eO6iIolrAkw28Hpis2Skm j1DtpmZZoRVW7E9OcgAAMqRzVQjwucrnBkWqTuBHsyhySPhssFvG+eFHcQwBY3SeQkox 7q7zI/YH8dEyNmknJ/BYkKzcKp6dMnYd41i1AlfRK1DsXwa4HHiMX+0j+mlXMaLe6zq/ JjSLs1r/AAsLNvgbt/8mhgaj2ZnzCZM7sUGDGAj3wICkc7x07sp4YEl3nv6D5jXG1PWl mOnn+ZXIkPGZHJDxiIjVR54jFexWR9clOvuJu08s9rKJ8oTDOUU85rKi6GyWk/sHfAf7 8ykA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=X9cGs9Or; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n22-20020a637216000000b003c1abf9ef96si717625pgc.777.2022.05.05.00.26.30; Thu, 05 May 2022 00:26:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=X9cGs9Or; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358855AbiEDRvZ (ORCPT + 99 others); Wed, 4 May 2022 13:51:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356949AbiEDROh (ORCPT ); Wed, 4 May 2022 13:14:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76AD053E24; Wed, 4 May 2022 09:58:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 66F4361926; Wed, 4 May 2022 16:57:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B11FFC385A5; Wed, 4 May 2022 16:57:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651683475; bh=FSy8OxLu6ImTtFkfpaaWWjsYOWcsYH05gS/6+cpnjGc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X9cGs9OrrS0ppgCIU3M6I+6TaZ0f8Um5KFDJOp3TVqHtxQqWRyeKxRtrT7ilSkM1t 0ijRvGRLvAZZVltQoyUmg9mxomgc0Ag/7EhVSwej0SDQOOWaLNkPd2sgpuXW47ap0x tAJ0Hq8VFoMERq2izSdS9G+Iz8521CmGu01CgB4A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jens Axboe , Sasha Levin Subject: [PATCH 5.17 137/225] io_uring: check reserved fields for send/sendmsg Date: Wed, 4 May 2022 18:46:15 +0200 Message-Id: <20220504153122.491940346@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220504153110.096069935@linuxfoundation.org> References: <20220504153110.096069935@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jens Axboe [ Upstream commit 588faa1ea5eecb351100ee5d187b9be99210f70d ] We should check unused fields for non-zero and -EINVAL if they are set, making it consistent with other opcodes. Fixes: 0fa03c624d8f ("io_uring: add support for sendmsg()") Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- fs/io_uring.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/io_uring.c b/fs/io_uring.c index fbba8342172a..107bce75131e 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -4890,6 +4890,8 @@ static int io_sendmsg_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) if (unlikely(req->ctx->flags & IORING_SETUP_IOPOLL)) return -EINVAL; + if (unlikely(sqe->addr2 || sqe->file_index)) + return -EINVAL; sr->umsg = u64_to_user_ptr(READ_ONCE(sqe->addr)); sr->len = READ_ONCE(sqe->len); -- 2.35.1