Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1449178iob; Thu, 5 May 2022 01:13:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxKRSZZB2qFpdvuWqxgeHPukM0JhSg3JDw8IpwBUagv1mzqihkDYgEFpqd3bIr09VB6gb8N X-Received: by 2002:a17:90b:314c:b0:1dc:767d:a7d9 with SMTP id ip12-20020a17090b314c00b001dc767da7d9mr4614502pjb.99.1651738407407; Thu, 05 May 2022 01:13:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651738407; cv=none; d=google.com; s=arc-20160816; b=xxUKN3ZJKq2cL/ZXVrSvGmbS1hdnvv63fYxZGwhHuZOipfPAPMKnB+IODIFqPAYlRH NBo1gXc9sBmAb7S2inJn2TjNABN/ccvo4YXcDyBp3vfezED+5/kAcd+S2pTZCr0jG3PK Fi58EcnmeIsrXqT1A7Ju9QEt20g9itIPEGhL5IXEyQcZzbac0o5zjsNw3tdDU37Q7LIR T44Hx+DMhSvkquttqQKkGXq7yDJwTsMCvNoCt4cCzQAEDGbxbINLG8uuCxRD6IwMPRb7 4cuGpSrOzC7LE4I2zDyRnicwu/fmPfHTUWGuVWEstIkTkZIyIApoAB4IjqYr5ZYPyFnE Nqqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=K5s5WVj/wGwvzkhtVJq05AkrlA4MfqHC5zukX7mo99E=; b=PaZnzJyKwUS0JVX7Nzfw0alf3Eib9M6DnMpudAxaplhg+UqWl6w4qzChcC0zMsd9lI Yczj2uVi5lEvD56K1q2Sw3T73WvmpZRNazeDVfrxhj2QjqMpvLf2djeqNfhQBwzLz2Bz oFaBgXvICeSPzgusPyXWSJu0BK1NyCkMahheE7eNvtbDyZPPoSgtVJ0cf24SDdjJ9xEd sd1YUJZ6B481qF7c3orJq4e95xe6pJVGrXqI4Tbg4wE+yYCq05xI/yPvwSgpYDZpVVdi jB8MO0DISZcN+7sdaUy3ZVGEcZ9oXE3er0kQVGSt+lzjTjIxKGkHlm8CJQJEKd5GIQkZ cfrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QNIMoowT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l185-20020a6391c2000000b003c626c711a4si126749pge.861.2022.05.05.01.13.12; Thu, 05 May 2022 01:13:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QNIMoowT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358384AbiEDRiA (ORCPT + 99 others); Wed, 4 May 2022 13:38:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356882AbiEDRJr (ORCPT ); Wed, 4 May 2022 13:09:47 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13BD14474A; Wed, 4 May 2022 09:56:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B9F5FB827A3; Wed, 4 May 2022 16:56:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F9CBC385A4; Wed, 4 May 2022 16:56:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651683374; bh=blfb6PV7qdWdQWCJAaSTWeenwPcA67Q/sJFOLviYEZw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QNIMoowTI6nLJSoUm0q81wqo7Xsx3C5UGcZIJcjAedVf4ciKJjz2UXk47xQ6YK9Vx iCKSmmNmmYwa68VUqi4rbZ2ye8x6hSRwT1AwGdAWRKfXxmDZJTvMbEHbymOOlc2UXc gDYUM3lIxNyL1J7Bfa/yyf7aQrN1YecfuQHn7ylo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Necip Fazil Yildiran , Krzysztof Kozlowski , Arnd Bergmann Subject: [PATCH 5.17 045/225] pinctrl: samsung: fix missing GPIOLIB on ARM64 Exynos config Date: Wed, 4 May 2022 18:44:43 +0200 Message-Id: <20220504153114.131064327@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220504153110.096069935@linuxfoundation.org> References: <20220504153110.096069935@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Krzysztof Kozlowski commit ac875df4d854ab13d9c4af682a1837a1214fecec upstream. The Samsung pinctrl drivers depend on OF_GPIO, which is part of GPIOLIB. ARMv7 Exynos platform selects GPIOLIB and Samsung pinctrl drivers. ARMv8 Exynos selects only the latter leading to possible wrong configuration on ARMv8 build: WARNING: unmet direct dependencies detected for PINCTRL_EXYNOS Depends on [n]: PINCTRL [=y] && OF_GPIO [=n] && (ARCH_EXYNOS [=y] || ARCH_S5PV210 || COMPILE_TEST [=y]) Selected by [y]: - ARCH_EXYNOS [=y] Always select the GPIOLIB from the Samsung pinctrl drivers to fix the issue. This requires removing of OF_GPIO dependency (to avoid recursive dependency), so add dependency on OF for COMPILE_TEST cases. Reported-by: Necip Fazil Yildiran Fixes: eed6b3eb20b9 ("arm64: Split out platform options to separate Kconfig") Cc: Signed-off-by: Krzysztof Kozlowski Reviewed-by: Arnd Bergmann Link: https://lore.kernel.org/r/20220420141407.470955-1-krzysztof.kozlowski@linaro.org Signed-off-by: Greg Kroah-Hartman --- arch/arm/mach-exynos/Kconfig | 1 - drivers/pinctrl/samsung/Kconfig | 11 ++++------- 2 files changed, 4 insertions(+), 8 deletions(-) --- a/arch/arm/mach-exynos/Kconfig +++ b/arch/arm/mach-exynos/Kconfig @@ -17,7 +17,6 @@ menuconfig ARCH_EXYNOS select EXYNOS_PMU select EXYNOS_SROM select EXYNOS_PM_DOMAINS if PM_GENERIC_DOMAINS - select GPIOLIB select HAVE_ARM_ARCH_TIMER if ARCH_EXYNOS5 select HAVE_ARM_SCU if SMP select PINCTRL --- a/drivers/pinctrl/samsung/Kconfig +++ b/drivers/pinctrl/samsung/Kconfig @@ -4,14 +4,13 @@ # config PINCTRL_SAMSUNG bool - depends on OF_GPIO + select GPIOLIB select PINMUX select PINCONF config PINCTRL_EXYNOS bool "Pinctrl common driver part for Samsung Exynos SoCs" - depends on OF_GPIO - depends on ARCH_EXYNOS || ARCH_S5PV210 || COMPILE_TEST + depends on ARCH_EXYNOS || ARCH_S5PV210 || (COMPILE_TEST && OF) select PINCTRL_SAMSUNG select PINCTRL_EXYNOS_ARM if ARM && (ARCH_EXYNOS || ARCH_S5PV210) select PINCTRL_EXYNOS_ARM64 if ARM64 && ARCH_EXYNOS @@ -26,12 +25,10 @@ config PINCTRL_EXYNOS_ARM64 config PINCTRL_S3C24XX bool "Samsung S3C24XX SoC pinctrl driver" - depends on OF_GPIO - depends on ARCH_S3C24XX || COMPILE_TEST + depends on ARCH_S3C24XX || (COMPILE_TEST && OF) select PINCTRL_SAMSUNG config PINCTRL_S3C64XX bool "Samsung S3C64XX SoC pinctrl driver" - depends on OF_GPIO - depends on ARCH_S3C64XX || COMPILE_TEST + depends on ARCH_S3C64XX || (COMPILE_TEST && OF) select PINCTRL_SAMSUNG