Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e74aacdf-3ff7-261d-997f-5b6566b66207@quicinc.com>
Date:   Wed, 4 May 2022 11:05:29 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [PATCH v4] arm64: dts: qcom: sc7280: Add lpasscore & lpassaudio
 clock controllers
Content-Language: en-US
To:     Stephen Boyd <swboyd@chromium.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>
CC:     Douglas Anderson <dianders@chromium.org>,
        <devicetree@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20220503113246.13857-1-quic_tdas@quicinc.com>
 <CAE-0n53QZn8VYB-dxzwccYDURU-0qW3ZwsuOEECwrKGAhYzwgw@mail.gmail.com>
From:   Taniya Das <quic_tdas@quicinc.com>
In-Reply-To: <CAE-0n53QZn8VYB-dxzwccYDURU-0qW3ZwsuOEECwrKGAhYzwgw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello Stephen,

On 5/4/2022 12:40 AM, Stephen Boyd wrote:
> Quoting Taniya Das (2022-05-03 04:32:46)
>> Add the low pass audio clock controller device nodes. Keep the lpasscc
>> clock node disabled and enabled for lpass pil based devices.
> 
> Does it mean that we're going to have overlapping reg ranges between
> nodes in DT for clk controllers? That is not proper DT style, indicating
> that we should combine the overlapping nodes and then have some
> compatible or DT property telling us how to treat the clks in the audio
> subsystem.
> 

In the case where PIL based LPASS node would be used, we would disable 
the other lpass clock controller nodes. Does that seem fine or I would 
need to map the complete range in the current PIL driver if that works.

>>
>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
>> ---
>> [v4]
>>   * Mark lpasscc[lpasscc@3000000] device node as "disabled".

-- 
Thanks & Regards,
Taniya Das.