Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1458363iob; Thu, 5 May 2022 01:29:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYJ97hxkMPjNgghycPdRyawgcoMLMatBz0/WfK+HbpE1vEheg5pAORGW/53EBSugWPlsZj X-Received: by 2002:a17:903:244b:b0:15e:9b15:4890 with SMTP id l11-20020a170903244b00b0015e9b154890mr22625359pls.160.1651739352343; Thu, 05 May 2022 01:29:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651739352; cv=none; d=google.com; s=arc-20160816; b=vCqJY62HRZGzqsOyrGvfz3/vXDw/RveImeNJ55jBakLP5bqRufdvUv8CA9O6lfquoQ BYs5d38uJn0TiMZXUKgjQJXJiOJdCL7oHOmSbi29I9tcpaW8al5Lcwr7p+qFetDX2QnB gyoHqXZq83qItoqsfGp+bDI3ZszQGMSiKINYKUnuBGt0QwjFFQJuXyA9T7JtbJjrOVH/ 7225UhjtURoK8HnE8gnBfxIvjQ9sSIj0R5Jzkulee5aj4JSbITPF4LJbhVFHeF4ezfnT bhrTNG5s7C2za3kDlf7qcrJ6BRopMZCMux/DGPEx7JK+a53dZ2wcnlNhVDRAVK1tsvtP i9Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=PDUpqEwsU0g54F2duDLV9Pqr2Yjkf7JgCmsGkPEOp0w=; b=wLxS2mQ7+L3rTOePDzv1Fbt9akCEWntGa5ABAw4odkIm4gUTwg5wMhC5QbDJkVSPQG a5uN1A38tHzSYGutE1XVC1hwKww3k+msJn2Tn/ofy3dMjEYtroI0aT9PycCV2a8ZF9TV VPvXfG9DKGITkH09Aqax+msbS+rtSxn6LEGuWblz+rcAar4sIGmDE70Xk43gDemLH1ih QCwvODZwQWYphBUpl00lCgnD3whFqqIXfgFScmnD5Ji1VLQA0/QIR8rBGvliQ/50T5NO /yL3k7ma9DE7hy3gOZMHdfZZxyQ45EBlW0xt9Zh+14PxOwxusNtTCFGMEpPOswHRv/u3 MnIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=LsrQObZX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e9-20020a636909000000b003c1abf9efa0si912455pgc.71.2022.05.05.01.28.56; Thu, 05 May 2022 01:29:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=LsrQObZX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351244AbiEDOY1 (ORCPT + 99 others); Wed, 4 May 2022 10:24:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345701AbiEDOYZ (ORCPT ); Wed, 4 May 2022 10:24:25 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D07D11C928; Wed, 4 May 2022 07:20:49 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id k27so1880070edk.4; Wed, 04 May 2022 07:20:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PDUpqEwsU0g54F2duDLV9Pqr2Yjkf7JgCmsGkPEOp0w=; b=LsrQObZXf1A/KJ3l8fAg9QNyokldjCq9cX5C7y+XIxBlonabohntkTLKb0rJ3mO6ES DlWroY41MZMuGn0G6eM/TINrCGpIqU0VYsy/5y8QrNBn/E0vvJSiXGIOOonTe7PX7wwJ Kr/dUZlao0crAh6cyzm7vJ9wvZQXkXUGl5gJnY6WKF6pf6dww8E3AHlESi0P/yHZ2q5F Bki4i/mXRFF/XI2J7ovTbRnLw4ZJqtR4NOewVfd6Y94CzqGiP1rULXKWxYnGan3Qclxs uPDx/gryb9V0LY+irlYkN/WoifbWSwOPw8d2bWmzgbROezZ2j1qhBrfFqwvyezQ0hqZd Ztww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PDUpqEwsU0g54F2duDLV9Pqr2Yjkf7JgCmsGkPEOp0w=; b=yCA0xbQpp3xj6eKFuxId0IaP1z61UvE6HS2vfoiq4uKLPZBeY7E1iZDDvyVdQ3Xzof ISPhrC40ToQZ6GPYH1IU6Qi+o1Ql0O2Uqlm2Ua6wmedDrO4WFRFwLeYUzBZVpq/TWWwT ateNDi9VVbi4FokhjI3HwQ3+6FXBHUkYWiyc0XUSMeNLJ06v576Tjeg1ZRu/c1ihqqPf d28LthPl4+yCacBlYKREyZnH64idZ0CDlQ3xPJYLNskJjs0t0jMrem8POuR635pBowPJ NjhSOoKpCP6dROBtTMDTCBJNbVJA3KdkrzbuvICyFX7bm+SsTMFyBYrbdw2MqKaH96tt vA2g== X-Gm-Message-State: AOAM530E+5iBuB4DCWaSoXjF9xGWLAL2wPVJWpPg5Kq/g220uKz0by6b mTCYATCRMp5Mm8ciLiXJUpJRaPxr4IU/e/11ydQ= X-Received: by 2002:a05:6402:d51:b0:425:d5e1:e9f0 with SMTP id ec17-20020a0564020d5100b00425d5e1e9f0mr23287754edb.125.1651674048120; Wed, 04 May 2022 07:20:48 -0700 (PDT) MIME-Version: 1.0 References: <20220504133612.604304-1-Qing-wu.Li@leica-geosystems.com.cn> <20220504133612.604304-4-Qing-wu.Li@leica-geosystems.com.cn> In-Reply-To: <20220504133612.604304-4-Qing-wu.Li@leica-geosystems.com.cn> From: Andy Shevchenko Date: Wed, 4 May 2022 16:20:11 +0200 Message-ID: Subject: Re: [PATCH V3 3/5] iio: accel: sca3300: modified to support multi chips To: LI Qingwu Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Tomas Melin , devicetree , Linux Kernel Mailing List , linux-iio , Rob Herring Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 4, 2022 at 3:36 PM LI Qingwu wrote: > > The drive support sca3300 only. driver supports > There are some other similar chips, for instance, SCL3300. > Prepare the way for multiple chips and additional channels. > Modify the driver to read the device id. > Add the tables for the corresponding id to support multiple chips. > Add prepares for the addition of extra channels. > Add prepares for handling the operation modes for multiple chips. It seems you need to work more on the commit messages in all patches. ... > +struct sca3300_chip_info { > + const struct iio_chan_spec *channels; > + const int (*accel_scale_table)[2]; > + const int *accel_scale_modes_map; > + const unsigned long *scan_masks; > + const int *avail_modes_table; > + const int *freq_modes_map; > + const int *freq_table; > + const u8 num_accel_scales; > + const u8 num_avail_modes; > + const u8 num_channels; > + const u8 num_freqs; > + const u8 chip_id; Why do you have const qualifier on all members? The last one is understandable, but the rest, esp. pointers should be justified. > + const char *name; > +}; ... > +static int sca3300_set_op_mode(struct sca3300_data *sca_data, int index) > +{ > + int mode; > + > + if ((index < 0) || (index >= sca_data->chip->num_avail_modes)) Too many parentheses. > + return -EINVAL; > + > + mode = sca_data->chip->avail_modes_table[index]; > + > + return sca3300_write_reg(sca_data, SCA3300_REG_MODE, mode); > +} -- With Best Regards, Andy Shevchenko