Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1651685100-44687-1-git-send-email-justinpopo6@gmail.com> <1651685100-44687-2-git-send-email-justinpopo6@gmail.com>
In-Reply-To: <1651685100-44687-2-git-send-email-justinpopo6@gmail.com>
From:   Justin Chen <justinpopo6@gmail.com>
Date:   Wed, 4 May 2022 11:55:37 -0700
Message-ID: <CAJx26kV+15rs0=YcRj6z5ZbKU4=u9MHyuOdo=EfJwAXYKAdbBg@mail.gmail.com>
Subject: Re: [PATCH 1/2] gpio: pca953xx: Add support for pca6408
To:     Linus Walleij <linus.walleij@linaro.org>, brgl@bgdev.pl,
        Rob Herring <robh+dt@kernel.org>,
        krzysztof.kozlowski+dt@linaro.org
Cc:     linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, f.fainelli@gmail.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, May 4, 2022 at 10:25 AM Justin Chen <justinpopo6@gmail.com> wrote:
>
> Add support for pca6408 which is the 8-bit version of the pca6416.
>
> https://www.nxp.com/docs/en/data-sheet/PCA6408A.pdf
>
> Signed-off-by: Justin Chen <justinpopo6@gmail.com>
> ---
>  drivers/gpio/gpio-pca953x.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index d2fe76f..2d0b080 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -71,6 +71,7 @@
>  #define PCA_CHIP_TYPE(x)       ((x) & PCA_TYPE_MASK)
>
>  static const struct i2c_device_id pca953x_id[] = {
> +       { "pca6408", 8  | PCA953x_TYPE | PCA_INT, },
Apologies, typo here. Should be capital "x". Will send a v2.

Justin
>         { "pca6416", 16 | PCA953X_TYPE | PCA_INT, },
>         { "pca9505", 40 | PCA953X_TYPE | PCA_INT, },
>         { "pca9506", 40 | PCA953X_TYPE | PCA_INT, },
> @@ -1198,6 +1199,7 @@ static int pca953x_resume(struct device *dev)
>  #define OF_957X(__nrgpio, __int) (void *)(__nrgpio | PCA957X_TYPE | __int)
>
>  static const struct of_device_id pca953x_dt_ids[] = {
> +       { .compatible = "nxp,pca6408", .data = OF_953X(8, PCA_INT), },
>         { .compatible = "nxp,pca6416", .data = OF_953X(16, PCA_INT), },
>         { .compatible = "nxp,pca9505", .data = OF_953X(40, PCA_INT), },
>         { .compatible = "nxp,pca9506", .data = OF_953X(40, PCA_INT), },
> --
> 2.7.4
>