Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1496461iob; Thu, 5 May 2022 02:41:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXk4HUxQ+6wpWIUJTCP5N3Qm3ZsKEKdP5ex930sP/d0m6CZ5yZpnr7N50i4zm+kLbxPMZr X-Received: by 2002:a17:907:6e8d:b0:6f4:b220:a6b2 with SMTP id sh13-20020a1709076e8d00b006f4b220a6b2mr9048664ejc.71.1651743694958; Thu, 05 May 2022 02:41:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651743694; cv=none; d=google.com; s=arc-20160816; b=WxbccBlKYkNtGsnnC07ruvkKc0xqCw5SO3V2VJy/H0BhWjHftIyAki3vTTB+Xc2KlI DQQ5dSrkdn4HeEKq4QhZNDxnrr6M55p8Ff6+A8TGLi4y+3ITg5RetOLaa8KnozWmhVlZ 4H4Ft/Ayg44LhuqQJWSmLNgelijpAEbcOG07kRoek03nlBEmO8OisotIkdOTZ65ACagz EacN6rmkOvdHZRlRqkj0gRR+KdinYSqZ3T9cFrVbBqO2aFlxgZk5fnxa62AEC58RWK1r hVijSdAOtUehwMkCH8+dQ9P9qaKSMboGr7sXTX4rzdG54YS2jcwn7Rb3sc0wszcAFCs8 iBuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=PoJtFaB3BMvKGFuWKLZREvzs0C9h+I8bzkCrMY88qHY=; b=yj1HuHukA0rO8LUJZ5x8GjxtEwqWBM6e5AAmINt01mFNle9rD7VIhqjdWIELjjcDCa TIgKBpAi4YHmY4fbnSfmNTWIgF+TC4sz3SuhNIlLNKeFGnBxnSXXC9T4D0YBY9ybMePv LH4NQMYFCkpFqIsm7n7YPdt5TseugA9BeBlm9F44LLgXWdx+Zq+ecgFRnB9zECMlmj2r UBvHlK6/m/IPBrUIS89ckvKZQxj5VvyWyY/UhpXxKSMNLUsPka7a1eVZUU/4G2t2B2Tr 3cjXMlD8i1wnCdtJBIw6aAvgCnN+0udAD65qH7sEcDC2XUy7LvNkitfk2pN91XmVEpig j+Uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="pDZe9K+/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l8-20020a50cbc8000000b0042600959715si1196592edi.204.2022.05.05.02.41.11; Thu, 05 May 2022 02:41:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="pDZe9K+/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358289AbiEDRqN (ORCPT + 99 others); Wed, 4 May 2022 13:46:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356389AbiEDRNl (ORCPT ); Wed, 4 May 2022 13:13:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7131E4BFF3; Wed, 4 May 2022 09:57:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7CC496193E; Wed, 4 May 2022 16:57:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4796C385A4; Wed, 4 May 2022 16:57:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651683464; bh=nU9hRqmoG+NR1e6QcNT5Gtc/DQw+zQxCB3nckjInEu0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pDZe9K+/A7IxVkyQ9bxuOp1ctGZO9YT1FyGPIv4rPTltqyhUheG6EB8Msz2dQCUst 5udpfsmhaqJJexiwjD+Pvvg8q38LG7x+DuKf1WTbk7tYlis35kpAndMTFTCzaFZhmR VO2Qygl3YgHrRxsvc+XBnmYgzdkmExwDA5hFAlF8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Samuel Holland , Jernej Skrabec , Sasha Levin Subject: [PATCH 5.17 126/225] bus: sunxi-rsb: Fix the return value of sunxi_rsb_device_create() Date: Wed, 4 May 2022 18:46:04 +0200 Message-Id: <20220504153121.646218439@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220504153110.096069935@linuxfoundation.org> References: <20220504153110.096069935@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit fff8c10368e64e7f8960f149375c12ca5f3b30af ] This code is really spurious. It always returns an ERR_PTR, even when err is known to be 0 and calls put_device() after a successful device_register() call. It is likely that the return statement in the normal path is missing. Add 'return rdev;' to fix it. Fixes: d787dcdb9c8f ("bus: sunxi-rsb: Add driver for Allwinner Reduced Serial Bus") Signed-off-by: Christophe JAILLET Reviewed-by: Samuel Holland Tested-by: Samuel Holland Signed-off-by: Jernej Skrabec Link: https://lore.kernel.org/r/ef2b9576350bba4c8e05e669e9535e9e2a415763.1650551719.git.christophe.jaillet@wanadoo.fr Signed-off-by: Sasha Levin --- drivers/bus/sunxi-rsb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c index 4566e730ef2b..60b082fe2ed0 100644 --- a/drivers/bus/sunxi-rsb.c +++ b/drivers/bus/sunxi-rsb.c @@ -227,6 +227,8 @@ static struct sunxi_rsb_device *sunxi_rsb_device_create(struct sunxi_rsb *rsb, dev_dbg(&rdev->dev, "device %s registered\n", dev_name(&rdev->dev)); + return rdev; + err_device_add: put_device(&rdev->dev); -- 2.35.1