Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Zhang, Tianfei" <tianfei.zhang@intel.com>
To:     "Wu, Hao" <hao.wu@intel.com>, "trix@redhat.com" <trix@redhat.com>,
        "mdf@kernel.org" <mdf@kernel.org>,
        "Xu, Yilun" <yilun.xu@intel.com>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Matthew Gerlach" <matthew.gerlach@linux.intel.com>
Subject: RE: [PATCH v4] uio: dfl: add HSSI subsystem feature id
Thread-Topic: [PATCH v4] uio: dfl: add HSSI subsystem feature id
Thread-Index: AQHYYBXhq0QLvnormUiUUyimXrfATK0P1EuAgAAwaMA=
Date:   Thu, 5 May 2022 09:37:06 +0000
Message-ID: <BN9PR11MB54834743BD2A4C41B7385B9EE3C29@BN9PR11MB5483.namprd11.prod.outlook.com>
References: <20220505001628.681226-1-tianfei.zhang@intel.com>
 <DM6PR11MB38197DBE27837090E0C9165985C29@DM6PR11MB3819.namprd11.prod.outlook.com>
In-Reply-To: <DM6PR11MB38197DBE27837090E0C9165985C29@DM6PR11MB3819.namprd11.prod.outlook.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.6.401.20
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+d5hViMF4Qy60WfHdc/67L+cJJ0LSVaYm1DfR6FJV4fpSZwGkI9O7Tipsg20?=
 =?us-ascii?Q?0i7fJ/ImvCYDOpQoRDpj1WHbeAEp2ctBhxkcONLiPHUDNmrpcvxxP1nAOlCb?=
 =?us-ascii?Q?SVjVWa3OigHsnfWRL8v1hJRrGwgAViXJbiZcbJ8pJd/+XLqReu5Dbezsiu4/?=
 =?us-ascii?Q?pXJyz9anJJu7aPDmiNen4UoiHgjZkNwxRShtpQYMrOZbAav1D2D+2fta28eH?=
 =?us-ascii?Q?8RmWHqRcv90nUNzqS30+D2kTWMg5gjsH2bw1VsMexStM1R0gvedoBt5Oev8j?=
 =?us-ascii?Q?PEMVe8bYP6W0UgjtAUFQ6vaRevXA1IalFbiNVen3KTJZsnP9UJqwS9bAeV9t?=
 =?us-ascii?Q?ESOsvt8dLAW4yGdJJr9Ote7bZvLKb9roO/AH7b8AG23T3YT0qz5I7LtdAQvU?=
 =?us-ascii?Q?h28Zeyfc+PasIAcz41Ex1sdzFFfUP74KtAMU2VbojvCdo9W0jwYfRyvGbPQt?=
 =?us-ascii?Q?X/puesS5dA1gIndvkFlDwWDfks92qKtuLxBOkF03uUY//ZQ/RQcq7xt/oxDx?=
 =?us-ascii?Q?MSvBpAS4gMeuD18zBw0HCa/Di8Fhog6RbV2hXyWwgMWC/+5RkuB+dsXe/PfB?=
 =?us-ascii?Q?KCgeeRaYSm4lM0yuuP3PNsCjuQw+mJ4OxnUdFjIoouQJ84HETL7DXXvWsUVV?=
 =?us-ascii?Q?EP6g8gv9uHXaHhvsceHXXH7pvkvXwCZUd/TjCnWLIIAtE2fOTYtQDgfOXjpT?=
 =?us-ascii?Q?KYqi1xe7HU2Ysfh4xZdJa+CAZpT2Fxu3tGE9J3XH4/f8IdXwTnxk5fFxTyQo?=
 =?us-ascii?Q?OzxXVxzymNh0K75FePNj/lUcMjV90pVG0HS/LJCBChpGZUsl44KmBjwlCCSn?=
 =?us-ascii?Q?e1589+fXyVs7jiQ1Izr6T0GnENYMdjImBQO+Ye1Bm0HVxtgmsSZNsJ+N04p7?=
 =?us-ascii?Q?AAgDqMu1J/g/g4J8X+eg6N55pWCVZ68vT2TjfUUV9mqLg0hhMgJIXWvuroK/?=
 =?us-ascii?Q?Qv28IDjUBeo8/UBryex5Uj1Own5Y3yhIEiu6pp3IAk7Eaxbc2sFy4Nr/pWN5?=
 =?us-ascii?Q?lSBaYSwlkZ/PCAg2Kt0ispc2Zx6QeHZQpvLEhz9NL7mLSKedo/rPGHBxVqWL?=
 =?us-ascii?Q?fv22I43A/FlimJsSRuax4ActjYny+AwwhQmcf7REOCGEuqr+L9j0es8ezU33?=
 =?us-ascii?Q?FVILGzKUpuhSVbs9dFrt+9GP1/PSLXp8OBTjUz4RdG5lIE7QZdD6r1i4Wkut?=
 =?us-ascii?Q?Xq5749hfAvOGDKhDEfl0eqNO0t909ASQv+2T41fmR98J/Jeusn58MaE97+Sn?=
 =?us-ascii?Q?livBez3LEngdfCfH7G+tMupIGOnTMD1d3JHd1gxRZ1XAGTEUyncnk/H2Ir8U?=
 =?us-ascii?Q?hxxwewSJbIR9POWyUZQe91ldIQQyiCjg9Pchp1hwqjB9IM9dpvOrkVLNE4lI?=
 =?us-ascii?Q?b82AcEDb4FT2wfJF7U05VZPnymUiMkue8N1ChSnxM9yOkZErSPfFiqt3JFiU?=
 =?us-ascii?Q?gUpTk+3aHjJJdPclyv4BJPAOXb+j5u8HeNlHf2mfWAc/+/wKhH19G3wEDmBJ?=
 =?us-ascii?Q?YLfT7oqyjBLgJbpNZTR3qzo+f70rEfkM5PRFbGmCzSQna38txxjrNm0hgZVo?=
 =?us-ascii?Q?+7oLFsbSqLaGfN1tPv76v+dpX5Ge9CHV2ytzHjzEXWkKkeAaZj6ewewmROcv?=
 =?us-ascii?Q?nNnWjetFv9zfWr03m0plJth30qQCqtsRWkrASlI9kuvx0bK6O5o78XMWhmHM?=
 =?us-ascii?Q?Z8dk8H7yfE6OFgM5pDtmRxN1F5WbSXMCRgUjoWF//pS55daLS2W9NTw9LSJi?=
 =?us-ascii?Q?uBk5EkMNmQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1381c82-c562-4213-3ab2-08da2e7ad1aa
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 May 2022 09:37:06.4672
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CfSdUJf4YJXaIVA2my+W7adlFDh0kdfU/s2kPa3CMQ595vJYMFUBpK0RnCvxkZDXcweRTRv50KlJ5e8bgHXOpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1688
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Wu, Hao <hao.wu@intel.com>
> Sent: Thursday, May 5, 2022 2:35 PM
> To: Zhang, Tianfei <tianfei.zhang@intel.com>; trix@redhat.com;
> mdf@kernel.org; Xu, Yilun <yilun.xu@intel.com>; linux-fpga@vger.kernel.or=
g;
> gregkh@linuxfoundation.org
> Cc: linux-kernel@vger.kernel.org; Matthew Gerlach
> <matthew.gerlach@linux.intel.com>
> Subject: RE: [PATCH v4] uio: dfl: add HSSI subsystem feature id
>=20
> > -----Original Message-----
> > From: Zhang, Tianfei <tianfei.zhang@intel.com>
> > Sent: Thursday, May 5, 2022 8:16 AM
> > To: Wu, Hao <hao.wu@intel.com>; trix@redhat.com; mdf@kernel.org; Xu,
> > Yilun <yilun.xu@intel.com>; linux-fpga@vger.kernel.org;
> > gregkh@linuxfoundation.org
> > Cc: linux-kernel@vger.kernel.org; Matthew Gerlach
> > <matthew.gerlach@linux.intel.com>; Zhang, Tianfei
> > <tianfei.zhang@intel.com>
> > Subject: [PATCH v4] uio: dfl: add HSSI subsystem feature id
> >
> > From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> >
> > Add the Device Feature List (DFL) feature id for the High Speed Serial
> > Interface (HSSI) Subsystem to the table of ids supported by the
> > uio_dfl driver.
> >
> > The HSSI Subsystem is a configurable set of IP blocks to be used as
> > part of a Ethernet or PCS/FEC/PMA pipeline.
> > Like the Ethernet group used by the N3000 card, the HSSI Subsystem
> > does not fully implement a network device from a Linux netdev
> > perspective and is controlled and monitored from user space software
> > via the uio interface.
> >
> > The Feature ID table of DFL can be found:
> > https://github.com/OPAE/dfl-feature-id
>=20
> Is it possible to have multiple different HSSI implementations?
> Will they share the same feature id or not? If yes, why uses a generic na=
me
> here?

The HSSI subsystem is a new design, there will use for a long time.

>=20
> Is it possible someday this feature id is marked as legacy not used and i=
ntroduce
> a new one as the same name?

No, this HSSI subsystem is a standard device which  was designed for OFS.=20
It will extensively use for Intel FPGA PAC card in the feature.

>=20
> >
> > Reviewed-by: Tom Rix <trix@redhat.com>
> > Acked-by: Xu Yilun <yilun.xu@intel.com>
> > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> > ---
> > v4: add Reviewed-by and Acked-by tag and add Feature ID table url in
> > git message.
> > v3: change the name of this feature id to HSSI_SUBSYS and rewrite
> >     the git message.
> > v2: add HSSI introduction and the git repo of Feature ID table.
> > ---
> >  drivers/uio/uio_dfl.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c index
> > 89c0fc7b0cbc..8f39cc8bb034 100644
> > --- a/drivers/uio/uio_dfl.c
> > +++ b/drivers/uio/uio_dfl.c
> > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev)
> > }
> >
> >  #define FME_FEATURE_ID_ETH_GROUP	0x10
> > +#define FME_FEATURE_ID_HSSI_SUBSYS	0x15
> >
> >  static const struct dfl_device_id uio_dfl_ids[] =3D {
> >  	{ FME_ID, FME_FEATURE_ID_ETH_GROUP },
> > +	{ FME_ID, FME_FEATURE_ID_HSSI_SUBSYS },
> >  	{ }
> >  };
> >  MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
> > --
> > 2.26.2