Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1878614iob; Thu, 5 May 2022 09:57:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxEyjZHE6WUUU4OZAxNfWS14thsR3P4m2vYKU4IElCDjooNQ2bsP5tSR3Dy7M5L7tRjShuC X-Received: by 2002:a17:907:72ce:b0:6f4:d139:c2b1 with SMTP id du14-20020a17090772ce00b006f4d139c2b1mr8641310ejc.563.1651769872304; Thu, 05 May 2022 09:57:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651769872; cv=none; d=google.com; s=arc-20160816; b=mWUXK1QmDokC1NnEj1PspOQWihv2SLHWGLSnjo4SXlzMMyzSNKbCosQUQiHukZ+knp A4TCyDHvnoBzwwBVvM6tFcYuMuCYbI6Y0DzGFo21twxDAPM5+b3HuNEzWXg73K1PXKbt 92lUeLqwTM2/mQSbS6Yr471aXg47RjX1mIfp/u4YiVI6jzfN82IR+PFb3ZehP57lY69f YObf1n2umpJvcfmqLYTRMKxES83ZxZjZg3K5YtGOSzPsPYDaD037/vIaevMa4EEIIqPL U6e0rgcazjiCtOh9zf8GrcVWKqrRetcWaa71BsZAM48FxK12/6az8nlUc+1lyzb23tse cvlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=VrihqZSDLqPpwzGZhjQ9aNikHYsdrdgnpWJv362gUXg=; b=EZrkYikf1XeEarx0iH/Rp+Cu/wAb2LyFWhn4zSZUzS+0lBBZ5NKhMgUa3fDW4WEpvZ S2iDZ3vouW0x9tL4JSSkNodRfa40CUTonBJuxg7C9+DVjNvbBOq6Iq1VRprd4pGEVyPO 3piWcQyk0FyYnwhctRGG6lUZWEc0dF7MqB1gluTLtEyS5P5ZOjjoW9QSvWW07yIkp4OK kO1gv1Dyrgx18FG1gVezbW1HvMMZvFHI62iNDdvsrIusvm7fhJ2uhRlLJFVJBsVmW9lc Ex2YV5Ajix7As9Zh8DHlVN2Utui1vemghleFOPvyxXHFdYT6FKkgPku0ZgrmzV9pqbz7 Jpow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=pmOddYi5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hk23-20020a170906c9d700b006f3e2818261si2905119ejb.327.2022.05.05.09.57.28; Thu, 05 May 2022 09:57:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=pmOddYi5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358652AbiEDRey (ORCPT + 99 others); Wed, 4 May 2022 13:34:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356971AbiEDRJw (ORCPT ); Wed, 4 May 2022 13:09:52 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 329914755F; Wed, 4 May 2022 09:56:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DAFF1B8278E; Wed, 4 May 2022 16:56:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BE4CC385A5; Wed, 4 May 2022 16:56:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651683407; bh=1Vi5lNYXaB4VTTLQ+lFez2oNueieHQTfkFWql+43bVk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pmOddYi5u+2KkENLHRahMOS33DnLigcOWF0OxG9rRZ0W5sk+dsO9g56ZN8Y9yFNxh j4tLBY9MolyzEiPYr5mxT64X+Ze9YaZZMW4HAmwaOUgLq528zb2ITRDMH9NhKJ8GHh r86kDUA+8akF/PoeLip6dHskYRDfMNv9suwiodQg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Tony Lindgren , Sasha Levin Subject: [PATCH 5.17 078/225] ARM: OMAP2+: Fix refcount leak in omap_gic_of_init Date: Wed, 4 May 2022 18:45:16 +0200 Message-Id: <20220504153118.226650389@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220504153110.096069935@linuxfoundation.org> References: <20220504153110.096069935@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit 0f83e6b4161617014017a694888dd8743f46f071 ] The of_find_compatible_node() function returns a node pointer with refcount incremented, We should use of_node_put() on it when done Add the missing of_node_put() to release the refcount. Fixes: fd1c07861491 ("ARM: OMAP4: Fix the init code to have OMAP4460 errata available in DT build") Signed-off-by: Miaoqian Lin Message-Id: <20220309104302.18398-1-linmq006@gmail.com> Signed-off-by: Tony Lindgren Signed-off-by: Sasha Levin --- arch/arm/mach-omap2/omap4-common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c index 5c3845730dbf..0b80f8bcd304 100644 --- a/arch/arm/mach-omap2/omap4-common.c +++ b/arch/arm/mach-omap2/omap4-common.c @@ -314,10 +314,12 @@ void __init omap_gic_of_init(void) np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-gic"); gic_dist_base_addr = of_iomap(np, 0); + of_node_put(np); WARN_ON(!gic_dist_base_addr); np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-twd-timer"); twd_base = of_iomap(np, 0); + of_node_put(np); WARN_ON(!twd_base); skip_errata_init: -- 2.35.1