Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4d30b811-b452-cbf0-a3e3-00e400ba76ef@suse.com>
Date:   Thu, 5 May 2022 12:21:55 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for
 Dell usb gen 2 device to not fail during enumeration.
Content-Language: en-US
To:     monish.kumar.r@intel.com, gregkh@linuxfoundation.org,
        olebowle@gmx.com, oneukum@suse.com, vpalatin@chromium.org,
        wangjm221@gmail.com, chris.chiu@canonical.com,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
CC:     abhijeet.rao@intel.com
References: <20220505101459.7804-1-monish.kumar.r@intel.com>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20220505101459.7804-1-monish.kumar.r@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SkHcT2jgZPGmcifVHuqYWlaH3KNBxVbc+V0BFz00vQltrkR7IAyC+Dq+sYsT?=
 =?us-ascii?Q?36KA0Kq883fLWVeSLUOYWkJlGJE4CE0umC2UJsL8pl/5KJIz40xpX1tNOAe6?=
 =?us-ascii?Q?WYx0gQQAS7/jAE9NuYAqJ9ElZ2X6GaU4ABB70uen/eRp+yennzMG2CdF0QX1?=
 =?us-ascii?Q?omA++uLP2LJAALRLYtolgZc7pyfk0Xadwz0AIZRmGybnSc63xZrD2hcyeqdk?=
 =?us-ascii?Q?q1eKc/6FQK5Rn9ZU9OVR6GYubMg/KKwVBbgCcCko+lecisJc88Hmytk7T86w?=
 =?us-ascii?Q?mczpVz9R1ZT8L+lGlB8IgtOBRjZc/H6pnoERRKID+VSQ7PO0Ea/S75LufRmq?=
 =?us-ascii?Q?BBSiBSXI1A7p4PJ+k23gHuTnicUTNrS+I5UU1nCB0lmRvQBmAKyeQ99L6cKt?=
 =?us-ascii?Q?/1WYXjHAhspmjl6z7rVZ4u1YrWvyGBRnA+mwEwr0F8S21Tktg4Mmsf6TjA97?=
 =?us-ascii?Q?oKu+LmVUzc9uEj09GhnrxiuOfJ0F6DJHcQ12XbfhkrX6M82p3rEX0DVYvaSL?=
 =?us-ascii?Q?c6BI0jcGOeWjChcuO6lm3coAYJonP0EQI9b0FAfd0sOTLmt9BWtRTzaqplZE?=
 =?us-ascii?Q?oGtJ7QhNA8S5h44lU2IO9o+GRGWs5T8XaaLgOfgGJn179tmVaN5Fr6GccZyx?=
 =?us-ascii?Q?v2U327462I8f9c3dPf3LN4lrutP30AXBbKF68frlLnNM/9M0TCX2nl1LZTcO?=
 =?us-ascii?Q?xD7BRJUAGtZqOTUVnnylSjwTuQ6aTEgnQtn80TGwNMacdMPwqz65kuSiLsQq?=
 =?us-ascii?Q?MlmkyYpfBcMDyLJwDcxOyK/qI6GbGJ75IUMKHGYQegR/uW9ZMxUlup6qRlMG?=
 =?us-ascii?Q?LxSIoyjmRkjVzQd/gJLrxlozIDmIL+5N079r5H7aw0kxK8Eb4toP6uBy2U3Q?=
 =?us-ascii?Q?/PwD7nYGSXyVc05D6/ebT0M2m2KHiLmK3i6aabNOvB1HZjWOfWg3MgSA+pCc?=
 =?us-ascii?Q?v6mVBxqrtUzHcWhvbZU1DAsmKNtUNXsK6csXhhoSSdfm8pkhwN4d4QPAWxyy?=
 =?us-ascii?Q?YJQKlzylHppiekbaoqEq9yygS8/3bKpAjI1UALsabskEY7h+Sf1PC8LnAOUs?=
 =?us-ascii?Q?T/dFaqBhfqWEnY2shNvzUD80UCbXnRIqUz08cGt73CW71NFTEYU1u2oqlgYo?=
 =?us-ascii?Q?LXsP0cWIek4TGa1oXqQjV5yqZRcEAoqT3wq/UmaoA/vnhWvMFq+WaTMHbVKl?=
 =?us-ascii?Q?sLZaYYHIoohWU7WzCqicPiFoo1nnD1nanFbK7wjm1TYgTLv5kkDbHfwZ5+VM?=
 =?us-ascii?Q?h9dT6qOXpl6IgDcEPQ9j8R4k8lLi6zmdgjw+EYoCsqACutWzlyTYEmutcwg2?=
 =?us-ascii?Q?CJOOPF6PlTK3wI45hobXYO8UiyIvXVwnyDpPYEq2I8SoLdcruQiuhbJm/STm?=
 =?us-ascii?Q?BGANcsFoNQlE/CqMHDg6EagikaZsEJALdIM2AzuRvFhHdDbWIcE/02Tbik2o?=
 =?us-ascii?Q?WFREtxzDN3zJxvs+zgKMLVmOZb7jyi9pSPovshK0Y7E82q3cei/VcIq5+OxG?=
 =?us-ascii?Q?lys+M6oDbjIQgvR0aQII6C7s/xIz5i1qWZQ4i/zS2fwxFlLnOq5Y5WTLB1Kk?=
 =?us-ascii?Q?YijuE5KWMAh7jib+YFIhgSasgNSCr5mEB9VOTdbb31+Qb0EIfyKP6z1aTjtc?=
 =?us-ascii?Q?S5SD06v8xCCXNhn/+Kr/40tAC+sr/r1qqQO/HnKJFmosQ1p68x4PM/gf6u2B?=
 =?us-ascii?Q?B8Q9MhMa6Nd+ujc92o4XDRXI7WQatk4ymV79Qz7zNga9VMZUJHI7wS32bpbX?=
 =?us-ascii?Q?aA80Rf0Pe2LLzvON2w+LgU8r/q2gu7gaA4zkCgmjWigdzMk5yygenVxdQW0t?=
X-MS-Exchange-AntiSpam-MessageData-1: xHp1fel7PMXdBw==
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 64215c63-ec8f-45bd-cc9f-08da2e8115ff
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0401MB2526.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 10:21:58.2497
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Utu2CgSVnUuByOmwNObCPCklPgFd3SCH/sfSrALYJK9VXSIIhzbmYRwhji9OKEHUNmcNmQi2K5zkxeMpfep1nA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5482
X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 05.05.22 12:14, monish.kumar.r@intel.com wrote:
> From: Monish Kumar R <monish.kumar.r@intel.com>
>
> Signed-off-by: Monish Kumar R <monish.kumar.r@intel.com>
> ---
>  drivers/usb/core/quirks.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 97b44a68668a..257ac37464e8 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -515,6 +515,10 @@ static const struct usb_device_id usb_quirk_list[] =
=3D {
> =20
>  	/* INTEL VALUE SSD */
>  	{ USB_DEVICE(0x8086, 0xf1a5), .driver_info =3D USB_QUIRK_RESET_RESUME }=
,
>        =20
> +	/*DELL USB GEN2 */
> +	{ USB_DEVICE(0x413c, 0xb062), .driver_info =3D USB_QUIRK_NO_LPM },
> +	{ USB_DEVICE(0x413c, 0xb062), .driver_info =3D USB_QUIRK_RESET_RESUME }=
,
> =20
>

Hi,

could you please

1) keep the list in nummerical order from lowest device ID to largest
2) combine both quirks with a binary OR
3) provide a short reason for this patch like "found in own testing" or
"reported on list"

=C2=A0=C2=A0=C2=A0 Regards
=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 Oliver
=C2=A0