Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759346AbXEJLLI (ORCPT ); Thu, 10 May 2007 07:11:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753250AbXEJLK5 (ORCPT ); Thu, 10 May 2007 07:10:57 -0400 Received: from nz-out-0506.google.com ([64.233.162.234]:45580 "EHLO nz-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752869AbXEJLKz (ORCPT ); Thu, 10 May 2007 07:10:55 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=IRv2UI0zkFb+k2IcGDE5MezzNgDNbkmzfR3LN8hlMOlIrscvH7Cfzi+DV404o0ulAH1lOSTJTC3hxOlOWGX+cz1k02DnvNvY3TfnqSVaS9vKRajPNpkatn/ZUwcF94aqaZlprTflvoG1wFo2999CdLKiIXMqjKSp/rLmOMr1jfE= Message-ID: Date: Thu, 10 May 2007 08:10:54 -0300 From: "Kevin Winchester" To: "Herbert Xu" Subject: Re: 2.6.21-mm1 and now 2.6.21-git: SLUB Crashes on boot - crypto? Cc: "Andrew Morton" , linux-kernel@vger.kernel.org In-Reply-To: <20070509030257.GA31876@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070505014955.8f3990b5.akpm@linux-foundation.org> <4640FE35.2070605@gmail.com> <464108CC.3060604@gmail.com> <46411CA1.8060506@gmail.com> <20070509030257.GA31876@gondor.apana.org.au> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2228 Lines: 65 On 5/9/07, Herbert Xu wrote: > On Tue, May 08, 2007 at 09:58:09PM -0300, Kevin Winchester wrote: > > > > Not having any idea what I'm doing, I looked at cryptomgr_probe and > > cryptomgr_notify, and can't seem to see much, except for the following > > odd lines. > > > > From cryptomgr_schedule_probe, which is almost certainly inlined into > > crypto_notify: > > Thanks for reporting this. This patch should fix the problem. > > Cheers, > -- > Visit Openswan at http://www.openswan.org/ > Email: Herbert Xu ~{PmV>HI~} > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt > -- > diff -puN crypto/cryptomgr.c~crypto-fix crypto/cryptomgr.c > --- a/crypto/cryptomgr.c~crypto-fix > +++ a/crypto/cryptomgr.c > @@ -24,8 +24,6 @@ > #include "internal.h" > > struct cryptomgr_param { > - struct task_struct *thread; > - > struct rtattr *tb[CRYPTOA_MAX]; > > struct { > @@ -81,6 +79,7 @@ err: > > static int cryptomgr_schedule_probe(struct crypto_larval *larval) > { > + struct task_struct *thread; > struct cryptomgr_param *param; > const char *name = larval->alg.cra_name; > const char *p; > @@ -130,8 +129,8 @@ static int cryptomgr_schedule_probe(stru > > memcpy(param->larval.name, larval->alg.cra_name, CRYPTO_MAX_ALG_NAME); > > - param->thread = kthread_run(cryptomgr_probe, param, "cryptomgr"); > - if (IS_ERR(param->thread)) > + thread = kthread_run(cryptomgr_probe, param, "cryptomgr"); > + if (IS_ERR(thread)) > goto err_free_param; > > return NOTIFY_STOP; > _ > I see that this patch made it in to mainline, and latest -git now works for me, so I assume this was the correct solution. I thought I had tried this exact change without success when I was looking at the problem, but I guess I did something wrong along the way. Thanks for the fix, Kevin - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/