Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1939776iob; Thu, 5 May 2022 11:20:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx2Ny7mcR2I/D6vFJ5xK537mHFH97MH4SXw38tJfGpYEfelk1AB8VN3g0ry+TDshnF5B7W1 X-Received: by 2002:a17:903:215:b0:15e:cae9:7622 with SMTP id r21-20020a170903021500b0015ecae97622mr8889473plh.28.1651774822447; Thu, 05 May 2022 11:20:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651774822; cv=none; d=google.com; s=arc-20160816; b=n6Qlj5RzirPZW+AHWnDptA/CvK+PkBGB7zW56naM9udn//LE477dX58Mc+BgO5NZKi EARnSS25B6IngPOHp7J4Bg45EnQZWE6ortKLcDvvJsoO0B9OTVW2aKKaKNolYaFUeNn5 5BKXPxpk+/0fp4d1q9+RpsUZNUYWnzOJvUpVnb2GPNgQKEMx1cS1iF0oZFH118cW2zPa r7utfeuoQIhbad1ekBktr755I6xjUxss/3VXG6LKLMXNr/LX4/2giHOCS1YxCtzroa1L 4gcNgyE4C2gguplhxkmFkURjihZtuN7LJqsjBDx1KfzaWvyctzMn5h8HOL4vsAdHHkPc varA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=A2O8bjwZENlD8XEuFERh5dFyvLpdrvHSJKL6/B4/1S0=; b=RBO/mN9i3RYOWN52HlhCB62BYl3HrU1+HVScxhHlDH3a20yOSdjv7J4dU9LfE7NuK8 rWdIQ/aO9PZAlNgkYCZ2+V0saeIOuQnNIM4wjpnPFoXakDDWzhTXRJh8eQCCRRT8L3b6 to6wjdCQXkjzz8R2RMs8gx6sJYaY6zCo2Tv7RPumxe83cMQdZNf8Sl7sWLiF5nHlH/Yy slE4CZL8us6g1TKfNA8RhklNGv4DGpBy0GCqiJOcUCrCy9qLS0E9CXVyT+YYuxtuzczF dzoE2oj1R7QTOMoze8xWDFPx4eQCQ+ky+uxqP1BJr/O1Au7Dj1qA/mNtXOz/PICJoge9 /Psg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=JJBLr1i0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id il15-20020a17090b164f00b001d2865c095fsi3307674pjb.61.2022.05.05.11.20.04; Thu, 05 May 2022 11:20:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=JJBLr1i0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358697AbiEDRso (ORCPT + 99 others); Wed, 4 May 2022 13:48:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357367AbiEDRPA (ORCPT ); Wed, 4 May 2022 13:15:00 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 687644C432; Wed, 4 May 2022 09:58:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B83D7B82737; Wed, 4 May 2022 16:58:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E647C385AA; Wed, 4 May 2022 16:58:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651683498; bh=Cj423LBW0JOAkn2kSvevRr0JyLnJVh1uaZY7/j2THy8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JJBLr1i0sLreVvBVNY75i+lmR3PF0lgwFMmLi38p0O7sNktLqyCF6kYWD42/w1IfC RrObGg/tdS/bp27TKgrIGw7mOE1cCOUdAOmxSfwmrgl9CxzB4u3W5QmF2omzYi95JP rGHU8ZbBRasYtipKVv8ZPgUIV4AYTKzbWgIPuPiM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Joseph Ravichandran , Jens Axboe , Sasha Levin Subject: [PATCH 5.17 156/225] io_uring: fix uninitialized field in rw io_kiocb Date: Wed, 4 May 2022 18:46:34 +0200 Message-Id: <20220504153123.976903087@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220504153110.096069935@linuxfoundation.org> References: <20220504153110.096069935@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joseph Ravichandran [ Upstream commit 32452a3eb8b64e01e2be717f518c0be046975b9d ] io_rw_init_file does not initialize kiocb->private, so when iocb_bio_iopoll reads kiocb->private it can contain uninitialized data. Fixes: 3e08773c3841 ("block: switch polling to be bio based") Signed-off-by: Joseph Ravichandran Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- fs/io_uring.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/io_uring.c b/fs/io_uring.c index 531d0086d0b3..87df37912055 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -3584,6 +3584,7 @@ static int io_rw_init_file(struct io_kiocb *req, fmode_t mode) if (!(kiocb->ki_flags & IOCB_DIRECT) || !file->f_op->iopoll) return -EOPNOTSUPP; + kiocb->private = NULL; kiocb->ki_flags |= IOCB_HIPRI | IOCB_ALLOC_CACHE; kiocb->ki_complete = io_complete_rw_iopoll; req->iopoll_completed = 0; -- 2.35.1