Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Wu, Hao" <hao.wu@intel.com>
To:     "Zhang, Tianfei" <tianfei.zhang@intel.com>,
        "trix@redhat.com" <trix@redhat.com>,
        "mdf@kernel.org" <mdf@kernel.org>,
        "Xu, Yilun" <yilun.xu@intel.com>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Matthew Gerlach" <matthew.gerlach@linux.intel.com>
Subject: RE: [PATCH v4] uio: dfl: add HSSI subsystem feature id
Thread-Topic: [PATCH v4] uio: dfl: add HSSI subsystem feature id
Thread-Index: AQHYYBXhbDfzmBtOIEy5kNhTwRg2C60P0h9g
Date:   Thu, 5 May 2022 06:34:55 +0000
Message-ID: <DM6PR11MB38197DBE27837090E0C9165985C29@DM6PR11MB3819.namprd11.prod.outlook.com>
References: <20220505001628.681226-1-tianfei.zhang@intel.com>
In-Reply-To: <20220505001628.681226-1-tianfei.zhang@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.401.20
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?O0TqLGDBHy1T4X4HvgJSoCPsEFkfbrfcErpsYuWY6f2d9vo+d2X+bM+unn6B?=
 =?us-ascii?Q?gJ/Gm07kdjpRH29EpuZEHus86Ux/ZtrZfe90aUgB72dtNwOXyrbK3Jnx5sCD?=
 =?us-ascii?Q?BFBXxo9y16T/Pt3/wLwyzActQaNYWrVoGTT3BBW9f1qK9xLY8R+GNIVxLUNj?=
 =?us-ascii?Q?ammwU1XhuhvK843DoRbicCmvJdwNnUDXyW5jTg82Wep5RRWVuIUxkDogklTa?=
 =?us-ascii?Q?c2ZriLlxwU3g2Ujp8zGud1I0BSDw4vVWMyG+sj8u1BsOP61MDBLdfriNG887?=
 =?us-ascii?Q?sAws2QIqqtYGNKAGqDTGQfH174iuEutgGLr55uFeLTutLNkQdc+KGZNdDtk/?=
 =?us-ascii?Q?FUpZ+MyS0UfIPc+LA+BhuwSKYMMBrZc18NoQ0vnBat0ruB/Fe2Z//ElUo0hb?=
 =?us-ascii?Q?VsDUb6yXyEWOxyvDepwnsR4tFtGcW5yuJUxGYyuhgPJ5xTzWz/Yft29HMyk5?=
 =?us-ascii?Q?QMPbSeip3Iu5OhUZYcMYjxPJMUFDA+pt06iWFcHZqNwtaBdcAB1PjCOf2O6q?=
 =?us-ascii?Q?0eyqEz4pLUJCJDaODjGcPCqqhiiV2FO5jgls9ukjnCTKkb1VPjAI/Ny8Ko19?=
 =?us-ascii?Q?x6fR0XnIpP7d4RJo50Y4i0QwSUvbMS3ZOiAJEB1PJBnokmLfVay4pBREeNur?=
 =?us-ascii?Q?ch5HhUo9Go4CzDA1PWbtRyP01kJsL/9n+9RT56M4zQzfV6fFmYiOP7drKZDn?=
 =?us-ascii?Q?iq9+Ocyn2njBRvAD41UiD+eVJ52xJzxv2m3mhfHTn1+IF0sVzh5vKURrRfjn?=
 =?us-ascii?Q?9X0DNXVZ4QYmVid0ihm/VMOA4G9/c0qUb5Beehb0IjCRHT1fpbtfZ2q9Sknm?=
 =?us-ascii?Q?PBpNBMcgs3SNY5g6j4Cs3gREE6FzVONPnbtbalTqqGjXrT1iGutL8gPXXdHS?=
 =?us-ascii?Q?WoTPtd8Oj5otMNR+oTf6yanPhoI8U29mM5TUJwjf/PdehFvPCrRGjg9f4uLZ?=
 =?us-ascii?Q?n/vKEwhomIAsPVzNWMQzlEcEH4wDvDFJmWzYts/kQ5bPux5d8SSdf7J6groq?=
 =?us-ascii?Q?XjDQ7N8UuUHlreZLqA4JatS7UwDisTCaAoQkku4P1LB6oCh9dE9MDtw6NwMR?=
 =?us-ascii?Q?M/RPpZ4rBhDRgiolG670MychGHybhdEu9erfb2fzEbqbONJbiRC1rsMlVsjj?=
 =?us-ascii?Q?Y25KYrzZByoeQJeP+2jtHIBjCRz2KqiPuHwhZKzaOW+6B2Jslm/3UXOj3ZFO?=
 =?us-ascii?Q?dSbLMaNOalwbJhliuuDvoZaVPjmzBNKHkc8+q8JinL5wFRSfDTTlyqZy8/II?=
 =?us-ascii?Q?U7+vXOGtan3sV0JhEtRa9JpYj7UcaWPOSYbjXIjpXyAV9x+REqZXwHInOTGs?=
 =?us-ascii?Q?6xUrsj5r9WaQ6HQnCEFA4Woiw0JG0q7mDA5YaimlHSiN1yU/zfS5Ze3fzU3Y?=
 =?us-ascii?Q?dCDUrHPUvTgU0hgDrBGchm47jkkGOWV00y2zvS7z4G9/C3uASRbKHcn2R+pl?=
 =?us-ascii?Q?+oCGMnqA9xCqKOc8F9c46teEzM3u0WG1A5DLw8D5bHmEOOR/oZFDRRV2xOYB?=
 =?us-ascii?Q?62HgMpKsLJmi5k6GMbNH+Zu+DKe5Gplj9ibo+aNFYvNluktBEtwTvK9pxVv9?=
 =?us-ascii?Q?uWdD9wNAOeDAjs3Y+FUq4oxoBiF2y512nGMT40sY/9mo1ZM9eAO+Nw+JbxF6?=
 =?us-ascii?Q?+bFTPhqLYWibjIAy6idnBTzLrLlLXB4SMMwxTft+Gek5LRhAk/NBdH9HZYuK?=
 =?us-ascii?Q?R2xVdlYWHYtfmHX+gcROKu0GWz/iesxf1MykwtgmPImFiLjh3vCQBAvOYI8c?=
 =?us-ascii?Q?ddjEKgPe+g=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3819.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01f2419c-736c-4efa-2e79-08da2e615e6d
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 May 2022 06:34:55.7109
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: w7Q35UUY/p8iWsN1iV2TMd3hIYPuUWAw1vIHwr8x5ZlBfsYrcWxO5mHIpAM2q6JCe3p6jkvbwConOAxEWxOFeg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1746
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Zhang, Tianfei <tianfei.zhang@intel.com>
> Sent: Thursday, May 5, 2022 8:16 AM
> To: Wu, Hao <hao.wu@intel.com>; trix@redhat.com; mdf@kernel.org; Xu, Yilu=
n
> <yilun.xu@intel.com>; linux-fpga@vger.kernel.org;
> gregkh@linuxfoundation.org
> Cc: linux-kernel@vger.kernel.org; Matthew Gerlach
> <matthew.gerlach@linux.intel.com>; Zhang, Tianfei <tianfei.zhang@intel.co=
m>
> Subject: [PATCH v4] uio: dfl: add HSSI subsystem feature id
>=20
> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>=20
> Add the Device Feature List (DFL) feature id for the
> High Speed Serial Interface (HSSI) Subsystem to the
> table of ids supported by the uio_dfl driver.
>=20
> The HSSI Subsystem is a configurable set of IP blocks
> to be used as part of a Ethernet or PCS/FEC/PMA pipeline.
> Like the Ethernet group used by the N3000 card, the HSSI
> Subsystem does not fully implement a network device from
> a Linux netdev perspective and is controlled and monitored
> from user space software via the uio interface.
>=20
> The Feature ID table of DFL can be found:
> https://github.com/OPAE/dfl-feature-id

Is it possible to have multiple different HSSI implementations?
Will they share the same feature id or not? If yes, why uses a
generic name here?

Is it possible someday this feature id is marked as legacy not used
and introduce a new one as the same name?

>=20
> Reviewed-by: Tom Rix <trix@redhat.com>
> Acked-by: Xu Yilun <yilun.xu@intel.com>
> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> ---
> v4: add Reviewed-by and Acked-by tag and add Feature ID table url in git
> message.
> v3: change the name of this feature id to HSSI_SUBSYS and rewrite
>     the git message.
> v2: add HSSI introduction and the git repo of Feature ID table.
> ---
>  drivers/uio/uio_dfl.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c
> index 89c0fc7b0cbc..8f39cc8bb034 100644
> --- a/drivers/uio/uio_dfl.c
> +++ b/drivers/uio/uio_dfl.c
> @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev)
>  }
>=20
>  #define FME_FEATURE_ID_ETH_GROUP	0x10
> +#define FME_FEATURE_ID_HSSI_SUBSYS	0x15
>=20
>  static const struct dfl_device_id uio_dfl_ids[] =3D {
>  	{ FME_ID, FME_FEATURE_ID_ETH_GROUP },
> +	{ FME_ID, FME_FEATURE_ID_HSSI_SUBSYS },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
> --
> 2.26.2