Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <15f5f8d6-dc92-d491-d455-dd6b22b34bc3@redhat.com>
Date:   Wed, 4 May 2022 20:31:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v8 23/70] mm/mmap: change do_brk_flags() to expand
 existing VMA and add do_brk_munmap()
Content-Language: en-US
To:     Janosch Frank <frankja@linux.ibm.com>,
        Liam Howlett <liam.howlett@oracle.com>,
        Heiko Carstens <hca@linux.ibm.com>
Cc:     Claudio Imbrenda <imbrenda@linux.ibm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Guenter Roeck <linux@roeck-us.net>,
        "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Yu Zhao <yuzhao@google.com>, Juergen Gross <jgross@suse.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        Andreas Krebbel <krebbel@linux.ibm.com>,
        Ilya Leoshkevich <iii@linux.ibm.com>,
        Thomas Huth <thuth@redhat.com>
References: <20220426150616.3937571-24-Liam.Howlett@oracle.com>
 <20220428201947.GA1912192@roeck-us.net>
 <20220429003841.cx7uenepca22qbdl@revolver>
 <20220428181621.636487e753422ad0faf09bd6@linux-foundation.org>
 <20220502001358.s2azy37zcc27vgdb@revolver>
 <20220501172412.50268e7b217d0963293e7314@linux-foundation.org>
 <Ym+v4lfU5IyxkGc4@osiris> <20220502133050.kuy2kjkzv6msokeb@revolver>
 <YnAn3FI9aVCi/xKd@osiris> <YnGHJ7oroqF+v1u+@osiris>
 <20220503215520.qpaukvjq55o7qwu3@revolver>
 <60a3bc3f-5cd6-79ac-a7a8-4ecc3d7fd3db@linux.ibm.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <60a3bc3f-5cd6-79ac-a7a8-4ecc3d7fd3db@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 04.05.22 09:37, Janosch Frank wrote:
> On 5/3/22 23:55, Liam Howlett wrote:
>> * Heiko Carstens <hca@linux.ibm.com> [220503 15:49]:
>>> On Mon, May 02, 2022 at 08:50:04PM +0200, Heiko Carstens wrote:
>>>> On Mon, May 02, 2022 at 01:31:00PM +0000, Liam Howlett wrote:
>>>>> * Heiko Carstens <hca@linux.ibm.com> [220502 06:18]:
>>>>>> On Sun, May 01, 2022 at 05:24:12PM -0700, Andrew Morton wrote:
>>>>>>> (cc S390 maintainers)
>>>>>>> (cc stable & Greg)
>>> ...
>>>>>>>> booting.  The last thing I see is:
>>>>>>>>
>>>>>>>> "[    4.668916] Spectre V2 mitigation: execute trampolines"
>>>>>>>>
>>>>>>>> I've bisected back to commit e553f62f10d9 (mm, page_alloc: fix
>>>>>>>> build_zonerefs_node())
>>>>>>>>
>>>>>>>> With the this commit, I am unable to boot one out of three times.  When
>>>>>>>> using the previous commit I was not able to get it to hang after trying
>>>>>>>> 10+ times.  This is a qemu s390 install with KASAN on and I see no error
>>>>>>>> messages.  I think it's likely it is this patch, but no guaranteed.
>>> ...
>>>>>> Liam, could you share your kernel config?
>>>>>
>>>>> Sure thing.  See attached.
>>>>
>>>> So, I can reproduce the hanging system now. However this looks like a
>>>> qemu problem on s390, since I can reproduce this only with Qemu+TCG.
>>>> Qemu with kvm works without any problems (same if I use z/VM as
>>>> hypervisor).
>>>>
>>>> Janosch, Claudio, can you have a look at this please?
>>>
>>> So, at least for me this problem also exists with plain v5.17.
>>> Switching off KASAN, or alternatively switching to KASAN_INLINE
>>> "fixes" it for me with Qemu+TCG.
>>>
>>> Liam, could you please also try to disable KASAN in your config? With
>>> that I think we can be almost sure this could be some bug in Qemu.
>>
>> With KASAN, my tree fails 100% of the time (mm-stable + my maple tree
>> patches)
>>
>> Without KASAN, it boots 100% of the time.
>>
>> I think this verifies with you say above?
>>
>> Thanks,
>> Liam
> 
> I had a short look yesterday and the boot usually hangs in the raid6 
> code. Disabling vector instructions didn't make a difference but a few 
> interruptions via GDB solve the problem for some reason.
> 
> CCing David and Thomas for TCG
> 

I somehow recall that KASAN was always disabled under TCG, I might be
wrong (I thought we'd get a message early during boot that the HW
doesn't support KASAN).

I recall that raid code is a heavy user of vector instructions.

How can I reproduce? Compile upstream (or -next?) with kasan support and
run it under TCG?

-- 
Thanks,

David / dhildenb